click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: KNL-144
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Trivial Trivial
Assignee: David Horwitz
Reporter: Ray Davis
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Kernel - K1

Fix misinformation in db XML comments

Created: 01-Apr-2009 09:15   Updated: 05-Mar-2010 02:45
Component/s: Impl
Affects Version/s: 1.0.4
Fix Version/s: 1.0.6, 1.1.0

Time Tracking:
Not Specified

1.0.x Status: Resolved


 Description  « Hide
The db-components.xml file includes the following explanations of "maxActive" and "maxIdle" properties:

<!-- The maximum number of active connections that can be allocated from this pool at the same time, or zero for no limit. -->
<property name="maxActive">
...
<!-- The maximum number of active connections that can remain idle in the pool, without extra ones being released, or zero for no limit. -->
<property name="maxIdle">

However, DBCP actually accepts zero at face value. As documented at http://commons.apache.org/dbcp/apidocs/org/apache/commons/dbcp/BasicDataSource.html , negative numbers are used to mean unlimited. When I tried to disable idle pool cleanup by setting maxIdle to zero, DBCP instead went into obsessive-compulsive cleanup: every time a client requested a database connection, DBCP would create 10 and then throw all 10 away as quickly as possible, so as to maintain an empty idle pool.

 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
There are no comments yet on this issue.