click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: KNL-175
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Stephen Marquard
Reporter: Stephen Marquard
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Kernel - K1

Presence can be listed for closed sessions

Created: 02-May-2009 01:40   Updated: 05-Mar-2010 02:45
Component/s: Impl
Affects Version/s: 1.0.6
Fix Version/s: 1.0.12, 1.1.0

Time Tracking:
Not Specified

Issue Links:
Relate
 

1.0.x Status: Closed


 Description  « Hide
In unusual cases (e.g. app server temporarily cannot write to the db, network problems, etc.), a session record may be closed, but a presence record is still in existence.

The presence service method getSessions(String locationId) calls UsageSessionService getSessions(joinTable, joinAlias, joinColumn, joinCriteria, fields) which will return a list of all sessions, whether active or not.

This is unhelpful, as closed sessions should no longer have presence, and in any event closed session records may have been archived from the db anyway, so the kernel cannot be expected to meet a contract to return all session info related to closed sessions. (In fact the only service using this method is presence.)

The UsageSessionService getSessions method should therefore only return active usage sessions.


 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Stephen Marquard added a comment - 02-May-2009 02:00
r61752

QA: Check for no regressions - presence still works as expected. The functional change fixes edge cases which can't easily be reproduced except by directly altering the db for a running instance, so code review would be sufficient.

Jean-François Lévêque added a comment - 09-Sep-2009 01:49
Seems K1.0.12 has not been tagged yet. Will it be the latest 1.0.x before we tag 2.6.1?

Jean-François Lévêque added a comment - 09-Sep-2009 01:52
Has anyone outside UCT used it with success?

Anthony Whyte added a comment - 08-Oct-2009 08:17
Merged to 1.0.x.