click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: KNL-206
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: David Horwitz
Reporter: Matthew Jones
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Kernel - K1

ToolListener should only register files with .xml extension

Created: 08-Jun-2009 08:32   Updated: 05-Mar-2010 02:46
Component/s: API
Affects Version/s: 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.0.7, 1.0.8, 1.0.9, 1.0.10
Fix Version/s: 1.0.12, 1.1.0

Time Tracking:
Not Specified

File Attachments: 1. Text File ToolListener.patch (0.9 kB)


1.0.x Status: Closed


 Description  « Hide
When ToolListener goes into the webapp to look for tools to load, it will read from any filename. It should, for consistency, read only from files that end with .xml. The 'register' function of the ActiveToolManager that accepts a File as a parameter does this check but the ToolListener passes this resource as an unverified stream. This recently came up as an issue for us because 'patch' created a some files with an .orig extension which was loaded by sakai instead of the correct .xml registration file.

The patch changes ToolListener to pass the tool path as a File rather than as a stream so it's checked.

Also affects 2.5 versions of sakai.

 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Stephen Marquard added a comment - 02-Jul-2009 11:58
Committed in 64564.

Anthony Whyte added a comment - 08-Oct-2009 08:16
Merged to 1.0.x.