click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: KNL-210
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Beth Kirschner
Reporter: Beth Kirschner
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Kernel - K1

Create variant of getResourcesOfType that restricts query to specific site/contexts

Created: 09-Jun-2009 10:15   Updated: 05-Mar-2010 02:48
Component/s: API, Impl
Affects Version/s: 1.0.14, 1.1.0
Fix Version/s: 1.0.12, 1.1.0

Time Tracking:
Not Specified

File Attachments: 1. Text File KNL-210_1.0.x.patch (12 kB)

Issue Links:
Depend
 

1.0.x Status: Resolved


 Description  « Hide
ContentHostingService should implement a new method as follows, to address issues described in SAK-14165:

        /**
        * Retrieve a collection of ContentResource objects of a particular resource-type in a set of contexts
        *
        * @param resourceType select resources where CONTENT_RESOURCE.RESOURCE_TYPE_ID equals resourceType
        * @param context select resources where CONTENT_RESOURCE.CONTEXT in [context,...]
        * @return collection of ContentResource
        */
       public Collection<ContentResource> getContextResourcesOfType(String resourceType, Set<String> contextIds);



 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Beth Kirschner added a comment - 09-Jun-2009 10:21
Additionally, add ThreadLocalManager caching in getResourcesOfType (originally defined in Noah Botimer's SAK-14165-content-revised.patch attached to SAK-14165). This will aid in multiple calls for the same resource type.

Beth Kirschner added a comment - 09-Jun-2009 11:21
Implemented as described

Beth Kirschner added a comment - 10-Jun-2009 08:34
Changes were committed in r63478
(I've updated the typo in the svn comments, but it takes a jira restart for the changes to be reflected here...)

Noah Botimer added a comment - 27-Jul-2009 12:07
Attaching a patch for kernel 1.0.x.

Noah Botimer added a comment - 05-Oct-2009 10:51
Michigan has been running this in production 2.6.x for a month with no problems. Performance is significantly improved.

Jean-François Lévêque added a comment - 08-Oct-2009 01:31
It seems adding a new method won't break anything in 2.6. I'm not sure if the changes in DbContentService.java are safe for K 1.0.x

See comment from Matthew Jones:

I also marked SAK-14165 as a "Won't fix" on the merge issue as it
requires KNL-210, which is currently slated for kernel 1.1.0. We are
running a patched kernel at Michigan with this fix and I according to
Noah users have been happy with it. This may want to be added prior to
1.1.0, but I believe because of the kernel api change that was
unlikely, and not going to be in 2.6.1.

-Matthew

Matthew Jones added a comment - 09-Oct-2009 12:32
If/when this merges into a 1.0.x kernel then SAK-14165 should be merged in. Noah said it should be able to merge cleanly, and it is running fine for us as previously mentioned.

Beth Kirschner added a comment - 12-Oct-2009 10:22
Merged to kernel 1.0.x branch