[#KNL-27] Localizing tool titles requires a kernel rebuild

Kernel - K1

Localizing tool titles requires a kernel rebuild

Created: 04-Sep-2008 14:00 Updated: 05-Mar-2010 02:48

Component/s:

Impl

Affects Version/s:

1.0, 1.0.14

Fix Version/s:

1.0.1, 1.0.2, 1.0.3, 1.0.14, 1.1.0

Time Tracking:

Not Specified

Issue Links:

Depend

This issue is depended on by:

~~SAK-8908~~ Tool titles and Page titles should be displayed in user's prefered language/locale

Relate

This issue relates to:

~~SAK-15135~~ Move localizedToolPropertiesBean & tool properties out of portal and into config

This issue is related to:

~~SAK-14393~~ Create localizedToolPropertiesBean and move localized tool properties out of kernel and into portal

1.0.x Status:

Resolved

Description

« Hide

This problem was introduced with the kernel refactoring -- the centralized tools_*.properties files now live in the kernel, and the current logic gives these files precedence over others. This means that a kernel rebuild is *required* in order to localize any tool titles -- definitely not a good thing.

Notes: localized tool titles/descriptions are loaded in ActiveToolComponent.getLocalizedToolProperty() and invoked from org.sakaiproject.util.Tool.getTitle() and getDescription()

All

Comments

Work Log

Change History

Subversion Commits

git Commits

Sort Order:

[ Permlink | « Hide ]

Beth Kirschner added a comment - 05-Sep-2008 07:05

Localized tool properties have been removed from the kernel and are now loaded using the ClassLoader context of a bean defined as localizedToolPropertiesBean. If the bean is not defined, it is a non-fatal error (default tool properties will be used instead).

[ Permlink | « Hide ]

Anthony Whyte added a comment - 11-Dec-2008 07:08 - edited

I've verified ~~KNL-27~~/~~SAK-14393~~. Steps:

1) kernel trunk -> mvn clean install
2) sakai trunk -> mvn clean install -Dmaven.test.skip=true sakai:deploy
3) JAVA_OPTS='-server -Xms512m -Xmx1024m -XX:PermSize=128m -XX:MaxPermSize=196m -XX:NewSize=192m -XX:MaxNewSize=384m -verbose:gc -XX:+PrintGCDetails -XX:+PrintGCTimeStamps -Djava.awt.headless=true -Duser.language=es -Duser.region=ES' ; export JAVA_OPTS
4) set break points on kernel ActiveToolComponent.getToolProps(), .getLocalizedToolProperty(...), as well as Tool.getTitle(). Watched Spanish titles get set.

[ Permlink | « Hide ]

Anthony Whyte added a comment - 12-Dec-2008 05:32 - edited

Per agreement with Beth I've moved the Tool Properties as well as defined a bean that uses the ClassLoader context in order to load the tool properties files to the config project for consumption by the Kernel. Beth will verify these changes for me.

[ Permlink | « Hide ]

Beth Kirschner added a comment - 12-Dec-2008 08:47

Please apply all changes through r55238 as well as ~~SAK-15135~~ together. QA instructions are litsed in ~~SAK-15135~~.

[ Permlink | « Hide ]

Anthony Whyte added a comment - 12-Dec-2008 14:18

~~SAK-15135~~ has been resolved and closed.

[ Permlink | « Hide ]

Anthony Whyte added a comment - 16-Dec-2008 07:11 - edited

commit -m "~~KNL-27~~ merge -r 51884:55238 trunk to 1.0.x" for ActiveToolComponent.java