[#KNL-341] Localize FormattedText html tags, attributes and values that are considered good & evil

Kernel - K1

Localize FormattedText html tags, attributes and values that are considered good & evil

Created: 04-Dec-2009 10:19 Updated: 05-Mar-2010 02:46

Component/s:

Utils

Affects Version/s:

None

Fix Version/s:

None

Time Tracking:

Not Specified

Issue Links:

Depend

This issue is depended on by:

~~SAK-12217~~ Error in the FCKeditor when Post or Save with Flash.

~~SAK-15523~~ Add Movie plugin to FCKEditor

Relate

This issue is related to:

KNL-397 FormattedText.processFormattedText should allow the programmer to control the processing of anchor tags

Description

« Hide

The FormattedText class includes static definitions of html tags, attributes and values that are used to validate HTML (e.g. checking for javascript). This task will move the definitions into a properties file outside of the kernel, allowing for changes without requiring a kernel rebuild. Institutions can choose to enable or disable tags, attributes and values that make sense locally.

This change is also required to resolve ~~SAK-12217~~ and ~~SAK-15523~~

New properties file will reside in: sakai/config/localization/bundles/src/bundle/org/sakaiproject/localization/bundle/content_type/formattedtext.properties

All

Comments

Work Log

Change History

Subversion Commits

git Commits

Sort Order:

[ Permlink | « Hide ]

Beth Kirschner added a comment - 04-Dec-2009 10:20

Implemented as suggested. Default values in the FormattedText class remain in case the properties files does not exist.

[ Permlink | « Hide ]

Beth Kirschner added a comment - 04-Dec-2009 13:30

Note: checked into kernel code with r69502

[ Permlink | « Hide ]

Beth Kirschner added a comment - 11-Jan-2010 13:02

FormattedText class does not run static initialization for all instances, which means that not all class instances use the values from formattedtext.properties

[ Permlink | « Hide ]

Beth Kirschner added a comment - 11-Jan-2010 13:08

Fixed in r71369

[ Permlink | « Hide ]

Anthony Whyte added a comment - 15-Jan-2010 13:13

formattedtext.properties is in /config 2.7.x

[ Permlink | « Hide ]

Beth Kirschner added a comment - 15-Jan-2010 13:25

Merged to 1.0.x

[ Permlink | « Hide ]

Anthony Whyte added a comment - 16-Jan-2010 04:46

beta-08 failed due to KNL-339 folder/artifact naming mismatches. Bumping to beta09.

[ Permlink | « Hide ]

Anthony Whyte added a comment - 18-Jan-2010 10:06

This fix is not intended for kernel 1.0.x (Sakai 2.6).

[ Permlink | « Hide ]

Anthony Whyte added a comment - 18-Jan-2010 10:07

reverse merge 1.0.x branch:

svn merge -r 71507:71506 https://source.sakaiproject.org/svn/kernel/branches/kernel-1.0.x/
--- Reverse-merging r71507 into '.':
U kernel-util/src/main/java/org/sakaiproject/util/FormattedText.java

1.0.x, r71554.

[ Permlink | « Hide ]

Beth Kirschner added a comment - 25-Jan-2010 07:56

The following three revisions are required to patch the kernel for this change:

r69502
r69503
r71369