[#KNL-414] Aliases with special charcters are allowed to be created, but the links do not work

Kernel - K1

Aliases with special charcters are allowed to be created, but the links do not work

Created: 11-Feb-2010 04:48 Updated: 22-Apr-2010 03:57

Component/s:

Utils

Affects Version/s:

1.0, 1.0.1, 1.0.2, 1.0.3, 1.0.4, 1.0.5, 1.0.6, 1.0.7, 1.0.8, 1.0.9, 1.0.10, 1.0.11, 1.0.12, 1.0.13, 1.1.0

Fix Version/s:

1.1.1, 1.2.0 [tentative]

Time Tracking:

Not Specified

File Attachments:

None

Image Attachments:

1. Screenshot-1.png
(11 kB)

2. Screenshot.png
(28 kB)

Environment:

qa1-nl

Issue Links:

Duplicate

This issue is duplicated by:

~~SAK-17989~~ Realms with special charcters are allowed to be created, but the links do not work

~~SAK-17988~~ Creating site with special characters creates site, bu thet Site id is invalid.

Incorporate

This issue is incorporated by:

SAK-17980 Incosistent handling of special chars and UTF8

Relate

This issue is related to:

~~SAK-18162~~ Links to files with spaces aren't encoded/decoded correctly

~~SAK-18221~~ Reading list can't be displayed

1.1.x Status:	Resolved
1.0.x Status:	Merge

Description

« Hide

If you create an alias with a special character then the alias is created without issue, but the URL does not work. See screen grab.

All

Comments

Work Log

Change History

Subversion Commits

git Commits

Sort Order:

Alan Berg made changes - 11-Feb-2010 04:51

Field	Original Value	New Value
Link		This issue is incorporated by SAK-17980 [ SAK-17980 ]

[ Permlink | « Hide ]

Alan Berg added a comment - 11-Feb-2010 04:59

; also breaks alias, need to test for other characters
You cannot delete these aliases either.

Alan Berg made changes - 11-Feb-2010 04:59

Attachment

Screenshot-1.png [ 19627 ]

[ Permlink | « Hide ]

Alan Berg added a comment - 11-Feb-2010 05:07

Probably healthy, but worth commenting, Also triggered lucene for different HelpManagerImpl. The logging is:

2010-02-11 13:56:31,662 WARN TP-Processor6 org.sakaiproject.cheftool.VelocityPortletPaneledAction - AliasesAction.doEdit: alias not found: ^^x3B^
2010-02-11 13:57:47,640 INFO Timer-1 org.sakaiproject.search.journal.impl.MergeUpdateOperation - Local Merge Operation

2010-02-11 13:58:21,644 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'eu' in 2990 total milliseconds
2010-02-11 13:58:25,380 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ko_KR' in 3736 total milliseconds
2010-02-11 13:58:27,236 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'pt_BR' in 1856 total milliseconds
2010-02-11 13:58:28,970 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_US' in 1734 total milliseconds
2010-02-11 13:58:30,555 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ja_JP' in 1584 total milliseconds
2010-02-11 13:58:32,080 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ar' in 1525 total milliseconds
2010-02-11 13:58:33,973 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ru_RU' in 1893 total milliseconds
2010-02-11 13:58:35,466 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'fr_FR' in 1493 total milliseconds
2010-02-11 13:58:36,976 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'zh_CN' in 1510 total milliseconds
2010-02-11 13:58:38,468 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'pt_PT' in 1492 total milliseconds
2010-02-11 13:58:39,882 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_GB' in 1414 total milliseconds
2010-02-11 13:58:41,413 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_NZ' in 1531 total milliseconds
2010-02-11 13:58:42,952 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'default' in 1538 total milliseconds
2010-02-11 13:58:44,362 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ca_ES' in 1410 total milliseconds
2010-02-11 13:58:45,663 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'zh_TW' in 1301 total milliseconds
2010-02-11 13:58:47,108 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'sv_SE' in 1445 total milliseconds
2010-02-11 13:58:48,594 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'fr_CA' in 1486 total milliseconds
2010-02-11 13:58:50,071 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'es_ES' in 1476 total milliseconds
2010-02-11 13:58:51,504 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_AU' in 1433 total milliseconds
2010-02-11 13:58:52,947 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_ZA' in 1442 total milliseconds
2010-02-11 13:58:54,324 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'nl_NL' in 1377 total milliseconds
2010-02-11 13:59:27,646 INFO Timer-1 org.sakaiproject.search.journal.impl.MergeUpdateOperation - Local Merge Operation

[ Show » ]

Alan Berg added a comment - 11-Feb-2010 05:07 Probably healthy, but worth commenting, Also triggered lucene for different HelpManagerImpl. The logging is: 2010-02-11 13:56:31,662 WARN TP-Processor6 org.sakaiproject.cheftool.VelocityPortletPaneledAction - AliasesAction.doEdit: alias not found: ^^x3B^ 2010-02-11 13:57:47,640 INFO Timer-1 org.sakaiproject.search.journal.impl.MergeUpdateOperation - Local Merge Operation 2010-02-11 13:58:21,644 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'eu' in 2990 total milliseconds 2010-02-11 13:58:25,380 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ko_KR' in 3736 total milliseconds 2010-02-11 13:58:27,236 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'pt_BR' in 1856 total milliseconds 2010-02-11 13:58:28,970 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_US' in 1734 total milliseconds 2010-02-11 13:58:30,555 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ja_JP' in 1584 total milliseconds 2010-02-11 13:58:32,080 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ar' in 1525 total milliseconds 2010-02-11 13:58:33,973 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ru_RU' in 1893 total milliseconds 2010-02-11 13:58:35,466 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'fr_FR' in 1493 total milliseconds 2010-02-11 13:58:36,976 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'zh_CN' in 1510 total milliseconds 2010-02-11 13:58:38,468 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'pt_PT' in 1492 total milliseconds 2010-02-11 13:58:39,882 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_GB' in 1414 total milliseconds 2010-02-11 13:58:41,413 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_NZ' in 1531 total milliseconds 2010-02-11 13:58:42,952 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'default' in 1538 total milliseconds 2010-02-11 13:58:44,362 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'ca_ES' in 1410 total milliseconds 2010-02-11 13:58:45,663 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'zh_TW' in 1301 total milliseconds 2010-02-11 13:58:47,108 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'sv_SE' in 1445 total milliseconds 2010-02-11 13:58:48,594 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'fr_CA' in 1486 total milliseconds 2010-02-11 13:58:50,071 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'es_ES' in 1476 total milliseconds 2010-02-11 13:58:51,504 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_AU' in 1433 total milliseconds 2010-02-11 13:58:52,947 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'en_ZA' in 1442 total milliseconds 2010-02-11 13:58:54,324 INFO TP-Processor13 org.sakaiproject.component.app.help.HelpManagerImpl - finished initializing lucene for 'nl_NL' in 1377 total milliseconds 2010-02-11 13:59:27,646 INFO Timer-1 org.sakaiproject.search.journal.impl.MergeUpdateOperation - Local Merge Operation

David Horwitz made changes - 12-Feb-2010 01:03

Summary

Alaies with special charcters are allowed to be created, but the links do not work

Aliases with special charcters are allowed to be created, but the links do not work

[ Permlink | « Hide ]

David Horwitz added a comment - 12-Feb-2010 01:08

The ; character is not properly escaped by the Validator.escapeUrl() - the surest fix to this would be to fix the validation method

[ Permlink | « Hide ]

David Horwitz added a comment - 12-Feb-2010 01:17

note that the alias themselves work but that the edit link fails

David Horwitz made changes - 12-Feb-2010 01:45

Project	Sakai [ 10010 ]	Kernel - K1 [ 10410 ]
Key	SAK-17987	KNL-414
Affects Version/s		1.1.0-beta12 [ 11781 ]
Affects Version/s		1.1.0-beta11 [ 11780 ]
Affects Version/s		1.1.0-beta10 [ 11738 ]
Affects Version/s		1.1.0-beta09 [ 11737 ]
Affects Version/s		1.1.0-beta07 [ 11703 ]
Affects Version/s		1.1.0-beta06 [ 11687 ]
Affects Version/s		1.1.0-beta05 [ 11682 ]
Affects Version/s		1.1.0-beta04 [ 11649 ]
Affects Version/s		1.1.0-beta03 [ 11646 ]
Affects Version/s		1.1.0-beta01 [ 11345 ]
Affects Version/s		1.0.13 [ 11630 ]
Affects Version/s		1.0.12 [ 11551 ]
Affects Version/s		1.0.11 [ 11530 ]
Affects Version/s		1.0.10 [ 11511 ]
Affects Version/s		1.0.9 [ 11505 ]
Affects Version/s		1.0.8 [ 11493 ]
Affects Version/s		1.0.7 [ 11482 ]
Affects Version/s		1.0.6 [ 11476 ]
Affects Version/s		1.0.5 [ 11460 ]
Affects Version/s		1.0.4 [ 11428 ]
Affects Version/s		1.0.3 [ 11390 ]
Affects Version/s		1.0.2 [ 11358 ]
Affects Version/s		1.0.1 [ 11340 ]
Affects Version/s		1.0 [ 11180 ]
Affects Version/s	2.7.0-b02 [ 11775 ]
2.7.x Status	None
1.1.x Status		Merge
Fix Version/s	2.7.0-b03 [ 11784 ]
Component/s		Utils [ 10904 ]
Component/s	Aliases (Admin Site Management) [ 10096 ]
2.5.x Status	None
2.4.x Status	None
1.0.x Status		Merge
2.6.x Status	None

Repository	Revision	Date	User	Message
Sakai Source Repository	#73462	Fri Feb 12 01:50:41 PST 2010	david.horwitz@uct.ac.za	KNL-414 fix Validate.escapeURL
				Files Changed
				MODIFY /kernel/trunk/kernel-util/src/main/java/org/sakaiproject/util/Validator.java

David Horwitz made changes - 12-Feb-2010 01:54

Status	Open [ 1 ]	Resolved [ 5 ]
Fix Version/s		1.2.0 [tentative] [ 11776 ]
Resolution		Fixed [ 1 ]

David Horwitz made changes - 12-Feb-2010 01:54

Assignee

David Horwitz [ dhorwitz ]

David Horwitz made changes - 12-Feb-2010 02:05

Link

This issue is duplicated by ~~SAK-17989~~ [ ~~SAK-17989~~ ]

David Horwitz made changes - 12-Feb-2010 02:09

Link

This issue is duplicated by ~~SAK-17988~~ [ ~~SAK-17988~~ ]

Repository	Revision	Date	User	Message
Sakai Source Repository	#73464	Fri Feb 12 04:20:20 PST 2010	david.horwitz@uct.ac.za	KNL-414 we need to split on / and rebuild the url
				Files Changed
				MODIFY /kernel/trunk/kernel-util/src/main/java/org/sakaiproject/util/Validator.java

Repository	Revision	Date	User	Message
Sakai Source Repository	#73490	Sat Feb 13 01:19:59 PST 2010	david.horwitz@uct.ac.za	KNL-414 clean up and removel of printlns
				Files Changed
				MODIFY /kernel/trunk/kernel-util/src/main/java/org/sakaiproject/util/Validator.java

Repository	Revision	Date	User	Message
Sakai Source Repository	#73549	Tue Feb 16 04:33:40 PST 2010	david.horwitz@uct.ac.za	KNL-414 possible for the id to be null
				Files Changed
				MODIFY /kernel/trunk/kernel-util/src/main/java/org/sakaiproject/util/Validator.java

Repository	Revision	Date	User	Message
Sakai Source Repository	#74216	Fri Mar 05 01:56:26 PST 2010	david.horwitz@uct.ac.za	> svn merge -c73462 https://source.sakaiproject.org/svn/kernel/trunk --- Merging r73462 into '.': U kernel-util/src/main/java/org/sakaiproject/util/Validator.java dhorwitz@david-HORWITZ-4:~/branchManagement/KERNEL-1.1.x> svn log -r73462 https://source.sakaiproject.org/svn/kernel/trunk ------------------------------------------------------------------------ r73462 \| david.horwitz@uct.ac.za \| 2010-02-12 11:50:41 +0200 (Fri, 12 Feb 2010) \| 1 line KNL-414 fix Validate.escapeURL ------------------------------------------------------------------------ dhorwitz@david-HORWITZ-4:~/branchManagement/KERNEL-1.1.x> svn merge -r73464 https://source.sakaiproject.org/svn/kernel/trunk svn: Try 'svn help' for more info svn: Second revision required dhorwitz@david-HORWITZ-4:~/branchManagement/KERNEL-1.1.x> svn merge -c73464 https://source.sakaiproject.org/svn/kernel/trunk --- Merging r73464 into '.': G kernel-util/src/main/java/org/sakaiproject/util/Validator.java dhorwitz@david-HORWITZ-4:~/branchManagement/KERNEL-1.1.x> svn merge -c73490 https://source.sakaiproject.org/svn/kernel/trunk --- Merging r73490 into '.': G kernel-util/src/main/java/org/sakaiproject/util/Validator.java dhorwitz@david-HORWITZ-4:~/branchManagement/KERNEL-1.1.x> svn merge -c73549 https://source.sakaiproject.org/svn/kernel/trunk --- Merging r73549 into '.': G kernel-util/src/main/java/org/sakaiproject/util/Validator.java
				Files Changed
				MODIFY /kernel/branches/kernel-1.1.x/kernel-impl/src MODIFY /kernel/branches/kernel-1.1.x MODIFY /kernel/branches/kernel-1.1.x/kernel-util/src/main/java/org/sakaiproject/util/Validator.java

David Horwitz made changes - 05-Mar-2010 01:56

1.1.x Status	Merge	Resolved
Fix Version/s		1.1.1 [ 11788 ]

David Horwitz made changes - 05-Mar-2010 02:45

Affects Version/s		1.1.0 [ 11783 ]
Affects Version/s	1.1.0-beta01 [ 11345 ]

David Horwitz made changes - 05-Mar-2010 02:46

Affects Version/s

1.1.0-beta03 [ 11646 ]

David Horwitz made changes - 05-Mar-2010 02:46

Affects Version/s

1.1.0-beta04 [ 11649 ]

David Horwitz made changes - 05-Mar-2010 02:46

Affects Version/s

1.1.0-beta05 [ 11682 ]

David Horwitz made changes - 05-Mar-2010 02:46

Affects Version/s

1.1.0-beta06 [ 11687 ]

David Horwitz made changes - 05-Mar-2010 02:46

Affects Version/s

1.1.0-beta07 [ 11703 ]

David Horwitz made changes - 05-Mar-2010 02:47

Affects Version/s

1.1.0-beta09 [ 11737 ]

David Horwitz made changes - 05-Mar-2010 02:47

Affects Version/s

1.1.0-beta10 [ 11738 ]

David Horwitz made changes - 05-Mar-2010 02:47

Affects Version/s

1.1.0-beta11 [ 11780 ]

David Horwitz made changes - 05-Mar-2010 02:47

Affects Version/s

1.1.0-beta12 [ 11781 ]

Matthew Buckett made changes - 11-Mar-2010 07:51

Link

This issue is related to ~~SAK-18162~~ [ ~~SAK-18162~~ ]

Repository	Revision	Date	User	Message
Sakai Source Repository	#74570	Fri Mar 12 02:00:46 PST 2010	david.horwitz@uct.ac.za	KNL-414 reverse out change as it seems to cause ~~SAK-18162~~
				Files Changed
				DEL /kernel/trunk/test-harness/.project MODIFY /kernel/trunk/kernel-util/src/main/java/org/sakaiproject/util/Validator.java DEL /kernel/trunk/test-harness/.classpath

[ Permlink | « Hide ]

David Horwitz added a comment - 12-Mar-2010 02:01

This needs to be reconsidered as it seems to cause: ~~SAK-18162~~

David Horwitz made changes - 12-Mar-2010 02:01

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Repository	Revision	Date	User	Message
Sakai Source Repository	#74573	Fri Mar 12 03:18:35 PST 2010	david.horwitz@uct.ac.za	KNL-414 revert problematic change
				Files Changed
				MODIFY /kernel/branches/kernel-1.1.x/kernel-impl/src MODIFY /kernel/branches/kernel-1.1.x MODIFY /kernel/branches/kernel-1.1.x/kernel-util/src/main/java/org/sakaiproject/util/Validator.java

Steve Swinsburg made changes - 29-Mar-2010 05:08

Link

This issue is incorporated by SAK-18277 [ SAK-18277 ]

Steve Swinsburg made changes - 29-Mar-2010 05:09

Link

This issue is incorporated by SAK-18277 [ SAK-18277 ]

Matthew Buckett made changes - 30-Mar-2010 06:11

Link

This issue is related to ~~SAK-18221~~ [ ~~SAK-18221~~ ]

David Horwitz made changes - 22-Apr-2010 03:57

Assignee

David Horwitz [ dhorwitz ]

KERNEL TEAM [ k1team ]