click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: KNL-62
Type: Task Task
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Stephen Marquard
Reporter: Carl Hall
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Kernel - K1

Create Delayable Events

Created: 29-Sep-2008 07:51   Updated: 05-Mar-2010 02:48
Component/s: API, Impl
Affects Version/s: 1.0
Fix Version/s: 1.0, 1.0.14

Time Tracking:
Not Specified

File Attachments: 1. File knl-62-npe.diff (1.0 kB)
2. File sak-7670.diff (23 kB)
3. File sak-7670_avail_noti.diff (3 kB)

Issue Links:
Depend
 
Relate
 

1.0.x Status: Resolved


 Description  « Hide
A patch to allow for events to be delayed until a specified time. Satisfies the need in SAK-7670 and SAK-12977

 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Ian Boston added a comment - 29-Sep-2008 15:02
Very sorry, but this requires an API change and we are 4 weeks after code freeze on the API, so I cant apply this at this time.

Once 2.6 is out then we can look at this again.

Stephen Marquard added a comment - 01-Oct-2008 10:11
The problem with SAK-7670 is that as the current code is in trunk, it changes the behaviour in undesireable ways. So things either need to go forwards or backwards, but they can't stay as they are. This issue was bumped from 2.5 release at the last minute as well, so personally my vote would be to go forwards and get this in for 2.5.


Peter A. Knoop added a comment - 01-Oct-2008 11:26
this change was given an exception, so it should go ahead in time for 2.6. The merge of KNL-62 needs to be coordinated with the merge for SAK-7670, however, otherwise it sounds like trunk might get broken.

Ian Boston added a comment - 02-Oct-2008 02:11
Patch applied,
kernel maven repo updated
Thanks

Carl Hall added a comment - 02-Oct-2008 12:45
NPE was found in nightly build. Patch attached to fix it.

Ian Boston added a comment - 02-Oct-2008 13:56
New patch applied.
thanks

Probably wont get a snapshot out till tomorrow, takes to long on the link I am on.

Jean-François Lévêque added a comment - 03-Oct-2008 01:12
Could someone move this task and set the appropriate Fix version. I can't do that because it's a contributed patch.

Ian Boston added a comment - 03-Oct-2008 01:28
All done,

Jean-François Lévêque added a comment - 03-Oct-2008 01:42
Thanks Ian!

Stephen Marquard added a comment - 26-Nov-2008 05:00
Don't have JIRA permissions to reopen this, but it needs fixes. See comments in SAK-7670.

Ian Boston added a comment - 26-Nov-2008 14:41
please check and close, I should not have closed (request from Stephen Marquard)

Stephen Marquard added a comment - 26-Nov-2008 23:48
Reopening for some changes as per SAK-7670.

Stephen Marquard added a comment - 01-Dec-2008 00:05
Changing to blocker to ensure this is addressed for 1.0.1 K1 for 2-6-x.

Carl Hall added a comment - 09-Dec-2008 14:22
Patch that does the following:

1) Use 'available' & 'write' for resource (not dropbox) functions. Removed 'add' since an 'add' event shouldn't trigger an email.
2) Updated postAvailableEvent to delay an event if the resource isn't available. If the resource is available, check its properties to see if an 'available' event has been sent before, and if not send one then mark as 'availableNotified'.
3) Adjust priority of event to 'NOTI_NONE' in commitResourceEdit if resource is not yet available. This keeps 'write' events from sending an email each time an unavailable resource is updated.

Carl Hall added a comment - 10-Dec-2008 08:07
Patch included for resolution. Assigning to Stephen for review though Ian may need to see this, too.

Stephen Marquard added a comment - 15-Dec-2008 07:39
Almost done except getting duplicate notifications when revising a resource after it's available.


Stephen Marquard added a comment - 16-Dec-2008 12:05
Resolved in trunk and 1.0.x. See KNL-91 for any followup issues.