click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: KNL-91
Type: Task Task
Status: Closed Closed
Resolution: Incorporated
Priority: Major Major
Assignee: Stephen Marquard
Reporter: Stephen Marquard
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Kernel - K1

Review delayed event notifications behaviour

Created: 16-Dec-2008 11:38   Updated: 05-Mar-2010 02:48
Component/s: Impl
Affects Version/s: 1.0.14
Fix Version/s: None

Time Tracking:
Not Specified

Issue Links:
Relate

1.0.x Status: Closed


 Description  « Hide
There are some subtleties in the delayed events behaviour introduced in KNL-62 / SAK-7670, viz.:

1. The UI in Resources is geared around immediate notifications, so there are some subtleties like if you create an item with a future release date and notification, then revise the item with notifications off, then when the content.available event is posted, a notification won't be sent, because the "desired notification" state isn't persisted in the actual content item.

2. When the delayed notification is sent out, it's sent as the system name rather than the user who triggered the notification, because the email notification code is looking at the current session user.


 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Stephen Marquard added a comment - 17-Dec-2008 04:34
I think these javadocs are now misleading:

/**
* Resends a notification using the bits of data pulled from the original {@link Notification}
* and {@link Event} objects passed into {@link notify(Notification, Event)}. Specifying the
* bits of information to be used allows notifications to be partially serialized and delayed to
* run later. This becomes prominent when sending out emails to unavailable resources.
*
* @param notificationId
* ID of the original notification.
* @param resourceFilter
* The resource filter to be used.
* @param eventPriority
* The priority level of the event.
*/
public void reNotify(String notificationId, String resourceFilter, int eventPriority, Event event)

Stephen Marquard added a comment - 19-Dec-2008 04:30 - edited
Just noting for completeness that content.available events are not generated for resources that are in:

My Workspace
Attachments
Private (e.g. Melete)
Folders

as these don't have release dates or notifications (at least in the UI).

Stephen Marquard added a comment - 06-Apr-2009 06:33
KNL-148 fixes the 2nd issue noted above.

Stephen Marquard added a comment - 31-Jul-2009 10:19
Both identified issues are now the subject of other JIRAs.