Issue Details (XML | Word | Printable)

Key: SAK-10547
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Unassigned
Reporter: Stephen Marquard
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Sakai

Clicking on paging widget right-arrow causes widget to wrap

Created: 03-Jul-2007 07:09   Updated: 23-Oct-2008 08:37
Component/s: Gradebook
Affects Version/s: 2.3.x, 2.4.x, post-2.4, trunk [DO NOT USE]
Fix Version/s: 2.4.x, post-2.4, 2.5.0

Time Tracking:
Not Specified

File Attachments: None
Image Attachments:

1. screenshot-1.jpg
(181 kB)

2.6.x Status: None
2.5.x Status: None
2.4.x Status: Resolved


 Description  « Hide
If you click on the pager widget right-arrow in FF2, it causes the widget to wrap across 2 lines, which means you have to click on the (now relocated) right-arrow again. See screenshot.

Gonzalo previously said about this issue (in email):

"Yes - this is fixable - although why it is happening given the window size in the screenshot is a mystery (something to do with the width differences between enabled and disabled buttons in FF?). The floated block reserved for the paging widget can be made un-wrappable. But I wonder who has used this class to float things to the right generally and is expecting things to wrap?"


 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Ray Davis added a comment - 16-Jul-2007 15:46
The symptom is that mouse-down on a button changes styles in such a way that the button moves out from under the pointer before mouse-up can take effect. The result is that the button remains actively chosen but unclicked.

The cause can't be changes between "enabled and disabled" buttons, since it happens dynamically on a single page. Could it have something to do with the "focus" state?

Here's the class hierarchy of the buttons:

DIV.portletBody > FORM#gbForm > table.gbContainerNav tbody tr TD.gbRightNav > DIV.shorttext > DIV.listNav > INPUT

One thing I notice in the default skin's tool.css is:

.shorttext input{
}

.shorttext input:focus{
border: 1px solid #000;
}

Since the default border around a button in FireFox is 2px, the result is that clicking on a button will make it shrink a bit. I think it's a usability no-no to resize or reposition buttons like that, so it might be good to rethink this. However, removing that bit of CSS doesn't get rid of the bug.

Ray Davis added a comment - 17-Jul-2007 16:16
BTW, you can tell it's the loss of the mouse-up event because if you leave the mouse button pressed down steadily, then drag the pointer over the repositioned button, and then release the button, the paging action will take place normally.

Ray Davis added a comment - 18-Jul-2007 13:03
This bug has also slipped into 2.4.x.

Stephen Marquard added a comment - 18-Jul-2007 13:20
Actually it was in 2-3-x as well.

Ray Davis added a comment - 18-Jul-2007 14:24
I would dearly love to understand just what's triggering this, but curing the symptom is straightforward enough: just add "white-space:nowrap;" to the gbLeftNav and gbRightNav definitions in "gradebook.css".

Fix checked into the 2-4-x branch at revision 32715.

I'll re-assign to Lance to merge into the Gradebook trunk.

Ray Davis added a comment - 18-Jul-2007 14:31
I added 2.4.x to the "Fix Version/s" for this JIRA entry. Lance is Branch Manager for 2.3.x, so I'll let him decide whether to merge it in there as well.

Stephen Marquard added a comment - 19-Jul-2007 07:08
We changed this in a local overlay of gradebook.css for the post-2.4 version and the fix resolves the issue for us.

Michelle Wagner added a comment - 09-Aug-2007 05:15
merged fix into trunk r33720

Stephen Marquard added a comment - 22-Aug-2007 11:44
FIxed in trunk r33720, post-2.4.0 r34254

Stephen Marquard added a comment - 22-Aug-2007 13:26
Resolving this as it's fixed in trunk, 2-4-x and post-2.4.

Lance, your call whether you wish to further merge it into 2-3-x.

Michael Lockett added a comment - 30-Aug-2007 07:21
Tested on OSP Nightly r. 34554. When clicking on the right arrow, the page stays the same as it should and new page loads properly.