[#SAK-11386] DHTML 'more sites' list populated with wrong set of sites

Sakai

DHTML 'more sites' list populated with wrong set of sites

Created: 06-Sep-2007 07:40 Updated: 04-Dec-2008 23:55

Component/s:

Portal

Affects Version/s:

trunk [DO NOT USE]

Fix Version/s:

2.5.0

Time Tracking:

Not Specified

File Attachments:

portal-patchfile.txt (0.7 kB)
2.

portal-patchfile2.txt (0.6 kB)

Issue Links:

Relate

This issue relates to:

~~SAK-10448~~ DHTML Tab navigation enhancement

2.6.x Status:	None
2.5.x Status:	None
2.4.x Status:	None

Description

« Hide

The DHTML 'more sites' list is incorrectly populated using the list of sites that is currently displayed in the tabs, instead of the list of sites that is NOT in the tabs.The bug seems to be in SiteHandler.java; I've attached a patch that fixes the bug in our test instance.

All

Comments

Work Log

Change History

Subversion Commits

git Commits

Sort Order:

[ Permlink | « Hide ]

Charles Severance added a comment - 16-Sep-2007 06:39

This was a clear and obvious fix. I made the patch and verified that (a) it was broken and (b) this patch fixed it.

charles-severances-computer:~/dev/sakai/portal csev$ svn commit
Sending portal-impl/impl/src/java/org/sakaiproject/portal/charon/handlers/SiteHandler.java
Transmitting file data .
Committed revision 35148.

[ Permlink | « Hide ]

Shaw-Han Liem added a comment - 20-Sep-2007 11:48

After discussing this issue with the dev teams at UofT and Berkeley, we are going to modify this function to populate the dropdown with All Sites (sites not listed in tabs PLUS the sites displayed in tabs - categorized by site type and term).

This was the functionality intended by the Indiana/Georgia Tech design of DHTML 'more sites' and we would like to maintain that in our revision.

[ Permlink | « Hide ]

Anastasia Cheetham added a comment - 20-Sep-2007 12:20

I've attached a(nother) patch file (portal-patchfile2.txt) that implements the full list of all sites in the drop-down, and not just the hidden sites. This patch works in our test instance.

[ Permlink | « Hide ]

Colin Clark added a comment - 02-Oct-2007 17:00

This was a simple patch that worked as advertised. I tested the behaviour and the -more- drop-down drawer does indeed now include both the list of sites visible in the user's tabs as well as all the other more sites.

[ Permlink | « Hide ]

John Hall added a comment - 12-Mar-2008 06:57

I verified that all non-hidden sites show and hidden sites do not on our local test server, which has this enabled:
2.5.0 RC2a, Linux/MySQL