click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: SAK-13149
Type: Bug Bug
Status: Closed Closed
Resolution: Duplicate
Priority: Major Major
Assignee: Savitha Prakash
Reporter: Gonzalo Silverio
Votes: 0
Watchers: 6
Operations

If you were logged in you would be able to see more operations.
Sakai

trimmed site description creates rendering problems in site browser list

Created: 04-Mar-2008 10:06   Updated: 27-Oct-2009 13:40
Component/s: Sites (Gateway)
Affects Version/s: 2.5.0, 2.5.2, 2.5.3, 2.6.0
Fix Version/s: 2.7.0

Time Tracking:
Not Specified

File Attachments: 1. Text File patch_site-manage_2-5-3.txt (4 kB)
2. Text File patch_site_2-5-3.txt (2 kB)

Image Attachments:

1. screenshot-1.jpg
(207 kB)
Issue Links:
Depend
 
Incorporate
 

2.6.x Status: None
2.5.x Status: None
2.4.x Status: None


 Description  « Hide
In 2.5 the site description input changed from a textarea to a RTEditor.

The RTEditor produces markup. The site browser listing (other places as well perhaps) is still trimming this description as a string. This means that the description might be trimmed to an unbalanced markup fragment that will will badly affect the rendering of wherever the trimming is happening.

To reproduce, put the following into a site "Customize Site Info Display" into the RTEditor in markup mode (this just happened to work for me).

<h3>Some stuff</h3>
<br />
<table cellspacing="1" cellpadding="1" border="0" align="left" style="width: 301px; height: 62px;">
    <tbody>
        <tr>
            <td>Some tabular data</td>
            <td>Some more tabular data from the same source</td>
        </tr>
    </tbody>
</table>

then log out, go to Gateway > Sites, and search for "Any" sites leaving the Search for: field blank. Any sites listed after the one with the bad description will display incorrectly - in this case all columns shifted to the right.

 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Stephen Marquard added a comment - 04-Mar-2008 11:25
Site Info shows the whole description as-is, which pushes everything else down the page (if you have a long formatted description e.g. with an included image).

I think the best option for places other than Home which show site info would be to convert it to plain text first (there's a util function somewhere that does that), then trim it.

Gonzalo Silverio added a comment - 07-Mar-2008 12:02
In Membership it just shows the marked up text...

Peter A. Knoop added a comment - 02-Mar-2009 09:34
[Bulk Comment] This is issue is currently scheduled to be resolved for inclusion in the Sakai 2.6.0 release, however, it is still unresolved. If you still planning on resolving it, please reply with a comment indicating when you expect to have it resolved. If you don't think you will be able to address this issue in time for the release, please reply with a comment indicating such; particularly if this issue is Blocker or Critical priority. If the resolution of this issue is to be delayed until a future release (i.e., 2.7), then please update the Fix Version accordingly.

Gonzalo Silverio added a comment - 02-Mar-2009 09:38
SAK-15767 has a general proposal of how to deal with RT site and group info issues.

Daniel Merino added a comment - 11-Jun-2009 05:37 - edited
I have modified the patch of Savitha Prakash at http://bugs.sakaiproject.org/jira/browse/SAK-15823 to make it work in Sakai 2.5.3 to solve this issue.

This is my first patch, so I'm not sure if could be done better than is, but it solves the problem.

Just apply patch_site_2-5-3.txt in <SRC>/site and patch_site-manage_2-5-3.txt in <SRC>/site-manage. Deploy and restart.

Savitha Prakash added a comment - 02-Oct-2009 10:34
This issue is a duplicate for sak-15823, which is already committed to trunk- 2.7.snapshot.