|
[
Permlink
| « Hide
]
Peter A. Knoop added a comment - 13-Jun-2008 15:31
Gonzalo, is this one you could review? Thanks.
Wow - I had no idea this (access servlet) existed, is pretty nice - so lightweight.
Is there any documentation on what the servlet can serve up? Is the present markup it, or are there other versions in other dialects (rss, other xml, etc.)? Any objections if I try changing the markup a bit to make it a bit more semantic and stylable? It would be great if you could change the mark-up. Hattie from Cambs told me that either Rutgers or New York have done some styling of the access servlet - I dont know whether this work could be embraced?
Some notes / ideas: If you give a resource folder a description, then on the access page for this folder, you get this description in a <p>..</p> just underneath the title of the folder. It'd be good to have a class attribute in this block. Also for the 'directory index' table, I'd suggest removing the table and using div's 'n' spans instead and put the individual resource title and resource description in spans. If you're inside the code making changes and want some ideas (!!), what we'd also like to achieve is to have 'folder' or 'application' icons next to the links, in a similar way to the regular resources tool. If you could put a <span class="ms-word-doc"> (or "folder" or "PPT" or "PDF" etc) inside the <a href> then we can add background images to each link. [I note that the Resources display does not use this method, it uses 2 <a href>s one which contains an image (word / ppt / pdf etc) and a second which contains the display title of the resource.] The "[Folder]" text should also be in a span so it can be hidden if desired.
The access servlet (/access/content/ or the shortcut /web/) basically just provides directory views (if given a folder name not a filename), and I think supports maybe POST operations for some editor integration requirements, but nothing else.
I think the markup is hardcoded in java code, but that's no reason not to change it :-) Hi,
Please see (with Firefox, Safari or IE7): http://garden.dmc.dc.umich.edu:8080/access/content/group/70501be5-3136-4ad5-a771-fb9f87f2b56d/ I think all the folders are public, if not, use admin/admin All I did was import the default tool sheet, added a few definitions just for access servlet, turned list into an actual list. I think I made all the markup adressable either directly or via inheritance. If this is ok further work would entail having the access servlet obey the stylesheet of the site, perhaps. The icons for the files are done via parsing the extension of the file in the css and arranging for the proper icon to be displayed. This is in the nature of an elaborate joke - a more rational solution would be to have the access servlet mime type conscious, but maybe that defeats the "lightweight" nature of this type of access. Other possibilities: toggle descriptions? Very nice.
Expandable descriptions would be really nice. Attached 2 patch files and a new image.
Descriptions can be toggled, link to toggle only shows if there are descriptions. "Go one up" link has been moved to top of the page. There are the following things to consider: 1 - the icon lookup is not "real" 2 - all the strings are in English and in the servlet 3 - I do not really know what other things this is used for - I think I only edited the bits that make the dir listing - but this should be looked at by someone more familiar with the ins and outs of the servlet - there are mentions to the sferix editor, for example, as well as some formish things that I do not really understand. Thanks! would it be possible to get this patch into 2.6 or 2.7. It is such a HUGE improvement over the current piece of code.
It's not a showstopper but I don't think this works in IE6 according to
http://www.quirksmode.org/css/selector_attributeAdvanced.html Also rather than using a[href*='.doc'], a[href*='.rtf']{ should we use the end selector a[href$='.doc'], a[href$='.rtf']{ so that test.document.txt matches on .txt and not .doc? New version of patches attached (based on 2.5). The file extension parsing (and class matching) is now scripted so Internet Explorer should be fine now. Adding new file types is also simplified as the css class = the file extension. Also - the extension is lowercased before applied as a class to the link so that it will match the css class (for
It would be nice if Oh. Am unable to build content-impl in trunk or 2.6 for some reason. It seems to be lacking the needed pom files and the content pom file does not reference it, and that is the limit of my knowledge. The patches could be applied to to 2.5, though, after testing...
now that
The new CSS is based on the extension of the documents - the script finds it, assigns the extension as a class to the link, the CSS matches that class with an icon, so it is matter of adding the new extensions to a specific icon in the CSS.
For example - the new CSS has: .doc, .rtf, .docx, .docm, .dotx, .dotm { background: url(../../image/sakai/doc.gif) center left no-repeat !important } So all wordish things will get the same icon. I did similar things for the rest of the Office docs. This can be expanded to the other icons so that all reasonable file extensions are covered. I still need help checking this into trunk - as well as resolving It doesn't look like there is a doc.gif in the sakai icons folder. Attached patch reverts back to the use of word.gif for .doc* files.
John L., is this something Jim could help out with, including
As per
Gonzalo, can you attach a completely new access.css with all the correct styles in it? I ran into trouble applying the 2nd patch above (after applying the first OK). New patch version (access_css-patch-11-25-09.txt (3 kB). Let me know if there are any problems with it, and thanks for updating the servlet!
Any thoughts on
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Closed
Major
the access.css uses its own unique style. It should follow the style that the rest of Sakai uses
