[#SAK-13791] Portfolio performance issues when selecting items for templates that have many forms as item defs

Sakai

Portfolio performance issues when selecting items for templates that have many forms as item defs

Created: 17-Jun-2008 17:43 Updated: 23-Oct-2008 05:09

Component/s:

OSP: Portfolios

Affects Version/s:

2.4.0, 2.4.1, 2.5.0, 2.5.2, 2.5.3

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

Douglass Matrix.zip (67 kB)
2.

Douglass Portfolio Template 2.zip (48 kB)
3.

Home+and+About+Me+Pages.zip (24 kB)
4.

Leadership+Transcript.zip (24 kB)
5.

My+Pathway.zip (13 kB)
6.

Resume+Builder.zip (18 kB)
7.

SAK-13791_fix_performance_issue.patch (3 kB)

Issue Links:

Duplicate

This issue duplicates:

~~SAK-13343~~ Portfolio assembly does not use fast form location method

2.6.x Status:	None
2.5.x Status:	None
2.4.x Status:	None

Description

« Hide

when a template using a number of form defs as items, we've found that the page where you select items can be very slow, to the point where is eventually times out. I've traced this down to a method is CHS that loads and filters the resources. It turns out that while sakai caches site info, tool info is not cached. This was causing a huge number of extra queries against the sakai_site_tool table.

select TOOL_ID, REGISTRATION, TITLE, LAYOUT_HINTS, PAGE_ORDER from SAKAI_SITE_TOOL where PAGE_ID = ? order by PAGE_ORDER ASC

All

Comments

Work Log

Change History

Subversion Commits

git Commits

Sort Order:

[ Permlink | « Hide ]

John Bush added a comment - 17-Jun-2008 17:47

I was able to fix this by calling into getContentHostingService().findResources(null,null, null) only once with a null type, and then storing that result in a threadlocal, and filtering with each subsequent call.

Patch coming soon...

[ Permlink | « Hide ]

John Bush added a comment - 17-Jun-2008 17:49

Needed to make an extra null check BaseContentService.findResources() for this to work, I'll commit this patch later in the week after we finish QA locally.

[ Permlink | « Hide ]

John Bush added a comment - 17-Jun-2008 21:36

can you review and patch this, I made the change to content, but don't have perms for metaobj

[ Permlink | « Hide ]

John Ellis added a comment - 19-Jun-2008 11:12

merged in the patch

[ Permlink | « Hide ]

Charles Hedrick added a comment - 07-Jul-2008 11:09

This doesn't fix it for us. I have two templates, one with a completed wizard and one with the individual form items. The one with the completed wizard works immediately. The other one takes at least a minute, and in my latest test, times out. Obviously this depends upon the user. I have access to lots of locations.

I'm attaching all the files.

[ Permlink | « Hide ]

Charles Hedrick added a comment - 07-Jul-2008 11:10

This doesn't do it for us. I have a sample site where it takes at least a minute, and sometimes times out. Obviously this depends upon the user. I have access to more sites than some.

I'd really like a way to make it look in just my worksite, perhaps as an option in sakai.properties.

I'm attaching all the files

[ Permlink | « Hide ]

Charles Hedrick added a comment - 07-Jul-2008 11:11

This is still a problem for us. It takes at least a minute or may time out.

Assuming I can, I will attach the files. If I can't I'll create a new report.

[ Permlink | « Hide ]

Charles Hedrick added a comment - 07-Jul-2008 11:16

I have access to 57 other sites. While that's a bit large, over time others users will be in the same situation.

[ Permlink | « Hide ]

John Bush added a comment - 08-Jul-2008 10:26

the work noah is doing in ~~SAK-13343~~ addresses this same issue

[ Permlink | « Hide ]

Peter A. Knoop added a comment - 09-Jul-2008 03:20

See ~~SAK-13343~~ for further progress on this issue.