|
We don't really have a summary for the <table>'s summary attribute, so it should probably say something like "Read the description of this table".
This would also help with automated QA testing using Selenium -- which works best if the cells in the matrix had IDs
This has been implemented with the following notes and/or exceptions:
- Each cell now has a unique id (row-X_col-Y) that may be referenced from a stylesheet. Adding class-identifiers for each row would be trivial and can be done if needed. - Matrix footers will be displayed if more than 10 rows are defined. This can be configured in sakai.properties by setting "osp.matrixRowFooter". If this is set to -1, the footer will never be displayed. - Unnecessary tooltip markup is ugly, but the underlying code is even uglier -- unless this is causing a problem, it will remain. Looks good. Should I reopen to add the row and col identifiers?
- Gonzalo The footers were discussed on today's call. Both Chris and Lynn voiced concern over a global setting. Lynn's perspective is that we should more readily accept matrix author complexity when it could help the end user. Hugo made a popular suggestion of allowing dividing headers at locations other than above and below all rows. Sean had previously commented via email that a fixed header and scrolling body may be desirable.
A new ticket should be created if we wish to pursue these variations. This is now being reviewed for inclusion in 2.7. Are there test cases for this work, and who should be the point of contact if issues are unearthed during QA?
Clay, there isn't really a test case for this. You just make a matrix with a couple columns and a couple rows, then view the frame source and look to see that the ids and classes are there as prescribed in the jira. The new markup allows for things like scrolling matrices, hiding columns, etc.
Included in 2.7 release (prior to svn 2.7.x branch on Nov 13 r68877)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Task
Closed
Major
Add semantic markup to matrix html and provide default values in the stylesheet
1. For the tooltip, when the tooltip is empty, neither the <div> nor the script should be rendered. Here is an example cell with both present:
<th class="matrix-row-heading matrixRowDefault" bgcolor="" style="color: " scope="row">
<div id="tooltip" style="position:absolute;visibility:hidden; border:1px solid black; font-size: 10px; layer-background-color: lightyellow; background-color: lightyellow; padding:1px">
</div>
<script type="text/javascript" src="/osp-common-tool/js/eport.js"></script>
Row 1
</th>
2. When a cell is locked, it is still possible to click on it, enter the cell, and see instructions, etc. Gonzalo suggested a way to make the cell un-visitable by means of a stylesheet. The technique would be to wrap the link in a div, make the div the same height and width as the cell, and set the display to none, as shown below (the problem with the internationalization string is being reported in a separate Jira):
<td id="col1-row1" class="matrix-cell-border matrix-LOCKED col1 row1" style="cursor: pointer;">
<div style="height: 100%; width: 100%; display: none;" > <a href="#" class="skip">
???table_cell_link_title???</a> </div></td>