[#SAK-14390] Renaming chat tool makes it unselected in Site Info-Edit Tools

Sakai

Renaming chat tool makes it unselected in Site Info-Edit Tools

Created: 05-Sep-2008 02:11 Updated: 09-Dec-2009 08:50

Component/s:

Chat, PageOrderHelper, Site Info

Affects Version/s:

2.4.0, 2.4.1, 2.5.0, 2.5.2, 2.5.3

Fix Version/s:

2.6.0

Time Tracking:

Not Specified

File Attachments:

None

Image Attachments:

1. chat_room_unselected_24x.jpg
(67 kB)

2. chat_room_unselected_25x.jpg
(104 kB)

Issue Links:

Depend

This issue depends on:

~~SAK-14385~~ code refactoring: remove redundant code dealing with add/edit site tools

~~SAK-7209~~ Allow multiple instances of new tools

Duplicate

This issue is duplicated by:

~~SAK-14391~~ Renaming Home tool makes it unselected in Site Info-Edit Tools

Incorporate

This issue incorporates:

~~SAK-14642~~ Home tool selection in list not forced

Relate

This issue relates to:

~~SAK-14642~~ Home tool selection in list not forced

This issue is related to:

~~SAK-15941~~ In Page Order, the Home page loses most of its functionality when its title is changed

2.6.x Status:	None
2.5.x Status:	None
2.4.x Status:	None

Description

« Hide

Renaming the Chat tool from the default 'Chat Room' to 'Chat', for example, using either the Page Order tool or the Admin Sites->Pages rename method, makes the Chat tool unselected in Site Info.

Only when it is renamed back to the exact default 'Chat Room' does it then get reselected in Site Info.

See screenshot.

Affects both nightly2 2.4.x and 2.5.x.

All

Comments

Work Log

Change History

Subversion Commits

git Commits

Sort Order:

[ Permlink | « Hide ]

John Leasia added a comment - 05-Sep-2008 06:57

Not sure this is a bug. Or maybe the request is to handle any arbirtrarily named page in the Edit Tools list.

[ Permlink | « Hide ]

Zhen Qian added a comment - 10-Sep-2008 09:54

Fixed in r52075.

Renamed tool should still be listed as selected within Site Info tool.

- Zhen

[ Permlink | « Hide ]

Zhen Qian added a comment - 12-Sep-2008 12:02

Aaron reported a problem afterwards:

Aaron Zeckoski - 12-Sep-2008 06:25
This change seems to have made it so that having CourseManagement is now required and NullPointerExceptions are caused when attempting to create a site when CM is not installed. Please fix this so it works like the other instances of CM and checks to see if the service is available before attempting to use it.

Here is the trace:
12:10:38,813 WARN SiteSetupQuestionFileParser.java:204 SiteSetupQuestionFileParser:204 - exists(): cannot find resource /group/setupQuestionsAdmin/config/questions.xmlorg.sakaiproject.exception.IdUnusedException id=/group/setupQuestionsAdmin/config/questions.xml
12:10:54,837 WARN VelocityPortletPaneledAction.java:612 VelocityPortletPaneledAction:612 - Exception calling method doAdd_site_option java.lang.reflect.InvocationTargetException (Caused by java.lang.NullPointerException)
java.lang.reflect.InvocationTargetException
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:585)
      at org.sakaiproject.cheftool.VelocityPortletPaneledAction.actionDispatch(VelocityPortletPaneledAction.java:598)
      at org.sakaiproject.cheftool.VelocityPortletPaneledAction.processAction(VelocityPortletPaneledAction.java:514)
      at org.sakaiproject.cheftool.ToolServlet.doGet(ToolServlet.java:221)
      at org.sakaiproject.cheftool.VelocityPortletPaneledAction.doGet(VelocityPortletPaneledAction.java:1012)
      at org.sakaiproject.cheftool.ToolServlet.doPost(ToolServlet.java:151)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
      at org.sakaiproject.vm.ComponentServlet.service(ComponentServlet.java:56)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
      at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:555)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
      at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:679)
      at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:461)
      at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:364)
      at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:301)
      at org.sakaiproject.tool.impl.ActiveToolComponent$MyActiveTool.forward(ActiveToolComponent.java:461)
      at org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1209)
      at org.sakaiproject.portal.charon.handlers.ToolHandler.doTool(ToolHandler.java:188)
      at org.sakaiproject.portal.charon.handlers.ToolHandler.doGet(ToolHandler.java:93)
      at org.sakaiproject.portal.charon.handlers.ToolHandler.doPost(ToolHandler.java:70)
      at org.sakaiproject.portal.charon.SkinnableCharonPortal.doPost(SkinnableCharonPortal.java:1052)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
      at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:592)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
      at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
      at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
      at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
      at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
      at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
      at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:174)
      at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:874)
      at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
      at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
      at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
      at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:689)
      at java.lang.Thread.run(Thread.java:595)
Caused by: java.lang.NullPointerException
      at org.sakaiproject.site.tool.SiteAction.saveFeatures(SiteAction.java:8093)
      at org.sakaiproject.site.tool.SiteAction.doFinish(SiteAction.java:4648)
      at org.sakaiproject.site.tool.SiteAction.doAdd_site_option(SiteAction.java:10281)
      ... 46 more
12:11:43,882 WARN SiteSetupQuestionFileParser.java:204 SiteSetupQuestionFileParser:204 - exists(): cannot find resource /group/setupQuestionsAdmin/config/questions.xmlorg.sakaiproject.exception.IdUnusedException id=/group/setupQuestionsAdmin/config/questions.xml

Fixed in r52196.

- Zhen

[ Permlink | « Hide ]

sswinsb2@une.edu.au added a comment - 15-Sep-2008 03:36

Page Order seems to have disappeared from Site Info, and Home is no longer checked by default now (when setting up a new site).

[ Permlink | « Hide ]

Peter A. Knoop added a comment - 25-Sep-2008 06:00

Zhen, based on the comment above from Steve, sounds like the fix for this issue might need a little tweaking?

[ Permlink | « Hide ]

Zhen Qian added a comment - 13-Oct-2008 13:25

Please see the related ~~SAK-14642~~ for solution.

- Zhen

[ Permlink | « Hide ]

Zhen Qian added a comment - 13-Oct-2008 13:26

I see the "Page Order" tool now. And please track the "Home" tool selection problem from related ~~SAK-14642~~.

Thanks,

- Zhen

[ Permlink | « Hide ]

Jean-François Lévêque added a comment - 15-Oct-2008 07:05

Work fine on a local 2-6-x.

[ Permlink | « Hide ]

Jean-François Lévêque added a comment - 10-Dec-2008 04:06

2.5.x merging conflicts as soon as first revision changes:
svn merge --dry-run -c52075 https://source.sakaiproject.org/svn/site-manage/trunk site-manage/
C site-manage/site-manage-tool/tool/src/java/org/sakaiproject/site/tool/SiteAction.java
Skipped missing target: 'site-manage/site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-editFeatures.vm'
C site-manage/site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-modifyENW.vm

[ Permlink | « Hide ]

Daniel Merino added a comment - 01-Dec-2009 01:43

Could this patch be backported to 2.5.x, please?

I see that it fails in one file out of three which doesn't exist in 2.5.x. Will the patch work in 2.5.x without changing nothing more?

[ Permlink | « Hide ]

Steve Swinsburg added a comment - 01-Dec-2009 14:40

Hi Zhen,

Looks like the 2.5.x merge fails, any chance you could take a look?

[ Permlink | « Hide ]

Zhen Qian added a comment - 02-Dec-2009 07:13

refactoring in ~~SAK-14385~~ needs to be done first before merging ~~SAK-14390~~ into 2.5 code base

[ Permlink | « Hide ]

Zhen Qian added a comment - 02-Dec-2009 11:25

merged r52075 and r52196 into 2.5.x in r69430

[ Permlink | « Hide ]

Zhen Qian added a comment - 09-Dec-2009 06:53

The above merge of 69430 into 2.5.x has been reverted in r69588.

[ Permlink | « Hide ]

Seth Theriault added a comment - 09-Dec-2009 08:50

At the 2.5.6/2.6.2 Jira Review Meeting held on 2009-12-08, it was decided that the recent commits made in support of merging this issue to 2.5.x should be reverted due to the complexity of the work, the required introduction of a new feature (~~SAK-7209~~) into the 2.5.x maintenance branch, and the resulting instability (2.5.x became unusable).