click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: SAK-14768
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Stephen Marquard
Reporter: Stephen Marquard
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Sakai

Remove obsolete code from chat

Created: 28-Oct-2008 01:16   Updated: 28-Sep-2009 22:46
Component/s: Chat
Affects Version/s: None
Fix Version/s: 2.6.0, 2.7.0

Time Tracking:
Not Specified

Issue Links:
Duplicate
 

2.6.x Status: Closed
2.5.x Status: None
2.4.x Status: None


 Description  « Hide
Chat still includes code like ChatAction.java which belongs to the old velocity tool and should be removed to facilitate easier maintenance of code.


 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Stephen Marquard added a comment - 28-Oct-2008 03:08
These folders can be removed:

chat-tool/tool/src/java/org/sakaiproject/chat
chat-impl/impl/src/java/org/sakaiproject/chat/

with this adjustment to components.xml.

Can probably also remove some APIs.

Index: chat/chat-impl/pack/src/webapp/WEB-INF/components.xml
===================================================================
--- chat/chat-impl/pack/src/webapp/WEB-INF/components.xml (revision 53809)
+++ chat/chat-impl/pack/src/webapp/WEB-INF/components.xml (working copy)
@@ -124,30 +124,4 @@
       <property name="siteService" ref="org.sakaiproject.site.api.SiteService"/>
     </bean>

- <bean id="org.sakaiproject.chat.api.ChatService"
- class="org.sakaiproject.chat.impl.DbChatService"
- init-method="init"
- destroy-method="destroy"
- singleton="true">
- <property name="memoryService"><ref bean="org.sakaiproject.memory.api.MemoryService"/></property>
- <property name="sqlService"><ref bean="org.sakaiproject.db.api.SqlService"/></property>
- <property name="serverConfigurationService"><ref bean="org.sakaiproject.component.api.ServerConfigurationService"/></property>
- <property name="entityManager"><ref bean="org.sakaiproject.entity.api.EntityManager"/></property>
- <property name="authzGroupService"><ref bean="org.sakaiproject.authz.api.AuthzGroupService"/></property>
- <property name="sessionManager"><ref bean="org.sakaiproject.tool.api.SessionManager"/></property>
- <property name="securityService"><ref bean="org.sakaiproject.authz.api.SecurityService"/></property>
- <property name="userDirectoryService"><ref bean="org.sakaiproject.user.api.UserDirectoryService"/></property>
- <property name="timeService"><ref bean="org.sakaiproject.time.api.TimeService"/></property>
- <property name="eventTrackingService"><ref bean="org.sakaiproject.event.api.EventTrackingService"/></property>
- <property name="idManager"><ref bean="org.sakaiproject.id.api.IdManager"/></property>
- <property name="threadLocalManager"><ref bean="org.sakaiproject.thread_local.api.ThreadLocalManager"/></property>
- <property name="siteService"><ref bean="org.sakaiproject.site.api.SiteService"/></property>
-
- <property name="containerTableName"><value>CHAT_CHANNEL</value></property>
- <property name="resourceTableName"><value>CHAT_MESSAGE</value></property>
- <property name="locksInDb"><value>false</value></property>
- <property name="autoDdl"><value>${auto.ddl}</value></property>
- </bean>
-
-
 </beans>

Stephen Marquard added a comment - 29-Oct-2008 00:55
Removed chat1 api, impl and tool in r53863.

Jean-François Lévêque added a comment - 11-Dec-2008 08:31
Not sure this should be done on maintenance branches

Stephen Marquard added a comment - 02-Apr-2009 07:41
No functional behaviour to verify. Chat tool still runs.

Peter Peterson added a comment - 28-Sep-2009 22:46
In 2.6.0, removed 2.6.x fix version, set 2.6.x Status to "Closed"