Issue Details (XML | Word | Printable)

Key: SAK-14815
Type: Contributed Patch Contributed Patch
Status: Open Open
Priority: Major Major
Assignee: Zhen Qian
Reporter: Angela Joyce Henry
Votes: 2
Watchers: 5
Operations

If you were logged in you would be able to see more operations.
Sakai

In Windows Vista only, "Download all" zip file does not generate Submission Attachment and Feedback Attachment folders when unzipped

Created: 02-Nov-2008 11:35   Updated: 25-May-2010 15:40
Component/s: Assignments
Affects Version/s: 2.5.0, 2.6.0, 2.6.1, 2.6.2
Fix Version/s: None

File Attachments: 1. Text File assignment-download-all-vista.patch (2 kB)
2. Text File sak-14815.patch (3 kB)

Image Attachments:

1. unzip downlod all folder.jpg
(35 kB)
Environment: Sakai QA Network qa2-us (svn tags/sakai-2.6.0-alpha01) using Oracle - Built: 10/27/08 17:40 - Sakai sakai-2.6.0-alpha01 - Server surfclam (Win Vista Ultimate SP1, IE 7.x)
Issue Links:
Duplicate
 


 Description  « Hide
In Windows Vista (not in Win XP), the "Download all" zipped folder contains all submitted and feedback attachments in relevant folders, but when the folder is unzipped, both attachment folders are listed as files of unknown type, and are empty.

To replicate:
As student: submit an assignment with both inline text and an attachment
As instructor:
- view the submisson, enter inline and summary comments, add a feedback attachment, grade, save
- click the grade link for the relevant assignment, click download all, save the zip file to a local drive, view the file before extracting
Result - the submission and feedback attachment folders are visible and populated with attachments
Extract all the files
Result - a message comes up "There is already a file with the same name as the folder you specified..." (see attached file
Click Skip button several times.
The extract process completes, and it seems that all the files have been extracted, but examination of the unzipped folder reveals that the submission and feedback folders are listed as empty files of unknown format




 All   Comments   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Nancy Wilkison added a comment - 02-Dec-2008 14:24
just an observation...but for me this happens when I use the default unzip
program on my vista machine.
if I use a third party program (in my case 7-Zip) I DO get the student
submission attachments and IOR feedback attachments in their correct folders.
I've had problems with the default unzip program before.
the re-zip (send to) option seems to work.

Aaron R Widner added a comment - 03-Mar-2009 07:57
This also happens in 2.5.x

Peter Peterson added a comment - 13-Mar-2009 23:07
Zhen, is there any chance this might be fixable prior to the 2.6 roll out?

Sam Ottenhoff added a comment - 31-May-2009 19:07
This seems like it is becoming a critical issue, especially as the majority of users will be using the native Windows zip functionality as opposed to a third-party program. I did some testing, and it looks like creating an empty file in each folder prevents the failure described above. Zhen, do you think that is a reasonable solution?

Sam Ottenhoff added a comment - 02-Jun-2009 14:24
Creating a file called .empty in each of the folders seems to solve two bugs in the Upload All functionality.

  #1) Windows native ZIP does not seem to make folders when the directory is empty. Instead, Windows native ZIP creates awkward, empty files for the submission and feedback directories.

  #2) The screenshot attached to this bug seems to be caused by the redundant creation of the "blank" submissions folder and then the subsequent creation of the files underneath the submissions folder. ZIP automatically creates the folder structure (a blank folder should not be created).

This patch simply adds a .empty file in the submission folder and the feedback folder. My limited testing shows that this removes both issues described above.

Sam Ottenhoff added a comment - 14-Aug-2009 11:03
New patch attached (sak-14815) should work cleanly against trunk.

Is there anyone available to test?

Sam Ottenhoff added a comment - 25-Sep-2009 08:29
Are there any Vista users out there that can test the attached patch?

Sam Ottenhoff added a comment - 25-May-2010 15:40
Zhen, any thoughts on this patch?