Issue Details (XML | Word | Printable)

Key: SAK-15868
Type: Bug Bug
Status: Closed Closed
Resolution: Duplicate
Priority: Blocker Blocker
Assignee: Savitha Prakash
Reporter: Jean-François Lévêque
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Sakai

Newly created sites give a broken view (after Site Description) when edited through Worksite Setup's Edit, Site Info is also broken

Created: 17-Mar-2009 04:03   Updated: 23-Feb-2010 07:35
Component/s: Site Info, Velocity, Worksite Setup
Affects Version/s: 2.6.x, 2.7.0
Fix Version/s: None

Time Tracking:
Not Specified

Environment: sakai/trunk on Oracle and sakai/trunk on HSQLDB
Issue Links:
Depend
 

2.6.x Status: None
2.5.x Status: None
2.4.x Status: None


 Description  « Hide
This may be related to changes for SAK-15823

VelocityServlet : Error processing the template

org.apache.velocity.exception.MethodInvocationException: Invocation of method 'doPlainTextAndLimit' in class org.sakaiproject.site.tool.SiteAction$SiteTextEditAction threw exception class java.lang.NullPointerException : null
org.apache.velocity.exception.MethodInvocationException: Invocation of method 'doPlainTextAndLimit' in class org.sakaiproject.site.tool.SiteAction$SiteTextEditAction threw exception class java.lang.NullPointerException : null
at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:309)
at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:207)
at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:250)
at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:94)
at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:271)
at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:128)
at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:271)
at org.apache.velocity.Template.merge(Template.java:296)
at org.apache.velocity.servlet.VelocityServlet.mergeTemplate(VelocityServlet.java:448)
at org.apache.velocity.servlet.VelocityServlet.doRequest(VelocityServlet.java:387)
at org.apache.velocity.servlet.VelocityServlet.doGet(VelocityServlet.java:333)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:556)
at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505)
at org.sakaiproject.vm.VmServlet.includeVm(VmServlet.java:162)
at org.sakaiproject.cheftool.VelocityPortletPaneledAction.toolModeDispatch(VelocityPortletPaneledAction.java:443)
at org.sakaiproject.site.tool.SiteAction.toolModeDispatch(SiteAction.java:11357)
at org.sakaiproject.cheftool.ToolServlet.doGet(ToolServlet.java:227)
at org.sakaiproject.cheftool.VelocityPortletPaneledAction.doGet(VelocityPortletPaneledAction.java:1014)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
at org.sakaiproject.vm.ComponentServlet.service(ComponentServlet.java:56)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:561)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:469)
at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:364)
at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:301)
at org.sakaiproject.tool.impl.ActiveToolComponent$MyActiveTool.forward(ActiveToolComponent.java:475)
at org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1216)
at org.sakaiproject.portal.charon.handlers.ToolHandler.doTool(ToolHandler.java:188)
at org.sakaiproject.portal.charon.handlers.ToolHandler.doGet(ToolHandler.java:93)
at org.sakaiproject.portal.charon.SkinnableCharonPortal.doGet(SkinnableCharonPortal.java:768)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:613)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:210)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870)
at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:685)
at java.lang.Thread.run(Thread.java:595)

 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Zhen Qian added a comment - 17-Mar-2009 07:12
This is an issue related to SAK-15823 and the problem should be addressed over there.


Jean-François Lévêque added a comment - 12-Jun-2009 01:05
Savitha, the current Status/Resolution does not match the fact you committed changes. Could you update this issue information?

David Horwitz added a comment - 22-Feb-2010 05:36
Reopening and upgrading status as 2.6.x seems broken by related changes that where merged but not these ones that cause an NPE when editing sites.

David Horwitz added a comment - 22-Feb-2010 05:53
Just to clarify current 2.6.x NPE's under various conditions with an NPE from null descriptions the commit above includes a check for null values on the line.

David Horwitz added a comment - 22-Feb-2010 05:59
to reporoduce the NPE on an exisiting site:

1) site info->Edit site information
2) delete the descrion
3) save
4) reset the site-info tool
5) click on Edit site information

Alan Berg added a comment - 22-Feb-2010 06:18
Could not reproduce on 2.7 b2 qa1-nl or trunk today.

Jean-François Lévêque added a comment - 23-Feb-2010 02:50
Savitha, is it Resolved/Fixed for you?

Savitha Prakash added a comment - 23-Feb-2010 07:29
This issue is related to SAK-15823. I looked into the source code, looks like the fix to SAK-15823 has not been applied for 2.6.x, hence the problem persists. I would thing that applying the fix to 2.6.x should resolved the null pointer exception problem for empty description.

Savitha Prakash added a comment - 23-Feb-2010 07:35
Closing this issue, as this has to be dealt in SAK-15823