click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: SAK-16548
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Zhen Qian
Reporter: Angel Nueda Lozano
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Sakai

Incorrect internationalization showing the grade NO GRADE

Created: 12-Jun-2009 04:01   Updated: 03-Mar-2010 02:46
Component/s: Assignments, Internationalization
Affects Version/s: 2.6.0
Fix Version/s: 2.6.1, 2.7.0-b01, 2.8.0 [Tentative]

Time Tracking:
Not Specified

File Attachments: 1. File nograde.diff (2 kB)

Issue Links:
Depend
 
Relate
 

2.7.x Status: Closed
2.6.x Status: Closed
2.5.x Status: None
2.4.x Status: None


 Description  « Hide
Related with SAK-16546.
If an instructor use your own profile with spanish language and grade a submission this will be saved on database in spanish. But, if another instructor with your profile in english language want to see the grade of that submission, he will see in spanish instead of his profile's language.

You can see the patch. This will mean there will be necessary to change scaled_grade property values in database from internationalized values to english 'No grade'. I don't know another form to do it.

 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Zhen Qian added a comment - 16-Jul-2009 09:30
patch applied in r64747.

- Zhen

Nancy Wilkison added a comment - 23-Jul-2009 14:44
QA ENVIRONMENT -
vista, firefox, ie7
8087 server 2.6.x on HSQLDB - Built: 07/23/09 01:00 - Sakai sakai_2-6-x - Server localhost

QA SUMMARY -
for site created today...
alice, ben and charles are "students" on the site, I'm IOR.
1 - created new account as jose w/preferences=Spanish
2 - added jose to site as IOR
3 - created new assignment. graded as jose for no submissions students
alice, ben and charles. all language on grading page is spanish.
4 - as myself, selected each student, page is all in english
5 - as myself, graded ed and re-graded charles.
6 - as jose, looked @ charles and ed, all text is spanish

QA RESULTS -
pass on nightly 8087 server

Jean-François Lévêque added a comment - 24-Jul-2009 02:28
This has not been merged into 2.6.x was the testing done on 2.7?

David Horwitz added a comment - 31-Jul-2009 10:38
does this require DB conversion for existing schools?

Zhen Qian added a comment - 01-Sep-2009 08:32
merged into 2-6-x in r66212

Zhen Qian added a comment - 01-Sep-2009 08:35
For David question, it is a Yes. Any localized "No grade" string inside db will need to be converted to "No grade" in English.

Jean-François Lévêque added a comment - 07-Sep-2009 05:00
Why not storing a language-less string in the db instead of storing a English string?

Matthew Jones added a comment - 23-Sep-2009 08:05
Yea, while it doesn't seem like it matters what you store in the database as nobody will see it anyway, storing the and checking constant "gen.nograd" would make more sense.

Angel Nueda Lozano added a comment - 23-Sep-2009 23:56
Jean-François and Matthew,

Yes, I think it's a good idea storing the constant string related with the file of properties instead of English string.

Zhen Qian added a comment - 01-Oct-2009 07:09
"gen.nograd" is used now in r67023.

Matthew Jones added a comment - 01-Oct-2009 13:20
This is a good change, I have written the conversion scripts to take advantage of this change.

Zhen Qian added a comment - 01-Oct-2009 13:24
Thanks Matthew for testing.

r67023 has been merged into 2-6-x in r67053

Zhen Qian added a comment - 02-Oct-2009 10:09
Matthew then found out a problem with "batch grading with NO Grade" from the "Assign this grade to all participants without a grade", which still writes "No Grade" into db.

Fixed in r67103

Matthew Jones added a comment - 02-Oct-2009 10:15
The change in 67103 fixes the dropdown bug I was seeing. It looks good, I'll post a full writeup in a second and a minor update to the conversion script.

Matthew Jones added a comment - 02-Oct-2009 10:23
QA ENVIRONMENT -
osx, camino
 server 2.6.x - Built: 10/02 - Sakai sakai_2-6-x - Server qa6-us
Tested on assignment 2.6.x versions 66210 (Before this patch) 67053 (Including this patch) and finally with a merge from 67103

QA SUMMARY -
1) @66210
I rolled back the assignment on this server to the version before the first change was committed. (pre 66212)
I created 6 assignments and graded them in 6 different languages (Japanese, Swedish, Chinese, Spanish, English, Russian)
I confirmed that the tool was inserting the wrong localizd values into the database.
I verified that the UI was showing the incorrect information as noted before.
2) @66210
I wrote and modified the conversion script (checked into reference/docs) which would replace specific values of "No Grade" with gen.nograd. I ran this conversion script on the database. There were 6 total rows affected as expected changed to gen.nograd.
3) @67053
I updated the assignment version on the server to the newest 2.6.x version to pick up the changes
I had a bug that I reported concerning the dropdown grading that still inserted "No grade" the items that were converted looked good.
It worked when you went through the grading process and released grades
4) @67053 + 67103 patch
After the bug was fixed @67103 it worked.
There were also some bugs in the conversion script
- Hex was being inserted for some values in the mysql script for the entries that weren't actually being unhexed and didn't need hex processing. This is fixed.
- I also made the replacement a little more specific in both conversion scripts to pick up "No Grade" in quotes rather than without just incase this text appeared somewhere
else. Pretty unlikely but this makes it even more unlikely.

Zhen Qian added a comment - 02-Oct-2009 10:40
r67103 has been merged into 2-6-x in r67107

Anthony Whyte added a comment - 03-Mar-2010 02:45
In 2.7.x prior to 2.7.0-b01.