|
Tested latest trunk code merged into a Sakai 2.6 instance.
The fix did work properly when I set the defaults in sakai.properties as follows: wsetup.home.toolids.count=5 wsetup.home.toolids.1=sakai.iframe.site wsetup.home.toolids.2=sakai.synoptic.announcement wsetup.home.toolids.3=sakai.summary.calendar wsetup.home.toolids.4=sakai.synoptic.messagecenter wsetup.home.toolids.5=sakai.synoptic.chat wsetup.home.toolids.course.count=5 wsetup.home.toolids.course.1=sakai.iframe.site wsetup.home.toolids.course.2=sakai.synoptic.announcement wsetup.home.toolids.course.3=sakai.summary.calendar wsetup.home.toolids.course.4=sakai.synoptic.messagecenter wsetup.home.toolids.course.5=sakai.synoptic.chat However, the expected result of having the synoptic tools added to a course site was not successful when the settings were not placed in sakai.properties. Also, it looks like there is bug on line #656 of SiteAction.java:
if (ServerConfigurationService.getStrings("wsetup.home.toolids" + siteType) != null) { There should be a period after "wsetup.home.toolids." Sam:
I have fixed the missing period problem as you mentioned above. Could you please test if things are working on the trunk build? If the above settings are missing from sakai.properties, you will need to make sure that you have all the synoptic tools defined in the "!worksite" site, in order to see the effect... Hi Zhen,
It looks like you are missing a period in the following line (657) also: rv = new ArrayList(Arrays.asList(ServerConfigurationService.getStrings("wsetup.home.toolids.") + siteType)); After that is fixed, I will close the ticket as all scenarios work correctly in both trunk and a merged 2.6.x instance. This is fixed, thanks Zhen. I tested both on a trunk build a merged 2.6.x build.
First, I tested without any changes to sakai.properties. 1) Confirm that synoptic chat and summary calendar are set in Home page of "!worksite" 2) Create a site with no additional tools 3) Confirmed that only Site Information was added to Home page 4) Added Announcements and Schedule via Site Info 5) Confirmed that synoptic announcements and summary calendar are added to Home page of site 6) Added Messages tool and confirmed that it was *not* added to Home 7) Modified !worksite and added synoptic message center tool to Home Page 8) Added Messages tool again to site and confirmed that synoptic tool was added to Home page of site Second, I tested with custom changes to sakai.properties as follows: wsetup.home.toolids.count=5 wsetup.home.toolids.1=sakai.iframe.site wsetup.home.toolids.2=sakai.synoptic.announcement wsetup.home.toolids.3=sakai.summary.calendar wsetup.home.toolids.4=sakai.synoptic.messagecenter wsetup.home.toolids.5=sakai.synoptic.chat wsetup.home.toolids.course.count=5 wsetup.home.toolids.course.1=sakai.iframe.site wsetup.home.toolids.course.2=sakai.synoptic.announcement wsetup.home.toolids.course.3=sakai.summary.calendar wsetup.home.toolids.course.4=sakai.synoptic.messagecenter wsetup.home.toolids.course.5=sakai.synoptic.chat Test plan was identical to above. All settings for synoptic tools were no longer controlled by !worksite and were instead controlled by sakai.properties settings. It seems the merge into 2.6.x has already been done by Zhen
Should this work with existing sites?
From Site Info, I tried to remove and add tools again but this didn't work. From Site Info, when I'm removing the Home Page I can't get it back. Are other changes not in 2.6.0 needed?
Briefly testing 2.6.x on HSQLDB (nightly2) with a course site, announcements and chat get their synoptic tools. Activating schedule doesn't bring the calendar. Activating forums or messages doesn't bring sakai.synoptic.messagecenter.
Will try later with trunk, which is currently building. Jean-Francios:
The nightly server doesn't have the "wsetup.home.toolids.course" params set, so Site Info tool will look for the settings inside !worksite as the template. If you take a look of the Home page of that site, the default setting contains "sakai.iframe.site sakai.synoptic.announcement sakai.synoptic.chat". This helps to explain that synoptic announcement and chat can be automatically added into Home page, but not for Forums or schedule. However, if you can added synoptic Forums and Schedule to the site, you will see the synoptic tools inside the Home tool. The !worksite method works fine with new sites, I get the calendar and synoptic message center on 2.6.x on HSQLDB (nightly2).
Checked on qa1-za (svn tags/sakai-2.7.0-M1) using MySQL/InnoDB with custom settings prescribed.
I am working on the Msgcntr 2.7 release and need to set up the Message & Forums Synoptic tool to be automatically populated in MyWorkspace... I wrote this almost exact implementation at IU, but the one difference I added was to allow synoptic tools to stay in a MyWorkspace even if the tool's "parents" didn't exist. The problem I was running into, was whenever a user would save their MyWorkspace Site after editing tools, the synoptic tools that were needed, but didn't have the parent tool in the site, were removed. I've attached a patch for this quick fix. This is something I need for the 2.7 release.
Should the latest changes be included in 2.6.x or is it more than a bugfix?
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Closed
Major
tools are not auto-added into Home tool page
The sequence of looking up home tool ids has been revised as follows:
1) check if there is settings in sakai.properties. Following are example settings for site of general site type and course site type:
wsetup.home.toolids.count=5
wsetup.home.toolids.1=sakai.iframe.site
wsetup.home.toolids.2=sakai.synoptic.announcement
wsetup.home.toolids.3=sakai.summary.calendar
wsetup.home.toolids.4=sakai.synoptic.messagecenter
wsetup.home.toolids.5=sakai.synoptic.chat
wsetup.home.toolids.course.count=5
wsetup.home.toolids.course.1=sakai.iframe.site
wsetup.home.toolids.course.2=sakai.synoptic.announcement
wsetup.home.toolids.course.3=sakai.summary.calendar
wsetup.home.toolids.course.4=sakai.synoptic.messagecenter
wsetup.home.toolids.course.5=sakai.synoptic.chat
2. if toolid list is empty, check for site templates:
2.1 use any template site definition
2.2 else use site template for different site types
3. if toolid list is still empty, use default settings
4. if there is already a Home tool for the site, add in any extra tool id from the page which is not in the above toolid list.
- Zhen