click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: SAK-16905
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Jasmine Thapa
Reporter: Earle R Nietzel
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Sakai

"Mark for Review" option in samigo not appearing in exams created prior to 2.6

Created: 01-Sep-2009 07:32   Updated: 29-Sep-2009 12:17
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 2.6.0
Fix Version/s: 2.6.1

Time Tracking:
Not Specified

2.6.x Status: Closed
2.5.x Status: None
2.4.x Status: None


 Description  « Hide
Seems exams in 2.5 were not migrated to 2.6 correctly.

1) The new option "Mark for Review" in Assessment "Settings" is not appearing for exams created prior to 2.6.
After some testing the tables SAM_ASSESSMETADATA_T and SAM_PUBLISHEDMETADATA_T there is a new LABEL being added when an assessment is created named 'markForReview_isInstructorEditable' which is set to 'true' by default.

2) Also and probably more importantly existing exams that were random, the mark for review option is not working at all which is different from 2.5 behaviour.
After some testing setting MARKFORREVIEW field to '1' in tables SAM_ASSESSACCESSCONTROL_T and SAM_PUBLISHEDACCESSCONTROL_T returned existing exams to there 2.5 behaviour.

I think both of these should be added to the 2.5 to 2.6 migration scripts.


 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Karen Tsao added a comment - 03-Sep-2009 14:29 - edited
Earle,

After some discussions, here is what we proposed:

Because this "Mark for Review" setting is a new feature in 2.6, can we leave the 2.5 assessments perform as they were? That is, during authoring, the new option "Mark for Review" in Assessment Settings page won't show up for 2.5 assessments. During delivery, the "Mark for Review" will be seen for these assessments.

In this way, you only need to run following is the sql to fix the second issue:

update SAM_ASSESSACCESSCONTROL_T set MARKFORREVIEW = 1 where ASSESSMENTID not in (1, 3, 4, 5, 6, 7);
update SAM_PUBLISHEDACCESSCONTROL_T set MARKFORREVIEW = 1

Please note, this query should only be run during migration period because this will make all assessments turn "Mark for Review" on (it's hard to find out which ones are created prior 2.6 and which ones are not). If for certain 2.5 assessments users want to turn "Mark for Review" off, you can set the MARKFORREVIEW to 0.

Please let me know how you think. Thanks.
Karen


Earle R Nietzel added a comment - 04-Sep-2009 05:48
I have thought of that approach and it seemed possible until instructors start to import exams from previous classes.
The new mark for review option does not appear when instructors import previous exams, and since a lot of instructors are importing exams these days it becomes a problem.

Karen Tsao added a comment - 14-Sep-2009 17:15
Earle,
I cannot reproduce your error using my XML (I think they are 2.4 XML). Can you please send me your XML so I can give it a try?
Thanks,
Karen

Earle R Nietzel added a comment - 15-Sep-2009 07:30
Sorry probably should have mentioned which import we were using!

The problem is when using the import from site option from the Site Editor. (Most faculty are using this to import)

The QTI import works fine.

Earle R Nietzel added a comment - 15-Sep-2009 14:38
Hi Karen,

Using what you have stated previously:

update SAM_ASSESSACCESSCONTROL_T set MARKFORREVIEW = 1 where ASSESSMENTID not in (1, 3, 4, 5, 6, 7);
update SAM_PUBLISHEDACCESSCONTROL_T set MARKFORREVIEW = 1

and then some SQL to add LABEL='markForReview_isInstructorEditable' to tables SAM_ASSESSMETADATA_T and SAM_PUBLISHEDMETADATA_T for the assessments that need them.

It seems this would fix this whole problem.

I will try and get some SQL to do the last part.

Karen Tsao added a comment - 15-Sep-2009 15:22
Hi Earle,

But if you do import from an old site, I think you might still have the issue. Can you please give this a try?

Thanks,
Karen

Karen Tsao added a comment - 22-Sep-2009 17:20
Hi Earle,

I made following fix. Please let me know if you see any problems.

After my fix, for the assessments created prior 2.6, the "Mark for Review" setting will be available for all the assessments and it will be checked. That is, for all these assessment, the Mark for Review feature will be on as 2.5.

Thanks,
Karen

commit -m "SAK-16905" /opt/sakai_trunk/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/AssessmentFacadeQueries.java
    Sending opt/sakai_trunk/sam/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/AssessmentFacadeQueries.java
    Transmitting file data ...
    Committed revision 66739.

Karen Tsao added a comment - 22-Sep-2009 17:23
Earle,

As we don't have 2.5 assessments in our QA instance, if you happen to have a QA instance that can verify my fix, can you please help?

Thanks,
Karen

Earle R Nietzel added a comment - 23-Sep-2009 06:57
Hi Karen,

Yes I do have a QA (dev) system to test this on. Will start testing it now and let you know the results.

Thanks again,
Earle

Earle R Nietzel added a comment - 23-Sep-2009 08:44
Hi Karen,

Did some testing and exams that are now imported using the "Site Editor", now have the new "Mark For Review" option.


Karen Tsao added a comment - 23-Sep-2009 10:47
Hi Earle,

Thanks a lot for your help. I will let our QA do some regression tests to make sure the newly created assessments are imported correctly. And hopefully we can close this bug soon.

Thanks again,
Karen

Jasmine Thapa added a comment - 24-Sep-2009 11:56 - edited
Verified the following;

- Created Assessments ( all 6) from Assessment types
- Mark for Review Setting is selected by default in Formative Assessments Types. Mark for Review setting is not available for Survey type. Rest of the Assessment Types settings have "Mark for Review" deselected by default. Works as expected.

- Published Assessments.
- As a student, took Assessments, " Mark for Review" is available in student view in Formative Assessment Type. Selected "Mark for Review" checkbox.. Before submitting Assessment went to TOC page, the question mark symbol next to "question marked for Review" was available. Submitted Assessments. Works as Expected.

- As an instructor, created another site and used " Import for Site" link to import data. Used "merge data" options. Assessments/ " Mark for Review" Setting is imported correctly. Works as expected.

- Created another new Coursesite and Imported data from previous site in Worksite Info ( Re-use materials from another site) page. Assessments/ " Mark for Review" Setting is imported correctly. Works as expected.

Karen Tsao added a comment - 25-Sep-2009 10:34
For 2.6.x:

coursework-dev4:~/sakai2.6/sakai2.6-oracle/sakai/sam >svn commit -m "SAK-16905"
Sending samigo-services/src/java/org/sakaiproject/tool/assessment/facade/AssessmentFacadeQueries.java
Transmitting file data .
Committed revision 66835.