Issue Details (XML | Word | Printable)

Key: SAK-18159
Type: Bug Bug
Status: Closed Closed
Resolution: Duplicate
Priority: Critical Critical
Assignee: Matthew Jones
Reporter: Alan Berg
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Sakai

Customize tabs does not correctly limit the number of Tabs to be displayed correctly

Created: 09-Mar-2010 08:28   Updated: 29-Jun-2010 16:52
Component/s: Preferences
Affects Version/s: 2.7.0
Fix Version/s: 2.7.0

Time Tracking:
Not Specified

File Attachments: None
Image Attachments:

1. Screenshot.png
(62 kB)
Environment:
qa2-us.sakaiproject.org
Firefox 3.5.8

2.7.x Status: None
2.6.x Status: None
2.5.x Status: None
2.4.x Status: None


 Description  « Hide
When as a registered userand you belong to 5 sites and My Workspace
If you have the default 4 tabs to be displyaed in Preferences/Customize tabs/ My Active Sites
Then the My Active Tabs is not displayed and all 5 tabs are shown. See screen grab

 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
[ Permlink | « Hide ]
Alan Berg added a comment - 09-Mar-2010 08:33
It still has issues with boundary checking such as using -1 for Tabs displayed

And large minus numbers produce the following stack trace

org.sakaiproject.portal.api.PortalHandlerException: org.sakaiproject.tool.api.ToolException: javax.servlet.jsp.JspException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "-999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at org.sakaiproject.portal.charon.handlers.ToolHandler.doPost(ToolHandler.java:73)
caused by: org.sakaiproject.tool.api.ToolException: javax.servlet.jsp.JspException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "-999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1216)
caused by: org.apache.jasper.JasperException: javax.servlet.jsp.JspException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "-999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:355)
caused by: javax.servlet.ServletException: javax.servlet.jsp.JspException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "-999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:774)
caused by: javax.faces.el.EvaluationException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "-999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at com.sun.faces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:154)
caused by: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "-999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at com.sun.faces.el.impl.Coercions.coerceToPrimitiveNumber(Coercions.java:446)
    at com.sun.faces.el.impl.Coercions.applyArithmeticOperator(Coercions.java:805)
    at com.sun.faces.el.impl.ArithmeticOperator.apply(ArithmeticOperator.java:84)
    at com.sun.faces.el.impl.BinaryOperatorExpression.evaluate(BinaryOperatorExpression.java:179)
    at com.sun.faces.el.impl.ExpressionEvaluatorImpl.evaluate(ExpressionEvaluatorImpl.java:243)
    at com.sun.faces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:173)
    at com.sun.faces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:154)
    at javax.faces.component.UIParameter.getValue(UIParameter.java:129)
    at com.sun.faces.renderkit.html_basic.OutputMessageRenderer.encodeEnd(OutputMessageRenderer.java:143)
    at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:720)
    at javax.faces.webapp

And high numbers still

org.sakaiproject.portal.api.PortalHandlerException: org.sakaiproject.tool.api.ToolException: javax.servlet.jsp.JspException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "99999999999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at org.sakaiproject.portal.charon.handlers.ToolHandler.doPost(ToolHandler.java:73)
caused by: org.sakaiproject.tool.api.ToolException: javax.servlet.jsp.JspException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "99999999999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at org.sakaiproject.portal.charon.SkinnableCharonPortal.forwardTool(SkinnableCharonPortal.java:1216)
caused by: org.apache.jasper.JasperException: javax.servlet.jsp.JspException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "99999999999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:355)
caused by: javax.servlet.ServletException: javax.servlet.jsp.JspException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "99999999999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:774)
caused by: javax.faces.el.EvaluationException: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "99999999999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at com.sun.faces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:154)
caused by: com.sun.faces.el.impl.ElException: An exception occured trying to convert String "99999999999999999999999999999999999999999999999999999999999999" to type "java.lang.Long"
    at com.sun.faces.el.impl.Coercions.coerceToPrimitiveNumber(Coercions.java:446)
    at com.sun.faces.el.impl.Coercions.applyArithmeticOperator(Coercions.java:805)
    at com.sun.faces.el.impl.ArithmeticOperator.apply(ArithmeticOperator.java:84)
    at com.sun.faces.el.impl.BinaryOperatorExpression.evaluate(BinaryOperatorExpression.java:179)
    at com.sun.faces.el.impl.ExpressionEvaluatorImpl.evaluate(ExpressionEvaluatorImpl.java:243)
    at com.sun.faces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:173)
    at com.sun.faces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:154)
    at javax.faces.component.UIParameter.getValue(UIParameter.java:129)
    at com.sun.faces.renderkit.html_basic.OutputMessageRenderer.encodeEnd(OutputMessageRenderer.java:143)



[ Permlink | « Hide ]
Alan Berg added a comment - 09-Mar-2010 08:38
0 for tabs displays first generates a bug report and then after pressing the tool reset the 'My Active Sites; tabs appears, but then on clicking only shows a grayed out area.

Alan Berg made changes - 09-Mar-2010 08:42
Field Original Value New Value
Link This issue relates to SAK-18158 [ SAK-18158 ]
Eli Cochran made changes - 16-Mar-2010 08:31
Link This issue relates to SAK-18158 [ SAK-18158 ]
Alan Berg made changes - 16-Mar-2010 09:03
Assignee Megan May [ mmmay ] MAINT TEAM [ maintenanceteam ]
Anthony Whyte made changes - 22-Mar-2010 17:53
Fix Version/s 2.7.0 [ 11276 ]
Fix Version/s 2.7.0-b05 [ 11810 ]
Matthew Jones made changes - 26-Mar-2010 11:08
Assignee MAINT TEAM [ maintenanceteam ] Matthew Jones [ jonespm ]
[ Permlink | « Hide ]
Matthew Jones added a comment - 29-Mar-2010 13:45
There is actually a comment in the code, so this is a known issue and expected issue. It does *kind* of make sense as the drop down box is as big as one of the tabs, but might be confusing to the user.

126 // Note that if there are exactly one more site
127 // than tabs allowed - simply put the site on
128 // instead of a dropdown with one site

https://source.sakaiproject.org/svn/portal/trunk/portal-impl/impl/src/java/org/sakaiproject/portal/charon/site/DefaultSiteViewImpl.java

I will attach a patch that fixes the other noted issues with the bounds checking.

Matthew Jones made changes - 01-Apr-2010 07:36
Link This issue is related to SAK-17868 [ SAK-17868 ]
[ Permlink | « Hide ]
Matthew Jones added a comment - 12-Apr-2010 07:40
Fixed by SAK-17868

Matthew Jones made changes - 12-Apr-2010 07:40
Status Open [ 1 ] Closed [ 6 ]
Resolution Duplicate [ 3 ]
Anthony Whyte made changes - 29-Jun-2010 16:52
Affects Version/s 2.7.0 [ 11276 ]
Affects Version/s 2.7.0-b04 [ 11791 ]

Powered by a free Atlassian JIRA open source license for Sakai Foundation. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators