click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: SAK-6039
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Unassigned
Reporter: Stephen Marquard
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Sakai

Collapse vendor-specific sql into generic sql in DbAuthzGroupService

Created: 23-Aug-2006 03:43   Updated: 23-Oct-2008 11:08
Component/s: Database service (Pre-K1/2.6), Global
Affects Version/s: trunk [DO NOT USE]
Fix Version/s: 2.4.0

Time Tracking:
Not Specified

2.6.x Status: None
2.5.x Status: None
2.4.x Status: None


 Description  « Hide
DbAuthzGroupService has 3 queries which have different versions for Oracle/hsql vs mysql, viz.:

* read the roles and role functions
* read the role descriptions
* read the role grants

The mysql versions of these queries were changed to use joins rather than subselects, as subselects are not optimized correctly by mysql and are thus a performance problem.

It's possible that these versions can be used for all 3 databases with minor changes, _if_ performance of joins vs subselects is either better or the same on Oracle for these queries (opinions seem to vary).

If so, it would be preferably for code maintainability to have a single version of each query rather than vendor-specific versions.


 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Megan May added a comment - 14-Mar-2007 15:46
Updating these issues to have a fix version of 2.4.0.004 tag as these will be in the .004 tag (to be cut on March 18)

Megan May added a comment - 12-Apr-2007 13:45
Tasks for 2.4 have been completed. If you find a problem related to a task, please create a bug report and use the Link feature to create a connection between the two issues.