click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: SAK-6763
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Brian Jorgensen
Reporter: Charles Hedrick
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Sakai

feedback settings are ignored

Created: 07-Oct-2006 17:05   Updated: 23-Oct-2008 11:01
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 2.1.2
Fix Version/s: 2.3.0

Time Tracking:
Not Specified

2.6.x Status: None
2.5.x Status: None
2.4.x Status: None


 Description  « Hide
Author's feedback settings are ignored. A routine is called that turns on all options, overriding whatever the author had set. Problem was created in 2.1.2. It's fixed in 2.3. I haven't checked 2.2.

sam/tool/src/java/org/sakaiproject/tool/assessment/ui/listener/delivery/DeliveryActionListener.java

*** DeliveryActionListener.java~ Sat Oct 7 15:06:10 2006
--- DeliveryActionListener.java Sat Oct 7 15:07:34 2006
***************
*** 158,165 ****
                  delivery.setAssessmentGrading(ag);
              }
                setDisplayByAssessment(delivery);
! setDeliveryFeedbackOnforEvaluation(delivery);
! setGraderComment(delivery);
                break;
  
        case 4: // Grade assessment
--- 158,167 ----
                  delivery.setAssessmentGrading(ag);
              }
                setDisplayByAssessment(delivery);
! // setDeliveryFeedbackOnforEvaluation(delivery);
! // 2.3 also comments out the following. don't do so unless
! // we have issues
! setGraderComment(delivery);
                break;
  
        case 4: // Grade assessment





 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Lydia Li added a comment - 09-Oct-2006 11:43
Brian, can you follow up with Charles (he already added this to SAK-5405).

Filter Maintainer added a comment - 11-Oct-2006 08:15
Not a problem in 2.3.0.