|
the action comes from the reques parameter and not from the command map. Its not in the command map since its the default.
If you are not seeing the events then I will commit a version with some info level logging. Unfortunately you will have to take this from trunk as there are no more tasks going into 2.3 after 005, which I just missed. Hi Ian.
In Sakai 2.4.x (r31968) rwiki still not logging "wiki.read" events. This is happening because the following method is never called: uk.ac.cam.caret.sakai.rwiki.tool.service.impl.CommandServiceImpl.setTrackReads() Not called when specifying in sakai.properties: trackReads@uk.ac.cam.caret.sakai.rwiki.tool.service.api.CommandService=true nor when hard coded in: /rwiki-tool/tool/src/webapp/WEB-INF/commandComponents.xml I have tested this and it works as it currently is in trunk except:
You cant set properties in beans in components using the property@springid mechanism since this is a function of the Sakai component manage and Tool level components are loaded by Spring using a webapplication context. I have tested by setting the value = true in commandComponents.xml Which is deployed as a file onto the file system. Hence I am closing it. Closing as it is fixed.
If you want more control over the setting please open annother JIRA and I will fix there Thanks Ian.
Created |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Task
Closed
Major
Improve Events in Rwiki
I checked both sakai property (for misspelled characters) and commandComponents.xml and it looks like this property is being set.
But, by looking at the following line at CommandServiceImpl:
(...)
if ( trackReads && "view".equals(action) ) {
(...)
It looks like you forgot to include "view" in the map passed as parameter to "commandMap" on the commandComponents.xml. Probably a bean definition is missing too (?)
Hope it helps,
Nuno.