[#SAK-8459] Calendar start-of-week internationalization

Sakai

Calendar start-of-week internationalization

Created: 19-Feb-2007 10:44 Updated: 27-Oct-2009 13:47

Component/s:

Internationalization, Schedule

Affects Version/s:

2.3.1, 2.4.0, 2.4.1, 2.5.0, 2.5.2, 2.5.3

Fix Version/s:

2.6.0

Time Tracking:

Not Specified

File Attachments:

calendar.zip (111 kB)
2.

parche_calendar_2-5-3.patch (105 kB)

Issue Links:

Relate

This issue is related to:

~~SAK-12878~~ Calendar Summary start-of-week localization

~~SAK-8128~~ Flexibility in configuring schedule (and calendar widgets)

2.6.x Status:	None
2.5.x Status:	Merge
2.4.x Status:	None

Description

« Hide

Until now, schedule presentation is not internationalized and not user preferences-dependent. In some countries weeks start on Monday and not on Sunday. We have solved this modifying CalendarUtil in order to take into consideration Locale and Time Zone user preferences and also CalendarAction to be able to build weeks, months and years according to these preferences.
We also have changed chef_calendar_viewDay.vm, chef_calendar_viewMonth.vm, chef_calendar_viewYear.vm and chef_calendar_viewWeek.vm.

I attach a zip file with the java and vm modified files and the diff file so that changes can be commited as soon as possible.

All

Comments

Work Log

Change History

Subversion Commits

git Commits

Sort Order:

[ Permlink | « Hide ]

Beth Kirschner added a comment - 31-Jan-2008 17:21

Modified version of patch checked -- thanks!

QA Instructions:
With a language preference of English (US):
1 Verify day, week, month, year, list view of calendar (week starts on Sunday)
2. Verify printing the same views

With a European language preference (e.g. French, Spanish)
1 Verify day, week, month, year, list view of calendar (week starts on Monday)
2. Verify printing the same views

[ Permlink | « Hide ]

Jean-François Lévêque added a comment - 02-Oct-2008 03:13 - edited

Checking for start of week on day doesn't help.

In list view, how should "events for this week" behave? I think other show values within list view shouldn't be checked.

[ Permlink | « Hide ]

Beth Kirschner added a comment - 02-Oct-2008 07:07

Fixed problem with start-of-week for list view "Events for this week" (r53048).
The intention of verifying all views was to make sure nothing was broken (so start-of-week is not checked for day view, for example).

[ Permlink | « Hide ]

Daniel Merino added a comment - 03-Jul-2009 00:18

I have adapted the patches of ~~SAK-8459~~ and ~~SAK-12878~~ made by Beth Kirschner and David Roldán to our 2.5.3 version, so a single patch internationalizes the calendar and the calendar summary. It seems to work fine.

I attach to this JIRA the diff file (parche_calendar_2-5-3.patch). As the patch is made from the 2.6 version patches, I think that should be valid for any 2.5.x.

IMPORTANT: Keep in mind that the 2.5.3 version doesn't have the properties reunified in the calendar-bundles folder as 2.6 does, so you must create that folder inside the calendar root folder and place in it the updated properties files. These properties files can be found in https://source.sakaiproject.org/svn/calendar/trunk/calendar-bundles/