click here for details... Sakai Executive Director Position Search now open
Issue Details (XML | Word | Printable)

Key: SAK-8638
Type: Task Task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Beth Kirschner
Reporter: Beth Kirschner
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Sakai

Allow edit/delete of feedback in wizard pages and matrix cells

Created: 09-Mar-2007 12:31   Updated: 27-Oct-2009 13:43
Component/s: OSP: Wizards - General
Affects Version/s: 2.4.0, 2.4.1
Fix Version/s: 2.6.0

Time Tracking:
Not Specified

Issue Links:
Depend
 
Duplicate
 
Relate

2.6.x Status: None
2.5.x Status: None
2.4.x Status: None


 Description  « Hide
Add the ability to edit/delete feedback and also possibly evaluations from wizard pages and matrix cells. Users occasionally add feedback/evaluations by mistake, and there is no way to back it out.



 All   Comments   Work Log   Change History   Subversion Commits   git Commits      Sort Order: Ascending order - Click to sort in descending order
Peter A. Knoop added a comment - 24-Mar-2007 14:55
[Bulk Comment] This issue is currenlty classified as a Task scheduled to be addressed for 2.4, however, we are now past the Sakai 2.4 Code Freeze. At this time, work should be focused only on resolving Bugs and addressing release-related Tasks; no features should be added or modified at this point without notifying the Release Mangement team. Please update the estimated Fix Version of this issue to reflect more accurately when it will get addressed, such as in the next release, 2.5.0.000 [Tentative], or set it to Unknown. Thanks.

Peter A. Knoop added a comment - 18-Apr-2007 07:12
This issue was reported against Nightly/SVN-Trunk after 2.3.1 was released. It is still unresolved at this point, therefore, it is most likely affecting 2.4.0 as well, and Affects Version is being updated to the current 2.4 tag (2.4.0.010) to reflect this.

Beth Kirschner added a comment - 17-Jun-2008 13:51
The locking/unlocking logic needs to be looked at. Currently, feedback/evaluations are always locked, while reflections are not locked until status is PENDING. This allows clever users to delete the reflection form under resources, causing the matrix tool to crash :-(

Suggested change is to keep all review content locked (feedback/evaluations/reflections), and unlock for edits/deletes when the status allows (reflections can be edited until cell submitted for evaluation; feedback/evaluations can be edited/deleted until cell submitted/completed).

Beth Kirschner added a comment - 18-Jun-2008 09:04
Implemented. QA Instructions:

1. verify add/delete student forms still works as before
2. verify add/edit/delete of feedback for the following (prior to COMPLETE)
- (item) evidence
- (item) other evidence
- general feedback
- evaluations
3. verify no add/edit/delete of feedback after cell is COMPLETE

Beth Kirschner added a comment - 23-Jun-2008 12:06
Re-opened to implement changes as discussed at OSP conference call:

Feedback -- edit/delete option (even after complete); add allowed anytime, even after complete
Evaluations - edit/delete option (but not allowed when complete)
Relections - delete option, prior to submitting

TBD: how to set option (matrix property or by sakai.properties)

Beth Kirschner added a comment - 09-Jul-2008 11:32
Revised as per above comments.

Option to disable edit/delete of feedback/reflection/evaluation is a tool property, true by default, which can be disabled by editing osp/matrix/tool/src/webapp/WEB-INF/matrix-web-config.xml as follows:

124c124
< <property name="enableReviewEdit"><value>true</value></property>
---
> <property name="enableReviewEdit"><value>false</value></property>

Noah Botimer added a comment - 15-Jul-2008 14:59
NOTE: This feature also requires revision 47680, which is not mentioned in the automatic commit messages.