|
[
Permlink
| « Hide
]
Peter A. Knoop added a comment - 24-Mar-2007 14:55
[Bulk Comment] This issue is currenlty classified as a Task scheduled to be addressed for 2.4, however, we are now past the Sakai 2.4 Code Freeze. At this time, work should be focused only on resolving Bugs and addressing release-related Tasks; no features should be added or modified at this point without notifying the Release Mangement team. Please update the estimated Fix Version of this issue to reflect more accurately when it will get addressed, such as in the next release, 2.5.0.000 [Tentative], or set it to Unknown. Thanks.
This issue was reported against Nightly/SVN-Trunk after 2.3.1 was released. It is still unresolved at this point, therefore, it is most likely affecting 2.4.0 as well, and Affects Version is being updated to the current 2.4 tag (2.4.0.010) to reflect this.
The locking/unlocking logic needs to be looked at. Currently, feedback/evaluations are always locked, while reflections are not locked until status is PENDING. This allows clever users to delete the reflection form under resources, causing the matrix tool to crash :-(
Suggested change is to keep all review content locked (feedback/evaluations/reflections), and unlock for edits/deletes when the status allows (reflections can be edited until cell submitted for evaluation; feedback/evaluations can be edited/deleted until cell submitted/completed). Implemented. QA Instructions:
1. verify add/delete student forms still works as before 2. verify add/edit/delete of feedback for the following (prior to COMPLETE) - (item) evidence - (item) other evidence - general feedback - evaluations 3. verify no add/edit/delete of feedback after cell is COMPLETE Re-opened to implement changes as discussed at OSP conference call:
Feedback -- edit/delete option (even after complete); add allowed anytime, even after complete Evaluations - edit/delete option (but not allowed when complete) Relections - delete option, prior to submitting TBD: how to set option (matrix property or by sakai.properties) Revised as per above comments.
Option to disable edit/delete of feedback/reflection/evaluation is a tool property, true by default, which can be disabled by editing osp/matrix/tool/src/webapp/WEB-INF/matrix-web-config.xml as follows: 124c124 < <property name="enableReviewEdit"><value>true</value></property> --- > <property name="enableReviewEdit"><value>false</value></property> NOTE: This feature also requires revision 47680, which is not mentioned in the automatic commit messages.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||