[#SMS-233] Tool allows time to send == time to expire

Contrib: SMS

Tool allows time to send == time to expire

Created: 10-Mar-2010 01:24 Updated: 23-Apr-2010 06:45

Component/s:

User Tool

Affects Version/s:

0.14

Fix Version/s:

0.16

Time Tracking:

Not Specified

Issue Links:

Duplicate

This issue is duplicated by:

~~SMS-234~~ EP does not run full task validation on an update action

Description

« Hide

The user time allows a task to be created where the time to send is equal to the time to expire. This causes the task to expire as soon as it is proccessed

All

Comments

Work Log

Change History

Sort Order:

Lovemore Nalube made changes - 18-Mar-2010 07:22

Field	Original Value	New Value
Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Non-Issue [ 6 ]

[ Permlink | « Hide ]

Lovemore Nalube added a comment - 19-Mar-2010 00:43

Entity Provider does not run service layer task validation on an update action.

Lovemore Nalube made changes - 19-Mar-2010 00:43

Resolution	Non-Issue [ 6 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Lovemore Nalube made changes - 19-Mar-2010 00:44

Link

This issue is duplicated by ~~SMS-234~~ [ ~~SMS-234~~ ]

Lovemore Nalube made changes - 19-Mar-2010 00:44

Comment

[ Real issue is at: ~~SMS-234~~ ]

Lovemore Nalube made changes - 19-Mar-2010 00:44

Comment

[ org.sakaiproject.sms.logic.smpp.validate.SmsTaskValidatorImpl@147 has a check for this case. Checks that expire is after send time.

if ( smsTask.getDateToSend() != null && smsTask.getDateToExpire() != null && smsTask.getDateToExpire().before(smsTask.getDateToSend()) ){
errors.add(ValidationConstants.TASK_DATE_TO_SEND_AFTER_EXPIRY);
}

It's possible that the user edited an already existing SMS. A bug Jira exists for this here: ~~SMS-234~~ ]

Lovemore Nalube made changes - 19-Mar-2010 03:33

Status	Reopened [ 4 ]	Resolved [ 5 ]
Fix Version/s		0.15 [ 11723 ]
Resolution		Fixed [ 1 ]

David Horwitz made changes - 23-Apr-2010 06:45

Fix Version/s		0.16 [ 11844 ]
Fix Version/s	0.15 [ 11723 ]