History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SAK-11137
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Huong Nguyen
Reporter: Lydia Li
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Sakai

Add event logging for Samigo user operations

Created: 14-Aug-2007 14:59   Updated: 23-Oct-2008 07:48
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 2.4.0, 2.4.1
Fix Version/s: 2.5.0

Time Tracking:
Not Specified

2.4.x Status: None
2.5.x Status: None
2.6.x Status: None


 Description  « Hide
Criteria for promoting to a core tool status:
"The tool should generate event codes that are triggered minimally on new, revise, and delete actions on the basic objects created by the tool."

The following events will be logged to the SAKAI_EVENT table:
Creating a new assessment
Revising an assessment.
Publishing an assessment
Starting/Open an assessment (start to take an assessment)
Submitting an assessment
Sending an email


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Karen Tsao - 30-Aug-2007 12:13
commit -m "SAK-11137" C:/sakai/sam/samigo-app/pom.xml C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/util/EmailBean.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/PublishAssessmentListener.java
    Sending sakai/sam/samigo-app/pom.xml
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/util/EmailBean.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/PublishAssessmentListener.java
    Transmitting file data ...
    Committed revision 34600.

Stephen Marquard - 30-Aug-2007 12:41
How about logging start / open an assessment as well?

Stephen Marquard - 30-Aug-2007 12:43
Also for consistency with other tools, an event for creating a new assessment, and revising an assessment.

Karen Tsao - 30-Aug-2007 13:53
commit -m "SAK-11137" C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/AuthorAssessmentListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/samlite/AssessmentListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/AuthorAssessmentListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/samlite/AssessmentListener.java
    Transmitting file data ...
    Committed revision 34610.

Karen Tsao - 30-Aug-2007 15:58
commit -m "SAK-11137" C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/ItemAddListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SaveAssessmentSettings.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePartListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/delivery/DeliveryActionListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/ItemAddListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SaveAssessmentSettings.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePartListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/delivery/DeliveryActionListener.java
    Transmitting file data ...
    Committed revision 34612.

Karen Tsao - 05-Sep-2007 10:28
To verify this, you will need to look into db (sakai_event) to see if these events are logged correctly. The Samigo events should start with "sam" and followed by the event you just fire. For example, if you just publish an assessment, you should see a record in sakai_event table as:

EVENT_DATE EVENT REF
(the date/time you publish the assessment) sam.publish assessmentId=xxx, publishedAssessmentId=xxx


Karen Tsao - 05-Sep-2007 10:30
Looks like my format of the above example doesn't work. Let me redo in this wayL

EVENT_DATE: (the date/time you publish the assessment)
EVENT: sam.publish
REF: assessmentId=xxx, publishedAssessmentId=xxx

Karen Tsao - 25-Sep-2007 14:19
Huong,
Here is the query you want to use: SELECT * FROM sakai_event s

Huong Nguyen - 27-Sep-2007 11:58
Tested on Stanford nightly: http://coursework-dev4.stanford.edu:8090/portal

Action Expected Log Current Log
1. Creating a New Assessment sam.createAssessment sam.createAssessment
2. Add Question sam.addItem sam.addItem
3. Preview an Assessment nothing sam.takeAssessment
4. Revising an Assessment sam.editAssessment sam.addItem
5. EditSetting sam.editSetting sam.editSetting
6. Publish an Assessment sam.publish sam.publish
7. Start Taking Assessment sam.takeAssessment sam.takeAssessment
8. Submitting an Assessment sam.submit sam.submit

1,2, 5, 6, 7 and 8 are currently correct logged.
3 and 4 are needed to be fixed

Karen Tsao - 02-Oct-2007 17:06
Good catch! Thanks. I will take out the log for preview.

For item 4, because I don't want to put in logic to distinguish add or edit (this will affect performance), I will do following changes:
2. Add Question sam.addOrEditItem
4. Revising an Assessment sam.addOrEditItem
5. EditSetting sam.addOrEditSetting

Please let me know if this is fine with you. Thanks.

Huong Nguyen - 03-Oct-2007 09:19
Look good! let me re write the expect values:
Action| Log
Creating a New Assessment | sam.createAssessment
Revising an Assessment, add/edit question, add/edit Part | sam.addOrEditItem
EditSetting|sam.addOrEditSetting
Publish An Assessment | sam. publish
Starting taking An assessment | sam.takeAssessment
Submitting an Assessment | sam.submit

No log for Prviewing An Assessment.

Do we log Assessment types:
- Creating An assessment type
- Editing Assessment Type?

Huong Nguyen - 03-Oct-2007 10:24
final draft for action and log for Samigo


Action | Log

Creating a New Assessment | sam.assessment.create
Revising an Assessment: add/edit question, add/edit Part | sam.assessment.revise
EditSetting | sam.setting.edit
Publish An Assessment | sam.assessment.publish
Starting taking An assessment | sam.assessment.take
Submitting an Assessment | sam.assessment.submit





Karen Tsao - 03-Oct-2007 16:43
commit -m "SAK-11137" C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/ItemAuthorBean.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/ItemContentsBean.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/AuthorAssessmentListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/ItemAddListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/PublishAssessmentListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/RemovePartListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SaveAssessmentSettings.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePartListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/delivery/DeliveryActionListener.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/samlite/AssessmentListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/ItemAuthorBean.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/DeliveryBean.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/delivery/ItemContentsBean.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/AuthorAssessmentListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/ItemAddListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/PublishAssessmentListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/RemovePartListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SaveAssessmentSettings.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePartListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/delivery/DeliveryActionListener.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/samlite/AssessmentListener.java
    Transmitting file data ...
    Committed revision 36268.

Huong Nguyen - 08-Oct-2007 12:04
Verified on Stanford nightly, event logs show correctly as desired.

Karen Tsao - 25-Oct-2007 10:27
Because this bug cannot be verified in Official QA instance (need database access to verify the fix), our QA verified it in our local instance. However, she is too efficient that she closed this bug before the fix can get merged into branch :) Therefore, I re-open this bug and request to be merged to the next tag.

Huong Nguyen - 26-Oct-2007 09:49
OOps, sorry! So, I change it to resolve until it is merged to the branch.

Megan May - 29-Oct-2007 13:48
Merged into 2.5.x

Huong Nguyen - 30-Oct-2007 14:09
OK, since it is merged now. I close this.

Megan May - 31-Oct-2007 05:32
Fixes included in 2.5.0.011 tag