[#SAK-11358] Xserver impl gives inadequate information about fatal errors

Sakai

Xserver impl gives inadequate information about fatal errors

Created: 04-Sep-2007 11:08 Updated: 23-Oct-2008 07:48

Component/s:

Citations Helper, Citations (SVN Module)

Affects Version/s:

2.4.0, 2.5.0, 2.4.1

Fix Version/s:

2.5.0

Time Tracking:

Issue & Sub-Tasks

Issue Only

Not Specified

Issue Links:

Incorporate

This issue incorporates:

~~SAK-11949~~ Search appears to time out - no error message

2.4.x Status:	None
2.5.x Status:	None
2.6.x Status:	None

Sub-Tasks:

All

Open

Standardize Citations Helper Exception cases and map to Resource Bundle properties to internationalize

Open

Damian Sobieralski

Description

« Hide

The xserver osid-impl at Michigan failed today because the license agreement had expired. The osid code logged a null-pointer error that provided no information about the actual cause of the problem.

The error message given to users is that the search produced no results.

Ideally, the osid inpl should log as much info as possible about the underlying cause of errors such as this. The message to users might also encourage the user to report the error to the sakai admin.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Jim Eng - 04-Sep-2007 11:10

Here's a sample of the relevant parts of the stack trace in catalina.out when the search fails:

WARN: doURLConnection() - IO exception: Unexpected end of file from server (2007-09-04 12:35:11,412 TP-Processor138_org.sakaibrary.xserver.XServer)
WARN: doBeginSearch() caught Exception (2007-09-04 12:35:11,423 TP-Processor138_org.sakaiproject.citation.tool.CitationHelperAction)
java.lang.NullPointerException
at org.sakaibrary.xserver.XServer.findURL(XServer.java:282)
at org.sakaibrary.xserver.XServer.initAsynchSearch(XServer.java:569)
at org.sakaibrary.osid.repository.xserver.Repository.getAssetsBySearch(Repository.java:483)
at org.sakaiproject.citation.impl.BaseSearchManager.doSearch(BaseSearchManager.java:1984)
at org.sakaiproject.citation.impl.BaseSearchManager$BasicSearch.viewPage(BaseSearchManager.java:294)
at org.sakaiproject.citation.impl.BaseSearchManager$BasicSearch.viewPage(BaseSearchManager.java:740)
at org.sakaiproject.citation.tool.CitationHelperAction.doBeginSearch(CitationHelperAction.java:2552)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.sakaiproject.cheftool.VelocityPortletPaneledAction.actionDispatch(VelocityPortletPaneledAction.java:592)
at org.sakaiproject.cheftool.VelocityPortletPaneledAction.processAction(VelocityPortletPaneledAction.java:508)
at org.sakaiproject.cheftool.ToolServlet.doGet(ToolServlet.java:221)

[ Permlink | « Hide ]

Peter A. Knoop - 15-Oct-2007 09:42

[Bulk Comment] This issues lists a released version of Sakai as its Target Version, however, it is still an unresolved issue. Please update this issues Target Version with a new estimate of when you expect the issue to be addressed. Thanks.

[ Permlink | « Hide ]

Gaurav Cedric Bhatnagar - 17-Oct-2007 04:29

Updating affects and target versions.

[ Permlink | « Hide ]

Gaurav Cedric Bhatnagar - 17-Oct-2007 04:32

Fixing the error/exception reporting for this ticket also fix ~~SAK-11949~~.

[ Permlink | « Hide ]

Gaurav Cedric Bhatnagar - 17-Oct-2007 05:59

Caught a previously un-handled bad connection in the XServer.doURLConnection() method and made sure it reaches the UI as an alert.

I tested this by changing the URL of the metasearch XML gateway to an incorrect value. This accounts for the case that the metasearch engine is unreachable/does not respond, but I do not currently have a way to test on a metasearch instance where I can induce fatal errors.

[ Permlink | « Hide ]

Megan May - 22-Oct-2007 11:37

Will be in 2.5.0.010 tag

[ Permlink | « Hide ]

Deborah Bracken - 05-Nov-2007 11:18

the commits on ~~SAK-11358~~ resolved ~~SAK-11949~~. closed out both issues.