http://qa1-nl.sakaiproject.org/codereview/bug_dashboard/findbugs_generic_null.html
citations NP_ALWAYS_NULL_EXCEPTION org.sakaiproject.citation.impl.DbCitationService$TripleReader 1324 Null pointer dereference of triple in org.sakaiproject.citation.impl.DbCitationService$TripleReader.readSqlResultRecord(ResultSet) on exception path
citations NP_NULL_ON_SOME_PATH_EXCEPTION edu.indiana.lib.twinpeaks.search.singlesearch.CqlParser 115 Possible null pointer dereference of root in edu.indiana.lib.twinpeaks.search.singlesearch.CqlParser.doCQL2MetasearchCommand(String) on exception path
citations NP_NULL_ON_SOME_PATH_EXCEPTION edu.indiana.lib.twinpeaks.search.singlesearch.CqlParser 139 Possible null pointer dereference of byteInputStream in edu.indiana.lib.twinpeaks.search.singlesearch.CqlParser.doCQL2MetasearchCommand(String) on exception path
citations NP_NULL_ON_SOME_PATH_EXCEPTION org.sakaibrary.osid.repository.xserver.AssetIterator 214 Possible null pointer dereference of status in org.sakaibrary.osid.repository.xserver.AssetIterator.nextAsset() on exception path
citations NP_NULL_ON_SOME_PATH_EXCEPTION org.sakaiproject.citation.util.impl.CQL2XServerFindCommand 97 Possible null pointer dereference of root in org.sakaiproject.citation.util.impl.CQL2XServerFindCommand.doCQL2MetasearchCommand(String) on exception path
citations NP_NULL_ON_SOME_PATH_EXCEPTION org.sakaiproject.citation.util.impl.CQL2XServerFindCommand 115 Possible null pointer dereference of byteInputStream in org.sakaiproject.citation.util.impl.CQL2XServerFindCommand.doCQL2MetasearchCommand(String) on exception path
citations NP_NULL_ON_SOME_PATH org.sakaibrary.osid.repository.xserver.Part 120 Possible null pointer dereference of Part.partStructure in new org.sakaibrary.osid.repository.xserver.Part(Id, Serializable, IdManager)
citations NP_NULL_ON_SOME_PATH org.sakaiproject.citation.impl.BaseCitationService$BasicCitation 872 Possible null pointer dereference of creatorList in org.sakaiproject.citation.impl.BaseCitationService$BasicCitation.getCreator()
citations NP_NULL_ON_SOME_PATH org.sakaiproject.citation.impl.BaseSearchManager$BasicSearchDatabaseHierarchy 1708 Possible null pointer dereference of rit in org.sakaiproject.citation.impl.BaseSearchManager$BasicSearchDatabaseHierarchy.getRepository()
citations NP_NULL_ON_SOME_PATH org.sakaiproject.citation.tool.CitationHelperAction 621 Possible null pointer dereference of collection in org.sakaiproject.citation.tool.CitationHelperAction.putCitationCollectionDetails(Context, SessionState)
citations NP_NULL_ON_SOME_PATH org.sakaiproject.citation.tool.CitationHelperAction 683 Possible null pointer dereference of collection in org.sakaiproject.citation.tool.CitationHelperAction.buildAddCitationsPanelContext(VelocityPortlet, Context, RunData, SessionState)
Sub-task
Open
Minor
The issues mentioned are real, as confirmed by a quick review. For example:
On exception line 219 status is null and nullpointer on line 224
http://qa1-nl.sakaiproject.org/codereview/trunk/api/org/sakaibrary/osid/repository/xserver/AssetIterator.java.html#224
216 String status = null;
217
218 try {
219 status = ( String ) statusProperties.getProperty( "status" );
220 } catch( org.osid.shared.SharedException se ) {
221 LOG.warn( "nextAsset() failed getting status property", se );
222 }
223
224 if( !status.equals( "ready" ) ) {
or line 551 suggests that searchProperties can be null, but if that was so then there would already be an NPE on line 543
http://qa1-nl.sakaiproject.org/codereview/trunk/api/org/sakaibrary/osid/repository/xserver/Repository.java.html#543
542 try {
543 guid = ( String ) searchProperties.getProperty( "guid" );
544 } catch( org.osid.shared.SharedException se ) {
545 LOG.warn( "getProperties() could not get guid: " +
546 se.getMessage(), se );
547 throw new org.osid.repository.RepositoryException(
548 org.osid.OsidException.OPERATION_FAILED);
549 }
550
551 if( searchProperties != null ) {