[#SAK-13119] Incoherent event references

Sakai

Incoherent event references

Created: 29-Feb-2008 08:03 Updated: 23-Oct-2008 05:51

Component/s:

Forums

Affects Version/s:

2.5.0, 2.5.2, 2.5.3

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

messageforums-app-event.diff (2 kb)

2.4.x Status:	None
2.5.x Status:	None
2.6.x Status:	None

Description

« Hide

New generated events (forums.*) doesn't have a coherent REF field which makes them unusable for sitestats.

EVENTS OK:
forums.new, forums.read, forums.response
Sample REF:
/forums/site/ee9677b4-ca43-4bc1-bc0b-eff6befd4de6/Message/1/93b62566-e957-47dc-90cf-ce74187c930d

EVENTS NOT OK:
forums.delete
Sample REF: /forums/2/del by/Nuno Fernandes
(Missing siteId)

forums.newtopic and forums.revisetopic
Sample REF:
/forums/site//site/ee9677b4-ca43-4bc1-bc0b-eff6befd4de6/Topic/null/93b62566-e957-47dc-90cf-ce74187c930d
(string '/site/ is in excess)

forums.deleteforum and forums.deletetopic
Sample REF:
/messages/site/ee9677b4-ca43-4bc1-bc0b-eff6befd4de6/Forum/1/93b62566-e957-47dc-90cf-ce74187c930d
(starts with /messages instead of forums/)

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Alessandro Ramos de Oliveira - 06-Jun-2008 09:39

this patch may solve the issue.

the method getEventReference(Message message) had a wrong implemetation.

[ Permlink | « Hide ]

Nuno Fernandes - 09-Jun-2008 07:35

Alessandro, after some testing with patch:

- "forums.newtopic" and "forums.revisetopic" still duplicate the 'site/' string
- "forums.deleteforum" and "forums.deletetopic" start with "/messages&forums/" but should start with "/forums/" as these are forum specific events
- "forums.delete" is now "forums.deletetopic" and "forums.deleteforum". However, both start with "/messages&forums/" but should start with "/forums/" as these are forum specific events

Are you observing a different behavior?

Thank you for your help,
Nuno