History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SAK-3790
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Unassigned
Reporter: John Ellis
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Sakai

The language of the File Selection Helper should be more configurable

Created: 09-Feb-2006 14:38   Updated: 13-Jun-2008 14:44
Component/s: Attachment Widget
Affects Version/s: 2.4.0, 2.4.1
Fix Version/s: 2.5.0, 2.4.x

Time Tracking:
Not Specified

Issue Links:
Duplicate
 
Relate
 

2.4.x Status: Resolved
2.5.x Status: None


 Description  « Hide
From OSP:
http://bugs.osportfolio.org/jira/browse/OSP-1073

I suggest first, that we start calling the "File Picker" the "Item Selection Dialog." I'll refer to it that way in this description...

The Title that currently reads "Add Attachment" is too specific. A better generic title would be: "Select Item"

The instruction text that currently reads:
"Select an existing item from Resources to attach OR add a new item to a folder to be attached. Click "Finish" to complete the set up."

should be changed to:
"Select an existing item from Resources or add a new item from your computer. Once you've made your selection, select 'Finish', or select 'Cancel' to return without making any changes."

The subtitle that currently reads "Items to attach" should read "Selected Items"


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Filter Maintainer - 11-Oct-2006 18:50
Is this still an active issue?

John Ellis - 13-Feb-2007 11:24
this is related to SAK-4130

Harriet Truscott - 10-Apr-2007 03:29
It seems that there are two pieces of text that need to be agreed

- the title (currently 'Add Attachment')
- the instructions

This widget is used in a number of places, so I think the best thing to do is for people to tell me where it's used and in what context, so that I can come up with something which is simultaneously informative and generic.

Perhaps title could be 'Choose Resources', 'Select Resources', 'Pick Resources' or something along these lines.

Note that "add a new item from your computer" has already been suggested and rejected, as it has apparently caused confusion at places where people are uploading resources from a network.

John Ellis - 10-Apr-2007 07:05
that is not at all the case. we don't want some generic text. there is no reason this can't be set by the calling code. it has been set like this in the past. please create another issue if you wish to make the default text generic.

Harriet Truscott - 10-Apr-2007 10:13
Ok - rewording issue for my own clarity when I go through these.

Ensure that title and instructions in the attachments helper is configurable depending on the tool that is using it / context in which it is being used, to allow the title to reflect the process that the user is engaged in.

e.g. Add attachments may be appropriate for wiki, but is not necessarily appropriate for its use in OSP

Jim Eng - 17-May-2007 13:33
We had most of the support already in place. Just needed to put the strings into context.

Harriet Truscott - 01-Jun-2007 08:36
Assigning to John Ellis for testing

Chris Maurer - 01-Jun-2007 11:41
I tested this on nightly a week or so ago and it looked like the only tool doing this was Assignments. None of the OSP tools were setting those other properties.

Harriet Truscott - 07-Jun-2007 09:27
Does Chris's comment mean that it hasn't been fixed?

Jim Eng - 03-Jul-2007 07:27
Is OSP intending to make use of this capability? Should we try to assign it to someone else for verification?

John Ellis - 06-Jul-2007 11:28
i have confirmed that this is working in trunk

John Ellis - 06-Jul-2007 13:01
looks like this still doesn't come through in the "attachments" mode for some reason. i think i have a fix, though

John Ellis - 06-Jul-2007 13:19
turns out it isn't in "attachments" mode that's the problem, it is the "start helper" flag. for some reason, that processing the message initialization twice and the message initialization isn't meant to be processed twice. i'm going to remove that flag from my calling code and see what happens. if you know what that flag is for and why it is causing init to happen twice, please let me know. perhaps the code that flag triggers is just in the wrong place. as far as i can see, the only place that flag is set is in the forms when calling for attachments.

John Ellis - 06-Jul-2007 13:29
removing that attribute worked, though i think there is a separate issue here

Jim Eng - 06-Jul-2007 14:32
I take John's comments to mean this is ready to be merged into the 2.4.x maintenance branch.

Mike Osterman - 06-Jul-2007 21:12
Merged into 2.4.x branch - r32090