|
|
|
[
Permlink
| « Hide
]
Filter Maintainer - 11-Oct-2006 18:50
Is this still an active issue?
It seems that there are two pieces of text that need to be agreed
- the title (currently 'Add Attachment') - the instructions This widget is used in a number of places, so I think the best thing to do is for people to tell me where it's used and in what context, so that I can come up with something which is simultaneously informative and generic. Perhaps title could be 'Choose Resources', 'Select Resources', 'Pick Resources' or something along these lines. Note that "add a new item from your computer" has already been suggested and rejected, as it has apparently caused confusion at places where people are uploading resources from a network. that is not at all the case. we don't want some generic text. there is no reason this can't be set by the calling code. it has been set like this in the past. please create another issue if you wish to make the default text generic.
Ok - rewording issue for my own clarity when I go through these.
Ensure that title and instructions in the attachments helper is configurable depending on the tool that is using it / context in which it is being used, to allow the title to reflect the process that the user is engaged in. e.g. Add attachments may be appropriate for wiki, but is not necessarily appropriate for its use in OSP I tested this on nightly a week or so ago and it looked like the only tool doing this was Assignments. None of the OSP tools were setting those other properties.
Does Chris's comment mean that it hasn't been fixed?
looks like this still doesn't come through in the "attachments" mode for some reason. i think i have a fix, though
turns out it isn't in "attachments" mode that's the problem, it is the "start helper" flag. for some reason, that processing the message initialization twice and the message initialization isn't meant to be processed twice. i'm going to remove that flag from my calling code and see what happens. if you know what that flag is for and why it is causing init to happen twice, please let me know. perhaps the code that flag triggers is just in the wrong place. as far as i can see, the only place that flag is set is in the forms when calling for attachments.
removing that attribute worked, though i think there is a separate issue here
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||