History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SAK-5904
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Huong Nguyen
Reporter: Lydia Li
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Sakai

A disable/enable toggle of all FCK Editors in Authoring screen.

Created: 14-Aug-2006 11:30   Updated: 18-Sep-2008 09:41
Component/s: Tests & Quizzes (Samigo)
Affects Version/s: 2.2.1, 2.3.0, 2.2.2, 2.3.1, 2.2.3
Fix Version/s: 2.4.0

Time Tracking:
Not Specified

File Attachments: 1. PDF File FCKeditor.pdf (34 kb)
2. Text File sam_rte_toggle.patch (9 kb)

Issue Links:
Relate

2.4.x Status: None
2.5.x Status: None


 Description  « Hide
On 8/12/06, Dave Ross <dave.ross@gmail.com> wrote:


We are starting to get into heavier use of sam these days - and are
running into trouble with the authoring UI and wsiwyg editors. A
typical question in one of our assessments has five possible answers
with feedback on each. That leaves us with 13 instances of FCKEditor
on the edit/new question page, which has been crashing browsers and
frustrating users left & right. I've experienced crashes in both
Firefox and IE, and I'm sure it's a lot worse on older hardware.


At first I tried limiting the toolbarset in FCK, which helped
considerably but didn't truly fix the problem. I kept saying to myself
"99 times out of 100 they don't NEED all those rich text editors -
usually the rich text/images/attachments are in the question's text
and nothing else".


So I decided to hack around today and see if I could make the rich
text editors "toggle-able" ala the gmail UI I'm using right now. I
didn't take it as far as being able to go back to "plaintext" mode
after the rich text editor loads, but I did add a simple regex so that
if any html was detected in an existing value, the rich text editor
would load with the page as normal.


Just in playing around, this is a vast improvement - I've scaled 13
FckEditors on the page down to 1 (I left the Question Text as always
rich content), and I would say that it results in a much smoother
authoring experience. The user is still able to add rich text to any
element that they used to be able to - they just have to "turn it on"
with a simple click beforehand.


So obviously this is just a proof-of-concept - I have non-localized
strings in the renderer and I can't figure out how to call the
setFrameHeight(...) javascript from within the renderer (in order to
make sakai re-measure the samigo frame when a user "turns on" rich
text editing for any textbox).


I've attached the patch - it's a change to the RichTextEditor jsf
renderer, tag definition + library, and the multipleChoice.jsp page.
I'd really appreciate some samigo-developer comments on this and would
love to assist in making sam authoring more user-friendly.


thanks,


Dave Ross


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Marc Brierley - 02-Feb-2007 16:13
I really like where this is going. I'm proposing a slight improvement for how this might work in the attached two page pdf.

Karen Tsao - 26-Feb-2007 16:13
commit -m "SAK-5904" C:/sakai/sam/samigo-app/src/java/org/sakaiproject/jsf/renderer/RichTextEditArea.java C:/sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/AuthorMessages.properties C:/sakai/sam/samigo-app/src/webapp/jsf/author/authorSettings.jsp C:/sakai/sam/samigo-app/src/webapp/jsf/author/item/audioRecording.jsp C:/sakai/sam/samigo-app/src/webapp/jsf/author/item/fileUpload.jsp C:/sakai/sam/samigo-app/src/webapp/jsf/author/item/fillInNumeric.jsp C:/sakai/sam/samigo-app/src/webapp/jsf/author/item/fillInTheBlank.jsp C:/sakai/sam/samigo-app/src/webapp/jsf/author/item/matching.jsp C:/sakai/sam/samigo-app/src/webapp/jsf/author/item/multipleChoiceSurvey.jsp C:/sakai/sam/samigo-app/src/webapp/jsf/author/item/shortAnswer.jsp C:/sakai/sam/samigo-app/src/webapp/jsf/author/item/trueFalse.jsp
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/jsf/renderer/RichTextEditArea.java
    Sending sakai/sam/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/AuthorMessages.properties
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/authorSettings.jsp
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/item/audioRecording.jsp
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/item/fileUpload.jsp
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/item/fillInNumeric.jsp
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/item/fillInTheBlank.jsp
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/item/matching.jsp
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/item/multipleChoiceSurvey.jsp
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/item/shortAnswer.jsp
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/item/trueFalse.jsp
    Transmitting file data ...
    Committed revision 21935.

Megan May - 19-Mar-2007 12:59
Updating fix tag to 2.4.0.006

Karen Tsao - 19-Mar-2007 15:13
Per Huong,

There is no toggleable FCK editor in edit part page. Here is the fix:

commit -m "SAK-5904" C:/sakai/sam/samigo-app/src/webapp/jsf/author/editPart.jsp
    Sending sakai/sam/samigo-app/src/webapp/jsf/author/editPart.jsp
    Transmitting file data ...
    Committed revision 23017.

Huong Nguyen - 21-Mar-2007 12:16
Karen, There are a couple more places needed to be added in:
1. Description/Intro under Assessment Type Information in author Settings and Assessment Types.
2. Submission Message in author Settings.
Thanks,
H

Karen Tsao - 21-Mar-2007 15:41
Hi Huong,

Here is the Assessment Type one:
$ svn commit -m "SAK-5904" templateEditor.jsp
Sending templateEditor.jsp
Transmitting file data .
Committed revision 27593.

However, I saw the toggleable FCK editor in both Description/Intro under Assessment Type Information in author Settings and Submission Message in author Settings. Am I missing something? Are we checking on different pages? Thanks.

Huong Nguyen - 22-Mar-2007 10:05
OK, I see it now on nightly, but your last fix in assessment types page has not updated yet on QA officials, I will check it again later. Thanks, Karen!

Huong Nguyen - 22-Mar-2007 10:22
Another problem I found is FCK works well for FF but not for Safari on Mac and IE

 - FCK does not work for safari on Mac OS (when first load the page, it hides Rick -Text Editor when you click on "Show/Hide Rick-Text Editor", the page does nothing - it does not show Rich Text Editor.

- Toggle Show/Hide Rick-Text Editor" link can cause the text editor is not editable on IE6 : Here is what I did:
   1. On Authoring page, click "Settings" under one of existing assessment.
   2. Under Assessment Introduction, click on Title box of Author(s) to make the page focus on other field rather than Description/Intro.
   3. Click on Show/Hide Rich-Text Editor to show the text Editor.
   4. Now, try to edit in the Description box, I cannot. The box is not editable even when I try to click on the toggler over and over again.

However, if I put focus on the text editor box from beginning before toggling the link (after step 2, click the mouse on the text editor box before doing step 3) then I was fine. It seemed like there was focus issue here.

Peter A. Knoop - 24-Mar-2007 14:55
[Bulk Comment] This issue is currenlty classified as a Task scheduled to be addressed for 2.4, however, we are now past the Sakai 2.4 Code Freeze. At this time, work should be focused only on resolving Bugs and addressing release-related Tasks; no features should be added or modified at this point without notifying the Release Mangement team. Please update the estimated Fix Version of this issue to reflect more accurately when it will get addressed, such as in the next release, 2.5.0.000 [Tentative], or set it to Unknown. Thanks.

Karen Tsao - 26-Mar-2007 11:56
Hi Peter,

This is done before 2.4 code freeze. It is re-opened by our QA because a bug is found. Therefore, I think the feature should still be in 2.4 and we will fix this filed issued as a bug. Thanks.

Peter A. Knoop - 26-Mar-2007 12:09
Please report and track Bugs separate from the Task used to track implementation of the feature.

Karen Tsao - 26-Mar-2007 12:22
Hi Huong,
I have re-open another bug for the FCK issue in IE. Other than that issue, if this feature works find, please close this bug. Thanks.

Karen Tsao - 26-Mar-2007 12:23
The new bug I loged is SAK-8992.

Karen Tsao - 26-Mar-2007 13:36
And SAK-8997 as well.

Huong Nguyen - 27-Mar-2007 09:38
verfied FCK on qa2-us. one FCK missing has been opened for SAK-8997 and FCK focus on IE, please see SAK-8992