[#SAK-9785] Creating: Issues with duplicating folders

Sakai

Creating: Issues with duplicating folders

Created: 30-Apr-2007 10:41 Updated: 13-Jun-2008 14:44

Component/s:

Resources

Affects Version/s:

2.4.0, 2.4.1

Fix Version/s:

2.5.0, 2.4.x

Time Tracking:

Not Specified

Issue Links:

Cloners

This issue cloned as:

~~SAK-9813~~ Issues with copying folders

2.4.x Status:	Resolved
2.5.x Status:	None

Description

« Hide

The duplicate function doesn't currently work for folders.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Jim Eng - 01-May-2007 12:32

This seems like two separate issues:

1) The duplicate action being listed for folders but is not actually enabled. For the 2.4 release, we should remove the duplicate action for folders.

2) Copy and move fail in an IdUniquenessException when a folder with the same name already exists in the target collection.

It's less clear what to do about the second problem. Please make that a new ticket and describe the current behavior (in sakai 2.3). We should try to keep the same behavior in that case, if possible. The paste action fails in 2.4.x with nor error message being given to the user.

[ Permlink | « Hide ]

Jim Eng - 01-May-2007 12:33

Here's the relevant part of the stack trace for the IdUniquenessException:

org.sakaiproject.exception.IdUniquenessException: /group/8c460c30-2339-46bd-80a6-808dac85d9c9/target2/source id=/group/8c460c30-2339-46bd-80a6-808dac85d9c9/target2/source
        at org.sakaiproject.content.impl.BaseContentService.deepcopyCollection(BaseContentService.java:4667)
        at org.sakaiproject.content.impl.BaseContentService.copyIntoFolder(BaseContentService.java:3950)
        at org.sakaiproject.content.tool.ResourcesAction.pasteItem(ResourcesAction.java:7649)
        at org.sakaiproject.content.tool.ResourcesAction.doDispatchAction(ResourcesAction.java:5939)

[ Permlink | « Hide ]

Jim Eng - 01-May-2007 12:49

The item about copying a folder into a folder that already has a folder with the same name is in ~~SAK-9813~~. This ticket includes work related to the "duplicate" action for folders.

[ Permlink | « Hide ]

Jim Eng - 01-May-2007 12:49

This should be included in QA tag 2.4.0.014.

Removing the "duplicate" action for folders.

[ Permlink | « Hide ]

Megan May - 02-May-2007 06:45

Should be included in 2.4.0.014 tag; pending successful testing.

[ Permlink | « Hide ]

Harriet Truscott - 02-May-2007 08:34

Verified on Nightly

[ Permlink | « Hide ]

Andrew Poland - 03-May-2007 07:11

svn says nothing to merge, assuming this is incorporated into one of the other fixes already merged.

[ Permlink | « Hide ]

Harriet Truscott - 04-May-2007 07:48

This hasn't appeared in .014, Andrew - I think there must be some code that you've missed?

[ Permlink | « Hide ]

Harriet Truscott - 04-May-2007 07:49

Andrew - the solution was simply to remove the 'duplicate' action from the menu list for folders - is this why you couldn't see it?

[ Permlink | « Hide ]

Jim Eng - 04-May-2007 08:14

There was one subversion commit, r29803, which included a one-line change to /content/trunk/content-impl/impl/src/java/org/sakaiproject/content/types/FolderType.java.

[ Permlink | « Hide ]

Jim Eng - 04-May-2007 08:15

Please include in the next QA tag, 2.4.0.015.

[ Permlink | « Hide ]

Harriet Truscott - 09-May-2007 04:19

verified on Nightly

[ Permlink | « Hide ]

Jim Eng - 01-Jun-2007 10:53

Mike,

Please verify that the one-line change for this ticket was merged into 2.4.0 or 2.4.x. The ticket implies that it wasn't. If it wasn't please merge it into 2.4.x now.

Thanks.

[ Permlink | « Hide ]

Jim Eng - 01-Jun-2007 11:15

Earlier comments indicate this has been verified but not merged, so I'm closing it.

[ Permlink | « Hide ]

Mike Osterman - 01-Jun-2007 11:54

Merged into 2.4.x - 31304