History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: SAK-9813
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Peter A. Knoop
Reporter: Jim Eng
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Sakai

Issues with copying folders

Created: 01-May-2007 12:43   Updated: 23-Oct-2008 08:50
Component/s: Resources
Affects Version/s: 2.4.0
Fix Version/s: 2.4.0

Time Tracking:
Not Specified

Issue Links:
Cloners
 

2.4.x Status: None
2.5.x Status: None
2.6.x Status: None


 Description  « Hide
Copying a folder into a folder which currently contains another folder of the same name fails with no error message to the user. A stack trace indicating an IdUniquenessException shows up in catalina.out.


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Jim Eng - 01-May-2007 12:46
 Here's the relevant part of the stack trace for the IdUniquenessException:

org.sakaiproject.exception.IdUniquenessException: /group/8c460c30-2339-46bd-80a6-808dac85d9c9/target2/source id=/group/8c460c30-2339-46bd-80a6-808dac85d9c9/target2/source
        at org.sakaiproject.content.impl.BaseContentService.deepcopyCollection(BaseContentService.java:4667)
        at org.sakaiproject.content.impl.BaseContentService.copyIntoFolder(BaseContentService.java:3950)
        at org.sakaiproject.content.tool.ResourcesAction.pasteItem(ResourcesAction.java:7649)
        at org.sakaiproject.content.tool.ResourcesAction.doDispatchAction(ResourcesAction.java:5939)

Jim Eng - 01-May-2007 14:12
This should be included in the QA tag 2.4.0.014.

Added an error message that appears if an attempt is made to copy or move a folder into another folder that already contains an item with the same id. This was the behavior in 2.3, but the error message is not being shown in 2.4. This will fix that.

Harriet Truscott - 02-May-2007 01:00
Checked on Nightly and an error message "Could not add 1 to this folder." appears.

This doesn't explain what the problem is / why they can't add the folder. Can we alter the error message to read: "You already have a folder called "1" in this folder."

I will update the Help text to reflect this.

Jim Eng - 02-May-2007 05:46
I need to clarify why the message is not more specific, as Harriet suggests. This restores the message that was shown in 2.3. The circumstances under which that message is shown include (but are not limited to) the case in which a folder of the same name already exists within the containing collection. It's too late to change the logic to give different messages for other causes of this error.

Harriet Truscott - 02-May-2007 06:27
Help text will be updated to reflect this functionality.

Andrew Poland - 03-May-2007 07:13
merged to 2-4-x r29914

Harriet Truscott - 04-May-2007 07:51
verified fixed on QA1-NL