Uploaded image for project: 'Contrib: Evaluation System'
  1. Contrib: Evaluation System
  2. EVALSYS-1462

Improve labels and instructions in Evaluation results box

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.5, 11.x
    • Fix Version/s: 19.x
    • Component/s: Eval Setup
    • Labels:
      None

      Description

      So there's a box when you're creating an evaluation, Evaluation results. If you allow in administrator configurable results sharing for instructors (and students) it lets you select options and there's a date widget that appears. (See screenshots)

      However this date box has no label, tool-tip or any indication for what the date does. What does this date do?

      There's some logic in ReportingPermissionsImpl.

                          if ( (checkDate == null && EvalUtils.checkStateAfter(eval.getState(), EvalConstants.EVALUATION_STATE_VIEWABLE, true))
                                  || (checkDate != null && checkDate.after( new Date() )) 
                                  || (viewSurveyResultsIgnoreDates != null && viewSurveyResultsIgnoreDates)) 
      

      If the date is null and the state is viewable, then it's good. I don't know how to get the date null unless there is no date. Maybe there's a way to not get the date to appear, actually in trunk I can't get the date to appear. Maybe this is a new bug, but the trunk UI is kind of ugly here.

      The second case says that if the date in that box is after today then show it. So, this would mean that this date is the latest date that it can be viewed, not the earliest date, which would be my assumption.

      The last case says that if the option to ignore dates is checked, just view it anyway all the time. This option is "View results whilst survey is still open". This was checked by default.

      So I guess there's could be a few problems here really. Why is the date box not appearing in trunk? Should this be an earliest date or latest date? If it's a latest date, shouldn't it also limit the "View results whilst survey is still open?"

      I feel like the logic is wrong and it's an earliest date, so the UI should reflect that as far as a label goes, and trunk should also display the date (maybe this is another administration setting)

        Gliffy Diagrams

          Zeplin

            Attachments

            1. evalsys ui.PNG
              202 kB
              Matthew Jones
            2. image-2017-10-23-16-03-50-175.png
              30 kB
              Jose Cebellán (Entornos de Formación)
            3. image-2017-10-23-16-06-21-507.png
              34 kB
              Jose Cebellán (Entornos de Formación)
            4. image-2017-10-23-16-06-25-664.png
              36 kB
              Jose Cebellán (Entornos de Formación)
            5. image-2017-10-23-16-07-04-062.png
              43 kB
              Jose Cebellán (Entornos de Formación)

              Issue Links

                Activity

                  People

                  Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  1 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration