Uploaded image for project: 'Contrib: Evaluation System'
  1. Contrib: Evaluation System
  2. EVALSYS-1521

Error starting up if EVAL_EVALUATION-SECTION_AWARE has nulls

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.x
    • Fix Version/s: 11.x
    • Component/s: Other
    • Labels:
      None
    • 11 status:
      Resolved
    • Test Plan:
      Hide

      Test plan requires some manual database manipulation

      • Startup Evaluation using auto-ddl to create the tables
      • Create at least one evaluation
      • Modify the values in EVAL_EVALUATION -> SECTION_AWARE to be null (using SQL or something)
        update EVAL_EVALUATION set SECTION_AWARE = null;
      • Restart the server
      • Actual: The server crashes at startup
      • Expected: No startup issues
      Show
      Test plan requires some manual database manipulation Startup Evaluation using auto-ddl to create the tables Create at least one evaluation Modify the values in EVAL_EVALUATION -> SECTION_AWARE to be null (using SQL or something) update EVAL_EVALUATION set SECTION_AWARE = null; Restart the server Actual: The server crashes at startup Expected: No startup issues

      Description

      It seems like starting up on an with new code provided from EVALSYS-1472 on an existing database (using auto-ddl) can be a problem because it looks the hbm.xml doesn't indicate not-null. The conversion on EVALSYS-1480 does include not null.

      It caused this stacktrace starting up with unboxing the Boolean

      Caused by: java.lang.NullPointerException
              at org.sakaiproject.evaluation.logic.EvalCommonLogicImpl.getUserIdsForEvalGroup(EvalCommonLogicImpl.java:514)
      

      I feel like the better fix is to do a proper comparison of Boolean, maybe just like if BooleanUtils.isTrue(sectionAware). I can create a new issue but we haven't sen much of this

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration