Uploaded image for project: 'Contrib: Evaluation System'
  1. Contrib: Evaluation System
  2. EVALSYS-1523

Stacktrace warning when using adhoc group after EVALSYS-1472

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: RESOLVED
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 11.x
    • Fix Version/s: 11.x, 12.x
    • Labels:
      None
    • 11 status:
      Please Merge
    • Test Plan:
      Hide

      Create an evaluation
      Create an adhoc group (add a student to it)
      Assign to this group

      Take this assessment, this warning comes up in the logs and it's semi concerning. The quickest is to make this assessment anonymous but it comes up either way

      Show
      Create an evaluation Create an adhoc group (add a student to it) Assign to this group Take this assessment, this warning comes up in the logs and it's semi concerning. The quickest is to make this assessment anonymous but it comes up either way

      Description

      When taking and submitting an assessment that's delivered to adhoc groups, this new code in getNodesAboveEvalGroup hits an when delivering to adhoc groups since it's not a site. I think that's fine, it's just that there's no need for a warning and stack trace in the logs.

      22-Jun-2017 16:32:04.998 WARN [http-nio-8080-exec-4] org.sakaiproject.evaluation.logic.externals.ExternalHierarchyLogicImpl.getNodesAboveEvalGroup Could not find site or section by ID
      org.sakaiproject.exception.IdUnusedException id: adhoc-group:1
      	at org.sakaiproject.site.impl.BaseSiteService.getDefinedSite(BaseSiteService.java:675)
      	at org.sakaiproject.site.impl.BaseSiteService.getSite(BaseSiteService.java:753)
      	at org.sakaiproject.evaluation.logic.externals.ExternalHierarchyLogicImpl.getNodesAboveEvalGroup(ExternalHierarchyLogicImpl.java:601)
      

        Gliffy Diagrams

          Zeplin

            Attachments

              Issue Links

                Activity

                  People

                  Assignee:
                  bjones86 Brian Jones
                  Reporter:
                  jonespm Matthew Jones
                  Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                    Dates

                    Created:
                    Updated:
                    Resolved:

                      Git Integration