Uploaded image for project: 'Contrib: Goal Management'
  1. Contrib: Goal Management
  2. GM-54

Remove View Ratings link in Goal Aware Assignment and Data Point when there are no ratings

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 0.7.0, 0.7.1, 2.4.0
    • Fix Version/s: None
    • Component/s: Goal Management Tool
    • Labels:
      None

      Description

      Users are presented with a link to view ratings in Goal Aware Assignment and Data Point, whether or not there are raings available to view. Clicking on the View Rating link when there are no ratings throws this stack trace:

      org.sakaiproject.tool.api.ToolException: Cannot get value for expression '#

      {RatingBean.activity.title}'
      at edu.syr.lsb.datapoint.tool.servlet.DataPointJsfTool.sendToHelper(DataPointJsfTool.java:241)
      caused by: javax.servlet.ServletException: Cannot get value for expression '#{RatingBean.activity.title}

      '
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
      caused by: javax.faces.FacesException: Cannot get value for expression '#

      {RatingBean.activity.title}'
      at org.apache.myfaces.application.jsp.JspViewHandlerImpl.renderView(JspViewHandlerImpl.java:234)
      caused by: org.apache.jasper.JasperException: Cannot get value for expression '#{RatingBean.activity.title}

      '
      at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:393)
      caused by: javax.faces.el.EvaluationException: Cannot get value for expression '#

      {RatingBean.activity.title}

      '
      at javax.faces.component.UIOutput.getValue(UIOutput.java:75)
      caused by: javax.faces.el.EvaluationException: edu.syr.lsb.gmt.tool.helper.rating.RatingBean
      at org.apache.myfaces.el.ELParserHelper$MyPropertySuffix.evaluate(ELParserHelper.java:532)
      caused by: javax.faces.el.EvaluationException: Bean: edu.syr.lsb.gmt.tool.helper.rating.RatingBean, property: activity
      at org.apache.myfaces.el.PropertyResolverImpl.getValue(PropertyResolverImpl.java:71)
      caused by: java.lang.reflect.InvocationTargetException
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      caused by: java.lang.NullPointerException
      at edu.syr.lsb.gmt.impl.LinkableActivityManagerImpl.getItem(LinkableActivityManagerImpl.java:85)
      at edu.syr.lsb.gmt.tool.helper.rating.RatingBean.getItem(RatingBean.java:119)
      at edu.syr.lsb.gmt.tool.helper.rating.RatingBean.getActivity(RatingBean.java:101)
      at sun.reflect.GeneratedMethodAccessor1121.invoke(null:-1)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:585)
      at org.apache.myfaces.el.PropertyResolverImpl.getProperty(PropertyResolverImpl.java:400)
      at org.apache.myfaces.el.PropertyResolverImpl.getValue(PropertyResolverImpl.java:71)
      at org.apache.myfaces.el.ELParserHelper$MyPropertySuffix.evaluate(ELParserHelper.java:532)
      at org.apache.commons.el.ComplexValue.evaluate(ComplexValue.java:145)
      at org.apache.myfaces.el.ValueBindingImpl.getValue(ValueBindingImpl.java:378)
      at javax.faces.component.UIOutput.getValue(UIOutput.java:75)
      at org.apache.myfaces.renderkit.RendererUtils.getStringValue(RendererUtils.java:225)
      at org.apache.myfaces.renderkit.html.HtmlTextRendererBase.renderOutput(HtmlTextRendererBase.java:65)
      at org.apache.myfaces.renderkit.html.HtmlTextRendererBase.encodeEnd(HtmlTextRendererBase.java:53)
      at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:331)
      at javax.faces.webapp.UIComponentTag.encodeEnd(UIComponentTag.java:349)
      at javax.faces.webapp.UIComponentTag.doEndTag(UIComponentTag.java:253)
      at org.apache.jsp.helper.rating.showRatings_jsp._jspx_meth_h_outputText_0(showRatings_jsp.java:337)
      at org.apache.jsp.helper.rating.showRatings_jsp._jspx_meth_sakai_panel_titled_0(showRatings_jsp.java:279)
      at org.apache.jsp.helper.rating.showRatings_jsp._jspx_meth_h_form_0(showRatings_jsp.java:253)
      at org.apache.jsp.helper.rating.showRatings_jsp._jspx_meth_sakai_view_0(showRatings_jsp.java:227)
      at org.apache.jsp.helper.rating.showRatings_jsp._jspx_meth_f_view_0(showRatings_jsp.java:195)
      at org.apache.jsp.helper.rating.showRatings_jsp._jspService(showRatings_jsp.java:142)
      at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:332)
      at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
      at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
      at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:672)
      at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:463)
      at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:398)
      at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:301)
      at org.apache.myfaces.context.servlet.ServletExternalContextImpl.dispatch(ServletExternalContextImpl.java:415)
      at org.apache.myfaces.application.jsp.JspViewHandlerImpl.renderView(JspViewHandlerImpl.java:234)
      at org.sakaiproject.jsf.app.SakaiViewHandler.renderView(SakaiViewHandler.java:137)
      at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:352)
      at javax.faces.webapp.FacesServlet.service(FacesServlet.java:107)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
      at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:501)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
      at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:672)
      at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:463)
      at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:398)
      at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:301)
      at edu.syr.lsb.gmt.tool.servlet.GmtJsfTool.dispatch(GmtJsfTool.java:196)
      at org.sakaiproject.jsf.util.JsfTool.doGet(JsfTool.java:241)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
      at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:672)
      at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:463)
      at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:359)
      at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:301)
      at org.sakaiproject.tool.impl.ActiveToolComponent$MyActiveTool.help(ActiveToolComponent.java:409)
      at edu.syr.lsb.datapoint.tool.servlet.DataPointJsfTool.sendToHelper(DataPointJsfTool.java:241)
      at edu.syr.lsb.datapoint.tool.servlet.DataPointJsfTool.dispatch(DataPointJsfTool.java:97)
      at org.sakaiproject.jsf.util.JsfTool.doGet(JsfTool.java:241)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
      at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:672)
      at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:463)
      at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:359)
      at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:301)
      at org.sakaiproject.tool.impl.ActiveToolComponent$MyActiveTool.forward(ActiveToolComponent.java:339)
      at org.sakaiproject.portal.charon.CharonPortal.forwardTool(CharonPortal.java:1259)
      at org.sakaiproject.portal.charon.CharonPortal.doTool(CharonPortal.java:1211)
      at org.sakaiproject.portal.charon.CharonPortal.doGet(CharonPortal.java:338)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
      at org.sakaiproject.util.RequestFilter.doFilter(RequestFilter.java:532)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
      at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
      at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
      at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
      at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
      at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
      at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
      at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
      at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
      at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
      at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
      at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
      at java.lang.Thread.run(Thread.java:595)

        Gliffy Diagrams

          Zeplin

            Attachments

              Activity

                People

                Assignee:
                jmpease Jim Pease (Inactive)
                Reporter:
                smkeesle Sean Keesler (Inactive)
                Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated: