Uploaded image for project: 'Contrib: Gradebook2'
  1. Contrib: Gradebook2
  2. GRBK-1324

Fix lettergrade-import detection restore point-value imports into lettergrade gradebooks

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.0
    • Fix Version/s: 1.8.0-rc4, 1.8.0
    • Component/s: GWT Client
    • Labels:
      None
    • Target Version:
    • QA Status:
      PASS

      Description

      In the maxpoints conversion dialog listener (which handles the value conversions based on the maxpoints entered by the user), code that attempts to detect the type of data (letter or number) that is imported for an item is not correct and the result is that all imported values are assumed to be letters and so if importing nummbers into LETTERS gradebooks, conversions (appear) to not be done.

      This regular expression is matching all values and the variable is set to TRUE

      if (o.trim().matches("^\\w")) {
      	importingLetters = true;
      	break;
      }
      

      Later that boolean assumeLetterImport (which is currently always TRUE) is used in conjunction with importingIntoLetters (TRUE if the current GradeType == LETTERS) to decide whether to do the actual value conversions.

      	if(!assumeLetterImport || !importingIntoLetters) {
        .. convert values
      

      IMPACT:
      The effect of this logic is that conversions will only take place on values if the import is into a GradeType that is NOT 'LETTERS'

      This suggests that number-valued imports into LETTERS gradebooks is not working

      If true, the result is no different than what happens in 1.7.0

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  ccjon Jon Gorrono
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: