Contrib: Gradebook2
  1. Contrib: Gradebook2
  2. GRBK-35

Add permissions interface to control which TAs have access to which individual grade items

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: trunk, Test-Tag-2-5-x-QA-2
    • Fix Version/s: 1.0.0-b1, 1.0.0-b5, 1.0.0
    • Component/s: GWT Client, Services
    • Labels:
      None

      Description

      We need a permissions interface to replicate the functionality provided by the existing Gradebook1 UI.

        Issue Links

          Activity

          Hide
          Thomas Amsler added a comment -
          Created new taks, GRBK-233, which covers the server side modifications.
          Show
          Thomas Amsler added a comment - Created new taks, GRBK-233 , which covers the server side modifications.
          Hide
          Thomas Amsler added a comment -
          QA Test Plan:

          With this release, we have implemented the Grader Permission Settings "can grade" but not the "can view" functionality.

          Design information:
          - An Instructor has to be able to view/grade everything: all sections, categories, items
          - A TA can view/grade students and times in a section if she/he has been assigned to a section(s) via the Section Info tool
          - A TA can "grade" categories, sections if she/he is given permission via the "Grader Permission Settings"
          - NOTE: If a TA is given any permissions via the "Grader Permission Settings", then these permission(s) take precedence and "overwrite" all the capabilities that were given by assigning the TA to a section via the Section Info tool.

          Setup scenarios:
          - Create course sites with multiple sections and at least two TAs
          - In those course sites, setup Gradebook2 so that we exercise every type/organization: no categories, categories, weighted categories

          Access Grader Permission Settings:
          - As an Instructor, Click on "View" --> "Grader Permission Settings"
          - To assign permissions, first select a user from the Users pull down menu. This will activate the permissions settings user interface for that specific user

          Test scenarios:
          1. Login as an Instructor. Instructor should be able to view/grade all items
          2. Assign TA to a section via the Section Info tool. TA should be able to view/grade all students / items in that section
          3. Assign TA "can grade" permissions via "Grader Permission Settings". TA should only be able to grade items that correspond to those settings
          Show
          Thomas Amsler added a comment - QA Test Plan: With this release, we have implemented the Grader Permission Settings "can grade" but not the "can view" functionality. Design information: - An Instructor has to be able to view/grade everything: all sections, categories, items - A TA can view/grade students and times in a section if she/he has been assigned to a section(s) via the Section Info tool - A TA can "grade" categories, sections if she/he is given permission via the "Grader Permission Settings" - NOTE: If a TA is given any permissions via the "Grader Permission Settings", then these permission(s) take precedence and "overwrite" all the capabilities that were given by assigning the TA to a section via the Section Info tool. Setup scenarios: - Create course sites with multiple sections and at least two TAs - In those course sites, setup Gradebook2 so that we exercise every type/organization: no categories, categories, weighted categories Access Grader Permission Settings: - As an Instructor, Click on "View" --> "Grader Permission Settings" - To assign permissions, first select a user from the Users pull down menu. This will activate the permissions settings user interface for that specific user Test scenarios: 1. Login as an Instructor. Instructor should be able to view/grade all items 2. Assign TA to a section via the Section Info tool. TA should be able to view/grade all students / items in that section 3. Assign TA "can grade" permissions via "Grader Permission Settings". TA should only be able to grade items that correspond to those settings
          Hide
          Peter Peterson added a comment - - edited
          QA FAIL (see comments on GRBK-233)
          Show
          Peter Peterson added a comment - - edited QA FAIL (see comments on GRBK-233 )
          Hide
          Thomas Amsler added a comment -
          I have just committed a fix for the issues that Nancy has found. Fix will be part of v1.0.0-b5.
          Show
          Thomas Amsler added a comment - I have just committed a fix for the issues that Nancy has found. Fix will be part of v1.0.0-b5.
          Hide
          Nancy Wilkison added a comment -
          same as in GRBK-233 as/Sandra

          QA ENVIRONMENT -
          vista enterprise, firefox, ie7
          smartsite-test sakai_2-5-x-test-065 - Sakai 2.5.x-R57934 - Server sakaitest2

          QA SUMMARY -
          today, tested gb2 w/ad hoc groups.
          more details available if needed...until I forget them.
          basically, permissions seems to work with banner sections but is a disaster
          if you use ad hoc groups.

          a- there is still an issue with the default list of students visible (all vs section/group)
          and Thomas knows.
          b -you can limit the view to the appropriate section-students as needed with the view
          dropdown. it makes grading a bit more cumbersome but do-able.

          QA RESULTS -
          QUALIFIED pass
           AS LONG AS YOU DON'T DO GROUPS, so the users need to know this.

          QA COMMENTS -
          1 - b above could cause some confusion among TAs
          if they confer and notice the differences in their default views. not the end of the world.
          2 - gb2 permissions do NOT supersede TA section assignments. they seem to
          be additive, which can lead to strange problems...duplicate student names (see
          attached image) navigation next/previous in learner summary page doesn't work
          correctly, etc.
          I'm not sure how the 2 should work, but I'd vote for ...
          * no permissions in gb2 and section assigned TAs can grade all items for all their section
          students. like the "old" way.
          * gb2 rules take precedence over section TA assignments. I can see a use for this.
          for example - assign a TA to a section in section info (to show up on lab days) but in gb2
          create a rule that he grades sections other than his own. so in gb2 he'd see ONLY the
          students he can grade for that category and NOT his section info assigned sections.
          * if TA needs to grade his and other sections, rules can be adjusted accordingly.
          Show
          Nancy Wilkison added a comment - same as in GRBK-233 as/Sandra QA ENVIRONMENT - vista enterprise, firefox, ie7 smartsite-test sakai_2-5-x-test-065 - Sakai 2.5.x-R57934 - Server sakaitest2 QA SUMMARY - today, tested gb2 w/ad hoc groups. more details available if needed...until I forget them. basically, permissions seems to work with banner sections but is a disaster if you use ad hoc groups. a- there is still an issue with the default list of students visible (all vs section/group) and Thomas knows. b -you can limit the view to the appropriate section-students as needed with the view dropdown. it makes grading a bit more cumbersome but do-able. QA RESULTS - QUALIFIED pass  AS LONG AS YOU DON'T DO GROUPS, so the users need to know this. QA COMMENTS - 1 - b above could cause some confusion among TAs if they confer and notice the differences in their default views. not the end of the world. 2 - gb2 permissions do NOT supersede TA section assignments. they seem to be additive, which can lead to strange problems...duplicate student names (see attached image) navigation next/previous in learner summary page doesn't work correctly, etc. I'm not sure how the 2 should work, but I'd vote for ... * no permissions in gb2 and section assigned TAs can grade all items for all their section students. like the "old" way. * gb2 rules take precedence over section TA assignments. I can see a use for this. for example - assign a TA to a section in section info (to show up on lab days) but in gb2 create a rule that he grades sections other than his own. so in gb2 he'd see ONLY the students he can grade for that category and NOT his section info assigned sections. * if TA needs to grade his and other sections, rules can be adjusted accordingly.
          Hide
          James Renfro added a comment -
          Closing as per discussion on list.
          Show
          James Renfro added a comment - Closing as per discussion on list.

            People

            • Assignee:
              Unassigned
              Reporter:
              James Renfro
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: