Contrib: Gradebook2
  1. Contrib: Gradebook2
  2. GRBK-414

Import doesn't handle grade items that have the same name

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.1.x-test, 1.1.x-prod, 1.3.0-b4
    • Fix Version/s: 1.8.0-a11, 1.8.0-b6, 1.8.0
    • Component/s: GWT Client, Services
    • Labels:
      None
    • Target Version:
    • QA Status:
      PASS

      Description

      This is a categories GB issue. Given two Categories called Category 1, and Category 2 with an item of the same name called Assignment 1, if you import, it will always import and overwrite to the last category that has the item name. So if I import Assignment 1 intending Category 1 to get the update, it will not work. In fact it will import/overwrite to Category 2 -> Assignment 1.

      1. ANT_160_001_WQ_2012 dup.xlsx
        17 kB
        Peter Peterson
      2. GRBK-414.patch
        1 kB
        Jon Gorrono
      3. GRBK-414-Warning.txt
        5 kB
        Thomas Amsler
      4. scantron_dev.xls
        14 kB
        Peter Peterson
      1. excel spread of updated grade export with no structure.jpg
        31 kB
      2. Final Import 4.20.jpg
        937 kB
      3. GRBK-414-Message.png
        37 kB
      4. import of export with structure.jpg
        23 kB
      5. import of updated grade export with no structure.jpg
        29 kB
      6. initial gradebook contents.jpg
        22 kB
      7. Scantron 4.20.jpg
        932 kB
      8. updated gradebook contents after import of updated nostruct file.jpg
        24 kB
      9. XLS 4.20.jpg
        488 kB

        Issue Links

          Activity

          Hide
          Thomas Amsler added a comment -
          QA can you please verify this issue
          Show
          Thomas Amsler added a comment - QA can you please verify this issue
          Hide
          David L. Woods added a comment -
          QA VERIFICATION on:
           smartsite-test26.ucdavis.edu

          QA ENVIRONMENT:
           Win XP with Firefox 3.6.6

          QA TASK:
          GB2 import function: check if grades imported properly from spreadsheet when two categories contain items with the same name

          QA RESULTS:
          in a Weighted Categories Points gradebook

          in test26 and production:
          1- setup two items with the same name (e1) in different categories. second e1 item has scores, and first e1 does not.
          2- Export as ONLY GRADES, to an .XLS file.
          3- in Excel, add grades to first e1 item (empty in exported spreadsheet).
          4- Import the file back into the gradebook.

          --Prod-- the first screen of the import process shows the second e1 columns scores for both the first and second e1 columns in the preview data screen. On completion of the import process, the first e1 column has no grades imported.
          --test26 -- the first screen of the import process shows both e1 columns in the structure side of the screen, but does not display the first e1 column (with either set of grades) in the preview data side of the screen. On completion of the import process, the first e1 column has no grades imported.

          in test26 and production:
          1- setup two items with the same name (e1) in different categories. second e1 item has scores, and first e1 does not.
          2- Export as GRADES & STRUCTURE, to an .XLS file.
          3- in Excel, add grades to first e1 item (empty in exported spreadsheet).
          4- Import the file back into the gradebook.

          --Prod-- all grades imported into the proper columns
          --test26 -- all grades imported into the proper columns

          QA SUMMARY:

          in the situation where a gradebook has multiple columns with the same name in different categories, grades for the last occurrence of the repeated name are the only ones imported -- they are imported into the proper category item. This occurs in both production and test26, although the two processes/screen-arrangements are different.

          QA FAIL

          Note, since everything works properly when the structure is included in the exported file, the workaround for getting grades imported properly when the same item name is used in multiple categories is to export the GRADES & STRUCTURE version, giving the import process more to work with.
          Show
          David L. Woods added a comment - QA VERIFICATION on:  smartsite-test26.ucdavis.edu QA ENVIRONMENT:  Win XP with Firefox 3.6.6 QA TASK: GB2 import function: check if grades imported properly from spreadsheet when two categories contain items with the same name QA RESULTS: in a Weighted Categories Points gradebook in test26 and production: 1- setup two items with the same name (e1) in different categories. second e1 item has scores, and first e1 does not. 2- Export as ONLY GRADES, to an .XLS file. 3- in Excel, add grades to first e1 item (empty in exported spreadsheet). 4- Import the file back into the gradebook. --Prod-- the first screen of the import process shows the second e1 columns scores for both the first and second e1 columns in the preview data screen. On completion of the import process, the first e1 column has no grades imported. --test26 -- the first screen of the import process shows both e1 columns in the structure side of the screen, but does not display the first e1 column (with either set of grades) in the preview data side of the screen. On completion of the import process, the first e1 column has no grades imported. in test26 and production: 1- setup two items with the same name (e1) in different categories. second e1 item has scores, and first e1 does not. 2- Export as GRADES & STRUCTURE, to an .XLS file. 3- in Excel, add grades to first e1 item (empty in exported spreadsheet). 4- Import the file back into the gradebook. --Prod-- all grades imported into the proper columns --test26 -- all grades imported into the proper columns QA SUMMARY: in the situation where a gradebook has multiple columns with the same name in different categories, grades for the last occurrence of the repeated name are the only ones imported -- they are imported into the proper category item. This occurs in both production and test26, although the two processes/screen-arrangements are different. QA FAIL Note, since everything works properly when the structure is included in the exported file, the workaround for getting grades imported properly when the same item name is used in multiple categories is to export the GRADES & STRUCTURE version, giving the import process more to work with.
          Hide
          Sandra Stewart added a comment -
          Programmers will get this in the deployment.
          Show
          Sandra Stewart added a comment - Programmers will get this in the deployment.
          Hide
          Kirk Alexander added a comment -
          For now let's change the UI that if duplicate names do exist that we warn the user to either change the
          duplicate names or proceed via exporting structure as well. That way they won't end up
          with a spreadsheet they cannot import.
          Show
          Kirk Alexander added a comment - For now let's change the UI that if duplicate names do exist that we warn the user to either change the duplicate names or proceed via exporting structure as well. That way they won't end up with a spreadsheet they cannot import.
          Hide
          Thomas Amsler added a comment -
          Changed target version to 1.4 per Joyce's email
          Show
          Thomas Amsler added a comment - Changed target version to 1.4 per Joyce's email
          Hide
          Jon Gorrono added a comment -
          I think this was incorporated by another import-related fix
          Show
          Jon Gorrono added a comment - I think this was incorporated by another import-related fix
          Hide
          Jon Gorrono added a comment - - edited
          There are no more errors produced for duplicate items in different categories, but the handling is still a problem:

          what happens now is the values for the first item that are entered in the spreadsheet, are mapped over the second item:
          - all the score go into the second item's column
          - if the second item has a score, then the second item score is unchanged
          - if the second item has no score, then score entered for the first is put in the second column

          the order is determined by the order in the item tree

          Show
          Jon Gorrono added a comment - - edited There are no more errors produced for duplicate items in different categories, but the handling is still a problem: what happens now is the values for the first item that are entered in the spreadsheet, are mapped over the second item: - all the score go into the second item's column - if the second item has a score, then the second item score is unchanged - if the second item has no score, then score entered for the first is put in the second column the order is determined by the order in the item tree
          Hide
          Jon Gorrono added a comment -
          This is happening because there is not structure data in the file per the test plan added by David 02-Jul-2010 10:28

          To handle this case I changed the code to push all items that have the same name into the Unassigned category for sorting out later

          One suggestion was to change the name of assignements to not conflict (eg, Essay 1 ( 1), Essay (2), ...) ... but this doesn't help to find what category each belongs

          Show
          Jon Gorrono added a comment - This is happening because there is not structure data in the file per the test plan added by David 02-Jul-2010 10:28 To handle this case I changed the code to push all items that have the same name into the Unassigned category for sorting out later One suggestion was to change the name of assignements to not conflict (eg, Essay 1 ( 1), Essay (2), ...) ... but this doesn't help to find what category each belongs
          Hide
          Thomas Amsler added a comment -
          Applied patch to trunk
          Show
          Thomas Amsler added a comment - Applied patch to trunk
          Hide
          Thomas Amsler added a comment -
          Jon's approach as described in his "26-Jan-2011 19:09" comment seems reasonable. Also Kirk gave some directions in his "07-Jul-2010 14:40" comment:

          "For now let's change the UI that if duplicate names do exist that we warn the user to either change the
          duplicate names or proceed via exporting structure as well. That way they won't end up
          with a spreadsheet they cannot import."

          This seems reasonable too.

          As discussed in other import/export related JIRAs and emails the solution to all of this is to include a complete gradebook structure with every export. We just need to figure out how to "hide" the structure for the use cases where user doesn't want to see the structure.
          Show
          Thomas Amsler added a comment - Jon's approach as described in his "26-Jan-2011 19:09" comment seems reasonable. Also Kirk gave some directions in his "07-Jul-2010 14:40" comment: "For now let's change the UI that if duplicate names do exist that we warn the user to either change the duplicate names or proceed via exporting structure as well. That way they won't end up with a spreadsheet they cannot import." This seems reasonable too. As discussed in other import/export related JIRAs and emails the solution to all of this is to include a complete gradebook structure with every export. We just need to figure out how to "hide" the structure for the use cases where user doesn't want to see the structure.
          Hide
          Nancy Wilkison added a comment -
          DEV
          SmartSite@UCDavis - 2.7.2.0 - Sakai 2.7.1 - Server "ucddev1"
          grbk2
          gradebook2 v1.5.0-a4 on smartsite-dev.rsmart.com

          TEST PROCESS -
          test on categories and weighted categories sites
          site CHE 118A A05-A06, categories, points
          1 – added item named fred to categories exams and homework, 100 points each
          2 – graded 1st 4 people for each @ 90 for exams and 80 for homework
          3 – exported grades only as xls
          4 – graded next 4 for each @ 70 and changed 1st 2 to 60 for each
          5 – imported back - @ preview, both freds show in correct category in Lframe
          BUT in Rframe, where grades are listed, there is only 1 fred in exams, but with the homework scores
          6 – continued w/import, no error message re: items of the same name
          7 – homework fred scores are in exams fred and there are NO scores for homework…
          so not only are the scores in the wrong item but the previously existing scores are gone

          got no message as mentioned above.

          quit here as it failed right off the bat

          QA RESULTS -
          fail
          Show
          Nancy Wilkison added a comment - DEV SmartSite@UCDavis - 2.7.2.0 - Sakai 2.7.1 - Server "ucddev1" grbk2 gradebook2 v1.5.0-a4 on smartsite-dev.rsmart.com TEST PROCESS - test on categories and weighted categories sites site CHE 118A A05-A06, categories, points 1 – added item named fred to categories exams and homework, 100 points each 2 – graded 1st 4 people for each @ 90 for exams and 80 for homework 3 – exported grades only as xls 4 – graded next 4 for each @ 70 and changed 1st 2 to 60 for each 5 – imported back - @ preview, both freds show in correct category in Lframe BUT in Rframe, where grades are listed, there is only 1 fred in exams, but with the homework scores 6 – continued w/import, no error message re: items of the same name 7 – homework fred scores are in exams fred and there are NO scores for homework… so not only are the scores in the wrong item but the previously existing scores are gone got no message as mentioned above. quit here as it failed right off the bat QA RESULTS - fail
          Hide
          Jon Gorrono added a comment -
          I think I got it this time.... there were a lot of 'hidden' codes in this part of the import (handleItemOrComment downward... eg, itemModel is null or categoryModel is null sort of thing) and by reworking it so that we can detect collisions and react a little better, I broke some of the covenants... this has taken a bit of time to work out, but as I said I think its ok now... I would vote +2 to rework this to make what it happening much more obvious.
          Show
          Jon Gorrono added a comment - I think I got it this time.... there were a lot of 'hidden' codes in this part of the import (handleItemOrComment downward... eg, itemModel is null or categoryModel is null sort of thing) and by reworking it so that we can detect collisions and react a little better, I broke some of the covenants... this has taken a bit of time to work out, but as I said I think its ok now... I would vote +2 to rework this to make what it happening much more obvious.
          Hide
          Jon Gorrono added a comment -
          adding dependency on GRBK-834 because it is essentially an edit of this ticket's original changes
          Show
          Jon Gorrono added a comment - adding dependency on GRBK-834 because it is essentially an edit of this ticket's original changes
          Hide
          Jon Gorrono added a comment -
          I don't see an estimate in here anywhere... so can't comment about how well that was done.

          Original work was .5.... this time round was about 4.5
          Show
          Jon Gorrono added a comment - I don't see an estimate in here anywhere... so can't comment about how well that was done. Original work was .5.... this time round was about 4.5
          Hide
          Jon Gorrono added a comment -
          This latest change s going to require a re-test of import in all combo's each cat type, whether there is gb structure in file, adding new items, new cats, using existing names items in various cats for new items, renaming items
          Show
          Jon Gorrono added a comment - This latest change s going to require a re-test of import in all combo's each cat type, whether there is gb structure in file, adding new items, new cats, using existing names items in various cats for new items, renaming items
          Hide
          Thomas Amsler added a comment -
          Importing throws an exception right now. I have attached the exception in GRBK-414-Warning.txt
          Show
          Thomas Amsler added a comment - Importing throws an exception right now. I have attached the exception in GRBK-414 -Warning.txt
          Hide
          Jon Gorrono added a comment -

           - removed gradebook structure processing from import file so the following are not read from the import file anymore:
              gb name, gb category type, grade mode
           - the major chnage here is that the gradebookGradeItem object that is used is the existing GB, so new items, changes and comments are added to that
           - fixed bug in the handling of importing of no cat gb's (GRBK-966)
           - refactored some names (minor)
           - removed some dead code and unused assignments
          Show
          Jon Gorrono added a comment -  - removed gradebook structure processing from import file so the following are not read from the import file anymore:     gb name, gb category type, grade mode  - the major chnage here is that the gradebookGradeItem object that is used is the existing GB, so new items, changes and comments are added to that  - fixed bug in the handling of importing of no cat gb's ( GRBK-966 )  - refactored some names (minor)  - removed some dead code and unused assignments
          Hide
          Jon Gorrono added a comment - - edited
          From Nancy
          site CHE 118C A12-A13 sq11 no categories
          1 – exported xls gb changed grades for 1st 5 students item 1 (added .9 to grade), added grades for next students 6-11 (also ending in .9)
          2 – imported back to site. it caught my mistake of too high a grade.
          grades imported – pass now
          3 – check import structure to no cat points nw su11 which also previously failed
          4 – exported xls and imported to no cat points nw su11 which has 6 of the same students. got “user not found” popup as expected. grades came in ok EXCEPT that one that was excused on the original site is not on the new one. is this expected?
          5 – add new items and import – added new item new item 5-16 [25] and grades to current spreadsheet for 1st 5 students. imported. got error message “there is already an item named …” , closed the window and hit continue. it even thought there was already an item named what I called the NEW item - fail
          6 – deleted all items and added another new one second try for new [10] w/scores for 1st 5 students and the item in 5 came in with no scores!!!. - fail
          7 – repeat 6 with another item third try for new [50] w/scores for 1st 5 students. correct item shows in preview screen BUT it’s the item in 6 that comes in, with correct scores.
          Show
          Jon Gorrono added a comment - - edited From Nancy site CHE 118C A12-A13 sq11 no categories 1 – exported xls gb changed grades for 1st 5 students item 1 (added .9 to grade), added grades for next students 6-11 (also ending in .9) 2 – imported back to site. it caught my mistake of too high a grade. grades imported – pass now 3 – check import structure to no cat points nw su11 which also previously failed 4 – exported xls and imported to no cat points nw su11 which has 6 of the same students. got “user not found” popup as expected. grades came in ok EXCEPT that one that was excused on the original site is not on the new one. is this expected? 5 – add new items and import – added new item new item 5-16 [25] and grades to current spreadsheet for 1st 5 students. imported. got error message “there is already an item named …” , closed the window and hit continue. it even thought there was already an item named what I called the NEW item - fail 6 – deleted all items and added another new one second try for new [10] w/scores for 1st 5 students and the item in 5 came in with no scores!!!. - fail 7 – repeat 6 with another item third try for new [50] w/scores for 1st 5 students. correct item shows in preview screen BUT it’s the item in 6 that comes in, with correct scores.
          Hide
          Jon Gorrono added a comment - - edited
          - new item comments are showing up in preview as items
           (had typo in header, this is following spec)
          - farsi item is not matching existing item and then during final step, it is, throwing busniess rule error since it is a 'no cat' gradebook
           (after checking this second case, the farsi item appears twice already in the above CHE gradebook (before import) probably due to GRBK-958, this is to spec)
          Show
          Jon Gorrono added a comment - - edited - new item comments are showing up in preview as items  (had typo in header, this is following spec) - farsi item is not matching existing item and then during final step, it is, throwing busniess rule error since it is a 'no cat' gradebook  (after checking this second case, the farsi item appears twice already in the above CHE gradebook (before import) probably due to GRBK-958 , this is to spec)
          Hide
          Nancy Wilkison added a comment -
          the person with the excused item IS a member on both sites.
          it’s Anderson and the excused item on the original site is item 13.
          the score is on the new site, it’s just not excused.
           

          in adding a new item in #5, I inserted a column to the right of section info,
          added a title and [point value] and graded students.

          re: item 6 – using the spreadsheet in 5, I deleted all the columns to the right
          of section info, added a NEW item title and different point value. at import,
          the new item in #5 came in, with no scores.
           
          re: item 7 – using spreadsheet in 6, I gave another NEW name and new point
          value. at import, the item in 6 came in, with scores.

          I have all the spreadsheets, if you want to create the CHE 118C A12-A13 site
          somewhere else and try importing them. log in as mdnasiri.

          today, the item from 7 is in and I don’t know how it got there? I’m wondering if
          there is some sort of delayed action on things here at home between the time I
          do them and when they appear on screen. I had similar issues with an extra credit
          category a couple of days ago being editable for 10-15 minutes before the extra
          credit check box greyed out.

          Show
          Nancy Wilkison added a comment - the person with the excused item IS a member on both sites. it’s Anderson and the excused item on the original site is item 13. the score is on the new site, it’s just not excused.   in adding a new item in #5, I inserted a column to the right of section info, added a title and [point value] and graded students. re: item 6 – using the spreadsheet in 5, I deleted all the columns to the right of section info, added a NEW item title and different point value. at import, the new item in #5 came in, with no scores.   re: item 7 – using spreadsheet in 6, I gave another NEW name and new point value. at import, the item in 6 came in, with scores. I have all the spreadsheets, if you want to create the CHE 118C A12-A13 site somewhere else and try importing them. log in as mdnasiri. today, the item from 7 is in and I don’t know how it got there? I’m wondering if there is some sort of delayed action on things here at home between the time I do them and when they appear on screen. I had similar issues with an extra credit category a couple of days ago being editable for 10-15 minutes before the extra credit check box greyed out.
          Hide
          Jon Gorrono added a comment -
          As Dave has said, exporting of excused prop is not yet supported... if the grade is imported then it is the same as prod right now.

          I'l try to reproduce the rest... thanks
          Show
          Jon Gorrono added a comment - As Dave has said, exporting of excused prop is not yet supported... if the grade is imported then it is the same as prod right now. I'l try to reproduce the rest... thanks
          Hide
          Jon Gorrono added a comment - - edited
          I had to get GRBK-979 fixed to further test this since I am using openoffice

          All the imported new items I have tried so far following your instructions are correctly importing the items and the scores into no cats and cats gradebooks alike

          Let's get Dave to test this to see what he can see

          We may be seeing some browser differentials .... So Dave should try FF and IE 8-9
          Show
          Jon Gorrono added a comment - - edited I had to get GRBK-979 fixed to further test this since I am using openoffice All the imported new items I have tried so far following your instructions are correctly importing the items and the scores into no cats and cats gradebooks alike Let's get Dave to test this to see what he can see We may be seeing some browser differentials .... So Dave should try FF and IE 8-9
          Hide
          Nancy Wilkison added a comment -
          see comments in grbk-966 from me @ 17-May-2011 20:30 about issues bringing in items w/foreign characters in their names.
          Show
          Nancy Wilkison added a comment - see comments in grbk-966 from me @ 17-May-2011 20:30 about issues bringing in items w/foreign characters in their names.
          Hide
          David L. Woods added a comment -
          QA Test
          smartsite-dev
          firefox 3.6.17

          site PHY 009B A01-A03 FQ 2011
          added categories: cat 1 and cat 2
          added item to each category with the same name: Item 1
          exported xls file with structure
          exported xls without structure.
          import of xls file with structure properly synchronizes the item scores.

          modified scores and added scores (including 1 score over max points) to file without the structure
          imported the updated no-structure xls file.

          Results:
          preview of import grades shows:
               the item name repeated 4 times in the structure assignment grid
               the first grade column is repeated twice in the grade data import preview grid in front of the display of the second input column with the same item name.
               the original first item column occurrence (in Cat 1) in the gradebook is updated with the grades from the first input column
               the original second item column occurrence (in Cat 2) in the gradebook is updated to have no grades
               a new item column occurrence with the same name is created (in the Unassigned category) containing the second input column of grades (that should have been matched to the item in Cat 2.)

          QA Fail

          screenshot images attached.



          Show
          David L. Woods added a comment - QA Test smartsite-dev firefox 3.6.17 site PHY 009B A01-A03 FQ 2011 added categories: cat 1 and cat 2 added item to each category with the same name: Item 1 exported xls file with structure exported xls without structure. import of xls file with structure properly synchronizes the item scores. modified scores and added scores (including 1 score over max points) to file without the structure imported the updated no-structure xls file. Results: preview of import grades shows:      the item name repeated 4 times in the structure assignment grid      the first grade column is repeated twice in the grade data import preview grid in front of the display of the second input column with the same item name.      the original first item column occurrence (in Cat 1) in the gradebook is updated with the grades from the first input column      the original second item column occurrence (in Cat 2) in the gradebook is updated to have no grades      a new item column occurrence with the same name is created (in the Unassigned category) containing the second input column of grades (that should have been matched to the item in Cat 2.) QA Fail screenshot images attached.
          Hide
          Jon Gorrono added a comment -
          punt for 1.5.0 ... we agreed to restart this effort with a refactor tied to GRBK-752
          Show
          Jon Gorrono added a comment - punt for 1.5.0 ... we agreed to restart this effort with a refactor tied to GRBK-752
          Hide
          Thomas Amsler added a comment -
          Unmerged code:

          ~/src/gradebook2-svn/trunk/ # svn merge -r 74210:74209 .
          --- Reverse-merging r74210 into '.':
          U server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java
          U server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java
          U server/src/java/org/sakaiproject/gradebook/gwt/sakai/GradebookImportController.java
          ~/src/gradebook2-svn/trunk/ # svn merge -r 74047:74046 .
          --- Reverse-merging r74047 into '.':
          G server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java
          U client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/ImportExportView.java
          ~/src/gradebook2-svn/trunk/ # svn merge -r 73805:73804 .
          --- Reverse-merging r73805 into '.':
          G server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java
          ~/src/gradebook2-svn/trunk/ # svn merge -r 72368:72367 .
          --- Reverse-merging r72368 into '.':
          G server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java
          psl-247 : ~/src/gradebook2-svn/trunk/ # svn status 0u
          psl-247 : ~/src/gradebook2-svn/trunk/ # svn status -u
          M 74463 server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java
          M 74463 server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java
          M 74463 server/src/java/org/sakaiproject/gradebook/gwt/sakai/GradebookImportController.java
          M 74463 client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/ImportExportView.java
          Status against revision: 74463
          psl-247 : ~/src/gradebook2-svn/trunk/ # svn commit -m "GRBK-414, GRBK-834, GRBK-966 : unmerging code."
          Sending trunk/client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/ImportExportView.java
          Sending trunk/server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java
          Sending trunk/server/src/java/org/sakaiproject/gradebook/gwt/sakai/GradebookImportController.java
          Sending trunk/server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java
          Transmitting file data ....
          Committed revision 74464.
          Show
          Thomas Amsler added a comment - Unmerged code: ~/src/gradebook2-svn/trunk/ # svn merge -r 74210:74209 . --- Reverse-merging r74210 into '.': U server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java U server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java U server/src/java/org/sakaiproject/gradebook/gwt/sakai/GradebookImportController.java ~/src/gradebook2-svn/trunk/ # svn merge -r 74047:74046 . --- Reverse-merging r74047 into '.': G server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java U client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/ImportExportView.java ~/src/gradebook2-svn/trunk/ # svn merge -r 73805:73804 . --- Reverse-merging r73805 into '.': G server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java ~/src/gradebook2-svn/trunk/ # svn merge -r 72368:72367 . --- Reverse-merging r72368 into '.': G server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java psl-247 : ~/src/gradebook2-svn/trunk/ # svn status 0u psl-247 : ~/src/gradebook2-svn/trunk/ # svn status -u M 74463 server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java M 74463 server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java M 74463 server/src/java/org/sakaiproject/gradebook/gwt/sakai/GradebookImportController.java M 74463 client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/ImportExportView.java Status against revision: 74463 psl-247 : ~/src/gradebook2-svn/trunk/ # svn commit -m " GRBK-414 , GRBK-834 , GRBK-966 : unmerging code." Sending trunk/client/src/java/org/sakaiproject/gradebook/gwt/client/gxt/view/ImportExportView.java Sending trunk/server/src/java/org/sakaiproject/gradebook/gwt/sakai/Gradebook2ComponentServiceImpl.java Sending trunk/server/src/java/org/sakaiproject/gradebook/gwt/sakai/GradebookImportController.java Sending trunk/server/src/java/org/sakaiproject/gradebook/gwt/server/ImportExportUtilityImpl.java Transmitting file data .... Committed revision 74464.
          Hide
          Thomas Amsler added a comment -
          Needs design discussion. Not ready for estimation yet.
          Show
          Thomas Amsler added a comment - Needs design discussion. Not ready for estimation yet.
          Hide
          Jon Gorrono added a comment -
          The only remaining issue here occurs during importing of grades-only files... why are planning to fix that while also planning to disallow grades-only import/export?

          scantrons do not seem to have a problem AFAICT

          Show
          Jon Gorrono added a comment - The only remaining issue here occurs during importing of grades-only files... why are planning to fix that while also planning to disallow grades-only import/export? scantrons do not seem to have a problem AFAICT
          Hide
          Jon Gorrono added a comment -
          The remainingg failure for non-structure gb imports will not be fixed since we will be deprecating that format.
          Show
          Jon Gorrono added a comment - The remainingg failure for non-structure gb imports will not be fixed since we will be deprecating that format.
          Hide
          David L. Woods added a comment -
          QA VERIFICATION on: smartsite-test.rsmart.com
          gb version 1.8.0 a6

          QA ENVIRONMENT: Win XP with Firefox 3.6.6

          QA TASK: GB2 import function: check if grades imported properly from spreadsheet when two categories contain items with the same name

           the max points for the first item is set to 100 and the max points for the second is set to 50. two tests.

          use export grades only for one file and export grades and structure for the other.

          with a combination of students with a score in the first item and none in the second, other students with a score in the second item and none in the first, and a student with a grade in each. export and then import unchanged to see if the correct items are updated. When the no-structure spreadsheet is used, import attempts to put scores from the first item into the second item only for those students who had not been scored in the second item. Since the scores for the first item were too large for the max points in the second item they weren't used. all scores were removed from the first item. QA FAIL
          Show
          David L. Woods added a comment - QA VERIFICATION on: smartsite-test.rsmart.com gb version 1.8.0 a6 QA ENVIRONMENT: Win XP with Firefox 3.6.6 QA TASK: GB2 import function: check if grades imported properly from spreadsheet when two categories contain items with the same name  the max points for the first item is set to 100 and the max points for the second is set to 50. two tests. use export grades only for one file and export grades and structure for the other. with a combination of students with a score in the first item and none in the second, other students with a score in the second item and none in the first, and a student with a grade in each. export and then import unchanged to see if the correct items are updated. When the no-structure spreadsheet is used, import attempts to put scores from the first item into the second item only for those students who had not been scored in the second item. Since the scores for the first item were too large for the max points in the second item they weren't used. all scores were removed from the first item. QA FAIL
          Hide
          Jon Gorrono added a comment -
          @David... please re-read my comment on Feb 9th 2012 :)

          Revisit this in QA with the idea we will not fix any non-structure import issues unless they are scantron or clicker related. Pass this if the only issues you found are with non structure gradebook imports.
          Show
          Jon Gorrono added a comment - @David... please re-read my comment on Feb 9th 2012 :) Revisit this in QA with the idea we will not fix any non-structure import issues unless they are scantron or clicker related. Pass this if the only issues you found are with non structure gradebook imports.
          Hide
          Joyce Johnstone added a comment -
          This needs to be fixed in 1.8. Use case for this problem is in RT HD0000000237979

          Hello,

          On my [redacted site name] site, I tried to delete an item named "Quiz #4"
          before uploading a spreadsheet named "quiz #4." Apparently the "delete"
          didn't take, because after I uploaded "quiz #4" the other was still there.
          When I tried to delete "Quiz #4" again, I got "Unexpected response from
          server: 401." I tried deleting "quiz #4" so I could start all over, but I
          got the same error.

          "quiz #4" is worth 5 points under "Quizzes." "Quiz #4," with the capital
          letter, should be deleted.

          I don't understand why, when you fill out a gradebook with item names,
          uploading spreadsheets into those item names is impossible. Instead you
          seem to have to delete the dummy item first. Is there a way around this?
          Every quarter I get in trouble.

          Thank you,
          Show
          Joyce Johnstone added a comment - This needs to be fixed in 1.8. Use case for this problem is in RT HD0000000237979 Hello, On my [redacted site name] site, I tried to delete an item named "Quiz #4" before uploading a spreadsheet named "quiz #4." Apparently the "delete" didn't take, because after I uploaded "quiz #4" the other was still there. When I tried to delete "Quiz #4" again, I got "Unexpected response from server: 401." I tried deleting "quiz #4" so I could start all over, but I got the same error. "quiz #4" is worth 5 points under "Quizzes." "Quiz #4," with the capital letter, should be deleted. I don't understand why, when you fill out a gradebook with item names, uploading spreadsheets into those item names is impossible. Instead you seem to have to delete the dummy item first. Is there a way around this? Every quarter I get in trouble. Thank you,
          Hide
          Peter Peterson added a comment - - edited
          Hi Jon,

          Duplicates in scantrons seem to be working with flying colors, adding -# to each duplication, but while testing full gradbooks I encountered problems with duplicates. Basically, if you have two items with the same name in a category the second item (in fact it's the last duplicate item) is the only one that will import or update.

          EXAMPLE and DETAILS

          SCANTRON - QA PASS
          1. Created scantron item
          2. Imported duplicate named scantrol item
          3. imported as item name -1 as expected
          4. Deleted items
          5. Imported again and imported as expected with normal name; ie., scantron_dev, scantron_dev-1, scantron_dev-2, ...
          * NOTE: see attached image and Excel doc: Scantron 4.20, scantron_dev.xls

          FULL GRADEBOOK - QA FAIL
          1. Exported a full gradebook
          2. Changed added duplicate items
              - only last item in category was imported
              - other duplicate items were ignored
          *NOTE: see attached images and excel doc: XLS 4.20, Final Import 4.20, ANT_160_001_WQ_2012 dup.xlsx

          Show
          Peter Peterson added a comment - - edited Hi Jon, Duplicates in scantrons seem to be working with flying colors, adding -# to each duplication, but while testing full gradbooks I encountered problems with duplicates. Basically, if you have two items with the same name in a category the second item (in fact it's the last duplicate item) is the only one that will import or update. EXAMPLE and DETAILS SCANTRON - QA PASS 1. Created scantron item 2. Imported duplicate named scantrol item 3. imported as item name -1 as expected 4. Deleted items 5. Imported again and imported as expected with normal name; ie., scantron_dev, scantron_dev-1, scantron_dev-2, ... * NOTE: see attached image and Excel doc: Scantron 4.20, scantron_dev.xls FULL GRADEBOOK - QA FAIL 1. Exported a full gradebook 2. Changed added duplicate items     - only last item in category was imported     - other duplicate items were ignored *NOTE: see attached images and excel doc: XLS 4.20, Final Import 4.20, ANT_160_001_WQ_2012 dup.xlsx
          Hide
          Peter Peterson added a comment -
          Reopened to address the full gradebook import
          Show
          Peter Peterson added a comment - Reopened to address the full gradebook import
          Hide
          Jon Gorrono added a comment -
          Two items with the same name in the same cat are not allowed. So the observed behavior is *one* way of complying with that. Please, advise as to what the desired behavior should be.
          Show
          Jon Gorrono added a comment - Two items with the same name in the same cat are not allowed. So the observed behavior is *one* way of complying with that. Please, advise as to what the desired behavior should be.
          Hide
          Peter Peterson added a comment -
          Proposed correction:

          USE CASE (Worst):
          1 - Instructor creates several items and grades assignments (assignment-1, assignment-2, assignment-3), in gradebook.
          2 - Then adds a new assignment item to the gradebook spreadsheet, accidentally names it the same as an existing item (assignment-1)
          3 - Adds grades to the new assignment-1
          4 - Upload spreadsheet to the Gradebook
          5 - New assignment-1 scores overwrite the existing old assignment-1 scores
          6 - There is no error or warning, but the wrong scores are now in item assignment-1

          SUGGESTIONS:
          1 (preferred solution) - Halt import of full grade books if duplicate items are found in a category and describe the problem; "Duplicated item names, all item names must be unique. Please change item name(s) and import again.
          2 (secondary solution) - Warning message, "Warning, you are importing a grade book with duplicated items names. The last duplicated item will be the only item imported."




          Show
          Peter Peterson added a comment - Proposed correction: USE CASE (Worst): 1 - Instructor creates several items and grades assignments (assignment-1, assignment-2, assignment-3), in gradebook. 2 - Then adds a new assignment item to the gradebook spreadsheet, accidentally names it the same as an existing item (assignment-1) 3 - Adds grades to the new assignment-1 4 - Upload spreadsheet to the Gradebook 5 - New assignment-1 scores overwrite the existing old assignment-1 scores 6 - There is no error or warning, but the wrong scores are now in item assignment-1 SUGGESTIONS: 1 (preferred solution) - Halt import of full grade books if duplicate items are found in a category and describe the problem; "Duplicated item names, all item names must be unique. Please change item name(s) and import again. 2 (secondary solution) - Warning message, "Warning, you are importing a grade book with duplicated items names. The last duplicated item will be the only item imported."
          Hide
          Jon Gorrono added a comment -
          We used to have a 'force overwrite' function that would ask the user if they wanted to overwrite the existing items.... this somehow disappeared...(I think the 401 errors we saw and changed the to be more user friendly were due to this error (401 was the chosen code to trigger the dialog)..... the code is all still there, for the most part... but it is just not used now. So we could re-enable that code. I estimate it would take 1/2 day to do it.
          Show
          Jon Gorrono added a comment - We used to have a 'force overwrite' function that would ask the user if they wanted to overwrite the existing items.... this somehow disappeared...(I think the 401 errors we saw and changed the to be more user friendly were due to this error (401 was the chosen code to trigger the dialog)..... the code is all still there, for the most part... but it is just not used now. So we could re-enable that code. I estimate it would take 1/2 day to do it.
          Hide
          Joyce Johnstone added a comment -
          Per 4/24/12 T&S Meeting: Implement suggestion 1. Halt import of full grade books if duplicate items are found in a category and describe the problem; "Duplicated item names, all item names must be unique. Please change item name(s) and import again. Also show the affected category and duplicate item in a dialogue box.
          Show
          Joyce Johnstone added a comment - Per 4/24/12 T&S Meeting: Implement suggestion 1. Halt import of full grade books if duplicate items are found in a category and describe the problem; "Duplicated item names, all item names must be unique. Please change item name(s) and import again. Also show the affected category and duplicate item in a dialogue box.
          Hide
          Jon Gorrono added a comment - - edited
          added a check for already matched cat/item pairs and send user notification of duplicate.

          This will be in B6
          Show
          Jon Gorrono added a comment - - edited added a check for already matched cat/item pairs and send user notification of duplicate. This will be in B6
          Hide
          Thomas Amsler added a comment -
          QA PASS

          Notes:
          - Points based GB
          - Weighted Categories (HW, LAB)
          - Created two Lab 2 items in import file
          - Import process detected issue and showed the following message:

          "There are duplicated items in the file. If there are categories, there can be only one item per category with the same name. Names are case-insensitive. The following item has a duplicate, but there may be more items. Please inspect the file and remove all duplication, then try again: Category 'LAB' - Item 'LAB 2'"
          Show
          Thomas Amsler added a comment - QA PASS Notes: - Points based GB - Weighted Categories (HW, LAB) - Created two Lab 2 items in import file - Import process detected issue and showed the following message: "There are duplicated items in the file. If there are categories, there can be only one item per category with the same name. Names are case-insensitive. The following item has a duplicate, but there may be more items. Please inspect the file and remove all duplication, then try again: Category 'LAB' - Item 'LAB 2'"

            People

            • Assignee:
              Unassigned
              Reporter:
              Michael Wenk
            • Votes:
              4 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: