Uploaded image for project: 'Contrib: Gradebook2'
  1. Contrib: Gradebook2
  2. GRBK-704

Letter Grade mode does not work with Pass/No Pass

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.3.0-b8, 1.3.0-rc1, 1.3.0-b9, 1.3.0-b10
    • Fix Version/s: 1.5.0-a1, 1.5.0
    • Component/s: Services
    • Labels:
      None
    • Target Version:
    • QA Status:
      PASS
    • Previous Issue Keys:

      Description

      Functional descriptions:
      Letter grade gradebook does not work when a user selects one of the following grade format modes:

      • Pass / Not Pass
      • Letter Grades (A, B, C, D, ...)

      If you switch scale to Pass/ No Pass, it does not switch for a letter grade gradebook.

      SP: 7

      Functional Description: For letter-grade grade-books, re-enable the ability to change letter grade mode (P/NP, +/-. etc)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael Wenk added a comment -

            This issue is related to GRBK-695, but was actually caused by code done in GRBK-668

            Show
            Michael Wenk added a comment - This issue is related to GRBK-695 , but was actually caused by code done in GRBK-668
            Hide
            Michael Wenk added a comment -

            How exactly should this behave?

            Show
            Michael Wenk added a comment - How exactly should this behave?
            Hide
            Thomas Amsler added a comment -

            We need to look at this w.r.t. GRBK-803. The MY gradebook doesn't show any grade scale for letter grade type gradebooks. Since scaling a letter grade type gradebook doesn't really make sense. The numeric values that we assign to letter grades don't have anything to do with a grade scale.

            Show
            Thomas Amsler added a comment - We need to look at this w.r.t. GRBK-803 . The MY gradebook doesn't show any grade scale for letter grade type gradebooks. Since scaling a letter grade type gradebook doesn't really make sense. The numeric values that we assign to letter grades don't have anything to do with a grade scale.
            Hide
            Kirk Alexander added a comment -

            The question here is whether the letter grade mode works only with +/- or whether it should allow only solid letters as another option. We should check what myucdavis did here. Secondly, Did MY allow a pass/no pass final grade scale option for gradebooks in which letter grades are entered. If this is to be allowed then switching between the different scales (which would remain un-editable) would have to cause the final course grade to come out as either +/-, solid letters or P/NP depending on the setting. If the change of scales is not supposed to be offered then for letter gradebooks the two extra choices should be removed from the grade scale setting panel. We need outside input on this one.

            Show
            Kirk Alexander added a comment - The question here is whether the letter grade mode works only with +/- or whether it should allow only solid letters as another option. We should check what myucdavis did here. Secondly, Did MY allow a pass/no pass final grade scale option for gradebooks in which letter grades are entered. If this is to be allowed then switching between the different scales (which would remain un-editable) would have to cause the final course grade to come out as either +/-, solid letters or P/NP depending on the setting. If the change of scales is not supposed to be offered then for letter gradebooks the two extra choices should be removed from the grade scale setting panel. We need outside input on this one.
            Hide
            Thomas Amsler added a comment -

            Next steps:

            • Programmer will check with Brian how MY handled the letter grade formats and then report back.
            Show
            Thomas Amsler added a comment - Next steps: Programmer will check with Brian how MY handled the letter grade formats and then report back.
            Hide
            Joyce Johnstone added a comment - - edited

            Per Kirk, Jon, Dave, Joyce, Fernando: Decision has been made to not allow pass/no pass for letter grade gradebooks. This can be resolved by removing "Edit grade scale" from the EDIT menu for letter grade gradebooks.

            Show
            Joyce Johnstone added a comment - - edited Per Kirk, Jon, Dave, Joyce, Fernando: Decision has been made to not allow pass/no pass for letter grade gradebooks. This can be resolved by removing "Edit grade scale" from the EDIT menu for letter grade gradebooks.
            Hide
            Jon Gorrono added a comment -

            disabled Edit-->Grade Scale menu item for lettergrade gradebooks

            Show
            Jon Gorrono added a comment - disabled Edit-->Grade Scale menu item for lettergrade gradebooks
            Hide
            Nancy Wilkison added a comment -

            DEV server
            SmartSite@UCDavis - 2.6.4.4 - Sakai 2.6.2 - Server "ucddev1"

            TEST PROCESS -
            1 – changed CHE 118A A05-A06 to letter grade from points
            2 – in edit-grade scale, message “letter grade scale is not editable”
            3 – changed grade format to pass/not pass
            4 – message “letter grade scale is not editable”
            5 – graded several students. item grades and course grade are still letter +/-

            for pass/not pass grades, I was expecting to SEE pass or not pass in the course grade.
            is this incorrect?

            QA RESULTS -
            is this a pass?

            Show
            Nancy Wilkison added a comment - DEV server SmartSite@UCDavis - 2.6.4.4 - Sakai 2.6.2 - Server "ucddev1" TEST PROCESS - 1 – changed CHE 118A A05-A06 to letter grade from points 2 – in edit-grade scale, message “letter grade scale is not editable” 3 – changed grade format to pass/not pass 4 – message “letter grade scale is not editable” 5 – graded several students. item grades and course grade are still letter +/- for pass/not pass grades, I was expecting to SEE pass or not pass in the course grade. is this incorrect? QA RESULTS - is this a pass?
            Hide
            Michael Wenk added a comment -

            From what I see, the option to even enter editing the grade scale is disabled. I believe this is how it is supposed to work per comments above. When you were in letter grade mode do you see any way to get in the edit grade scale screen ?

            Show
            Michael Wenk added a comment - From what I see, the option to even enter editing the grade scale is disabled. I believe this is how it is supposed to work per comments above. When you were in letter grade mode do you see any way to get in the edit grade scale screen ?
            Hide
            Nancy Wilkison added a comment - - edited

            DEV
            SmartSite@UCDavis - 2.7.2.0 - Sakai 2.7.1 - Server "ucddev1"
            grbk2
            gradebook2 v1.5.0-a3 on smartsite-dev.rsmart.com

            TEST
            SmartSite@UCDavis - 2.7.2.0 - Sakai 2.7.1 - Server "ucdtest2"
            gb2 1.4.1

            ok, today on both servers above, on a letter grade site, selecting Edit from the top menu bar...
            the Grade Scale is greyed out and consequently inaccessible, so you can't edit anything to P/NP.
            obviously this has changed from my previous test, where I could get at the grade scale. now I'm happy

            QA RESULTS -
            pass

            Show
            Nancy Wilkison added a comment - - edited DEV SmartSite@UCDavis - 2.7.2.0 - Sakai 2.7.1 - Server "ucddev1" grbk2 gradebook2 v1.5.0-a3 on smartsite-dev.rsmart.com TEST SmartSite@UCDavis - 2.7.2.0 - Sakai 2.7.1 - Server "ucdtest2" gb2 1.4.1 ok, today on both servers above, on a letter grade site, selecting Edit from the top menu bar... the Grade Scale is greyed out and consequently inaccessible, so you can't edit anything to P/NP. obviously this has changed from my previous test, where I could get at the grade scale. now I'm happy QA RESULTS - pass

              People

              • Assignee:
                Unassigned
                Reporter:
                Michael Wenk
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: