Uploaded image for project: 'Kernel'
  1. Kernel
  2. KNL-1535

Sites with custom title changes created from templates don't keep change

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 11.0
    • Fix Version/s: 12.0 [Tentative]
    • Component/s: Impl
    • Labels:
    • 11 status:
      Merge
    • Property addition/change required:
      Yes
    • Test Plan:
      Hide
      • Login as admin
      • Go to Admin Workspace->Sites
      • Search for the "!user" site, click Add/Edit Pages
      • Select the "Overview" (!user-100) page (With multiple tools)
      • Click Properties
      • Click Tools, Click New Tool
      • Select the sakai.iframe tool, change the title to "Sakai Project", change the source to "http://www.sakaiproject.org"
      • Click Done

      Notice that the title is what you set it to. (Sakai Project)

      • Now click Save
      • Search the site again !user, click Add/Edit Pages
      • Select the "Overview" (!user-100) page (With multiple tools)
      • Click Tools
      • The title should still be what you set it to (previously it would revert because sakai.iframe was not a special tool id)

      Now log with a user that hasn't logged in yet (like student0089)

      • Click Overview
      • Scroll down to the bottom. The tool should have still have it's name it's name "Sakai Project"

      Previously this didn't work because the special tool id overrides didn't work

      Show
      Login as admin Go to Admin Workspace->Sites Search for the "!user" site, click Add/Edit Pages Select the "Overview" (!user-100) page (With multiple tools) Click Properties Click Tools, Click New Tool Select the sakai.iframe tool, change the title to "Sakai Project", change the source to "http://www.sakaiproject.org" Click Done Notice that the title is what you set it to. (Sakai Project) Now click Save Search the site again !user, click Add/Edit Pages Select the "Overview" (!user-100) page (With multiple tools) Click Tools The title should still be what you set it to (previously it would revert because sakai.iframe was not a special tool id) Now log with a user that hasn't logged in yet (like student0089) Click Overview Scroll down to the bottom. The tool should have still have it's name it's name "Sakai Project" Previously this didn't work because the special tool id overrides didn't work

      Description

      There seems to be a problem with KNL-1352.

      It introduced this new page property sitePage.homeToolsCustomTitle that takes toolIds for home tools that have a custom title.

      However, if you add this custom title property to a template site (like !user) because these values are static rather than based on something like the toolId, when the actual sites are created this property isn't correct. Perhaps the property could be updated when the sites are created but it seems easier just to allow user of the tool registration so any tools with that registration will pick up the custom titles. It seems like it has a "special case" for some tools like sakai.iframe but I couldn't even get that to work in testing. (It looks like this is just the else for non homepage sites)

      See test plan

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: