Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-38813

BaseContentResource should check for null objects

    Details

    • Type: Bug
    • Status: CLOSED
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.x
    • Fix Version/s: 2.6.x, 2.8.x
    • Component/s: Kernel
    • Labels:
      None
    • Previous Issue Keys:
      SAK-13057, KNL-383

      Description

      The following null-checks should be added (as uncovered in SAK-13040):

      1. BaseContentService.getResource() doesn't nullcheck before calling unlock() (many other places call unlock() without nullchecks, too).
      2. BaseContentService.unlock() doesn't nullcheck the ID before calling convertLockIfDropbox().
      3. BaseContentService.convertLockIfDropbox(), doesn't nullcheck before string comparison.
      4. BaseContentService.isAttachmentResource() does not nullcheck the ID before string comparison.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  dhorwitz David Horwitz
                  Reporter:
                  bkirschn Beth Kirschner
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code