Kernel
  1. Kernel
  2. KNL-589

Automatic file encoding detection

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.11
    • Fix Version/s: 1.1.14, 1.2.1
    • Component/s: Impl
    • Labels:
      None
    • 1.2 Status:
      Closed
    • CLE Team Issue:
      Yes
    • Previous Issue Keys:
      SAK-17558

      Description

      If you create a file with non standard characters (for example: España) and try to access it, you will get strange symbols. That's because charset is not set neither in ResourceProperties when you upload the file nor BaseContentService when serving the file. I attach the patch for our 2.6.x installation under kernel 1.0.12.
      1. content_encoding.txt
        4 kB
        David Roldán Martínez
      2. ejemplo.htm
        4 kB
        Sam Ottenhoff
      3. SAK-17558-kernel-DH.diff
        4 kB
        David Horwitz

        Issue Links

          Activity

          Hide
          Sam Ottenhoff added a comment -
          Okay here are the steps to replicate this issue:

          1) Go to a course site -> Resources
          2) Upload the ejemplo.htm file attached to this JIRA
          3) Note that pre 2.8 Sakai instances would serve the file as UTF-8 even though the file is encoded as ISO-8859-1

          Sakai 2.8.0 should attempt to detect the encoding of the file and should correctly serve the file as ISO-8859-1.

          Ways to test are Firebug (check the response headers) or curl.
          Show
          Sam Ottenhoff added a comment - Okay here are the steps to replicate this issue: 1) Go to a course site -> Resources 2) Upload the ejemplo.htm file attached to this JIRA 3) Note that pre 2.8 Sakai instances would serve the file as UTF-8 even though the file is encoded as ISO-8859-1 Sakai 2.8.0 should attempt to detect the encoding of the file and should correctly serve the file as ISO-8859-1. Ways to test are Firebug (check the response headers) or curl.
          Hide
          Anthony Whyte added a comment -
          1.1.x r95856.
          Show
          Anthony Whyte added a comment - 1.1.x r95856.
          Hide
          Stephen Marquard added a comment -
          All the related issues need merging to 1.1.x. This change has caused several serious bugs which are fixed in the related issues.
          Show
          Stephen Marquard added a comment - All the related issues need merging to 1.1.x. This change has caused several serious bugs which are fixed in the related issues.
          Hide
          David Horwitz added a comment -
          all related fixes now merged
          Show
          David Horwitz added a comment - all related fixes now merged
          Hide
          Anthony Whyte added a comment -
          Changing the fix version to 1.1.13 to better express what version of kernel-1.1 contains the fixes that eliminate the regressions introduced by KNL-589.
          Show
          Anthony Whyte added a comment - Changing the fix version to 1.1.13 to better express what version of kernel-1.1 contains the fixes that eliminate the regressions introduced by KNL-589 .

            People

            • Assignee:
              David Horwitz
              Reporter:
              David Roldán Martínez
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: