Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.0.11
    • Fix Version/s: None
    • Component/s: API, Impl
    • Labels:
      None

      Description

      A patch to allow for events to be delayed until a specified time. Satisfies the need in SAK-7670 and SAK-12977

        Gliffy Diagrams

        1. knl-62-npe.diff
          1.0 kB
          Carl Hall
        2. sak-7670_avail_noti.diff
          3 kB
          Carl Hall
        3. sak-7670.diff
          23 kB
          Carl Hall

          Issue Links

            Activity

            Hide
            Ian Boston added a comment -

            Very sorry, but this requires an API change and we are 4 weeks after code freeze on the API, so I cant apply this at this time.

            Once 2.6 is out then we can look at this again.

            Show
            Ian Boston added a comment - Very sorry, but this requires an API change and we are 4 weeks after code freeze on the API, so I cant apply this at this time. Once 2.6 is out then we can look at this again.
            Hide
            Stephen Marquard added a comment -

            The problem with SAK-7670 is that as the current code is in trunk, it changes the behaviour in undesireable ways. So things either need to go forwards or backwards, but they can't stay as they are. This issue was bumped from 2.5 release at the last minute as well, so personally my vote would be to go forwards and get this in for 2.5.

            Show
            Stephen Marquard added a comment - The problem with SAK-7670 is that as the current code is in trunk, it changes the behaviour in undesireable ways. So things either need to go forwards or backwards, but they can't stay as they are. This issue was bumped from 2.5 release at the last minute as well, so personally my vote would be to go forwards and get this in for 2.5.
            Hide
            Peter A. Knoop added a comment -

            this change was given an exception, so it should go ahead in time for 2.6. The merge of KNL-62 needs to be coordinated with the merge for SAK-7670, however, otherwise it sounds like trunk might get broken.

            Show
            Peter A. Knoop added a comment - this change was given an exception, so it should go ahead in time for 2.6. The merge of KNL-62 needs to be coordinated with the merge for SAK-7670 , however, otherwise it sounds like trunk might get broken.
            Hide
            Ian Boston added a comment -

            Patch applied,
            kernel maven repo updated
            Thanks

            Show
            Ian Boston added a comment - Patch applied, kernel maven repo updated Thanks
            Hide
            Carl Hall added a comment -

            NPE was found in nightly build. Patch attached to fix it.

            Show
            Carl Hall added a comment - NPE was found in nightly build. Patch attached to fix it.
            Hide
            Ian Boston added a comment -

            New patch applied.
            thanks

            Probably wont get a snapshot out till tomorrow, takes to long on the link I am on.

            Show
            Ian Boston added a comment - New patch applied. thanks Probably wont get a snapshot out till tomorrow, takes to long on the link I am on.
            Hide
            Jean-François Lévêque added a comment -

            Could someone move this task and set the appropriate Fix version. I can't do that because it's a contributed patch.

            Show
            Jean-François Lévêque added a comment - Could someone move this task and set the appropriate Fix version. I can't do that because it's a contributed patch.
            Hide
            Ian Boston added a comment -

            All done,

            Show
            Ian Boston added a comment - All done,
            Hide
            Jean-François Lévêque added a comment -

            Thanks Ian!

            Show
            Jean-François Lévêque added a comment - Thanks Ian!
            Hide
            Stephen Marquard added a comment -

            Don't have JIRA permissions to reopen this, but it needs fixes. See comments in SAK-7670.

            Show
            Stephen Marquard added a comment - Don't have JIRA permissions to reopen this, but it needs fixes. See comments in SAK-7670 .
            Hide
            Ian Boston added a comment -

            please check and close, I should not have closed (request from Stephen Marquard)

            Show
            Ian Boston added a comment - please check and close, I should not have closed (request from Stephen Marquard)
            Hide
            Stephen Marquard added a comment -

            Reopening for some changes as per SAK-7670.

            Show
            Stephen Marquard added a comment - Reopening for some changes as per SAK-7670 .
            Hide
            Stephen Marquard added a comment -

            Changing to blocker to ensure this is addressed for 1.0.1 K1 for 2-6-x.

            Show
            Stephen Marquard added a comment - Changing to blocker to ensure this is addressed for 1.0.1 K1 for 2-6-x.
            Hide
            Carl Hall added a comment -

            Patch that does the following:

            1) Use 'available' & 'write' for resource (not dropbox) functions. Removed 'add' since an 'add' event shouldn't trigger an email.
            2) Updated postAvailableEvent to delay an event if the resource isn't available. If the resource is available, check its properties to see if an 'available' event has been sent before, and if not send one then mark as 'availableNotified'.
            3) Adjust priority of event to 'NOTI_NONE' in commitResourceEdit if resource is not yet available. This keeps 'write' events from sending an email each time an unavailable resource is updated.

            Show
            Carl Hall added a comment - Patch that does the following: 1) Use 'available' & 'write' for resource (not dropbox) functions. Removed 'add' since an 'add' event shouldn't trigger an email. 2) Updated postAvailableEvent to delay an event if the resource isn't available. If the resource is available, check its properties to see if an 'available' event has been sent before, and if not send one then mark as 'availableNotified'. 3) Adjust priority of event to 'NOTI_NONE' in commitResourceEdit if resource is not yet available. This keeps 'write' events from sending an email each time an unavailable resource is updated.
            Hide
            Carl Hall added a comment -

            Patch included for resolution. Assigning to Stephen for review though Ian may need to see this, too.

            Show
            Carl Hall added a comment - Patch included for resolution. Assigning to Stephen for review though Ian may need to see this, too.
            Hide
            Stephen Marquard added a comment -

            Almost done except getting duplicate notifications when revising a resource after it's available.

            Show
            Stephen Marquard added a comment - Almost done except getting duplicate notifications when revising a resource after it's available.
            Hide
            Stephen Marquard added a comment -

            Resolved in trunk and 1.0.x. See KNL-91 for any followup issues.

            Show
            Stephen Marquard added a comment - Resolved in trunk and 1.0.x. See KNL-91 for any followup issues.

              People

              • Assignee:
                Stephen Marquard
                Reporter:
                Carl Hall
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development