Uploaded image for project: 'Sakai'
  1. Sakai
  2. SAK-37838

Error when entry.itemId = null from LSNBLDR-761

    Details

    • Type: Bug
    • Status: Verified
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 12.0
    • Fix Version/s: 11.5 [Tentative], 12.0
    • Component/s: Lessons
    • Labels:
      None
    • 11 status:
      Resolved
    • Previous Issue Keys:
      LSNBLDR-804
    • Test Plan:
      Hide

      Test Plan from Luisa Li

      Login as an instructor to a site with students enrolled and Lessons added

      1. Create a "Student Content" item in a Lessons page
      2. Go to the settings of this student content item and pick "add comments to each page comment" and save.
      3. Login as a student to "Add Your Own Page"
      4. In this student page, add anything (i.e. text content) and the comment section will show up.
      5. Go to the "Reorder" button, you will see the "Comment" item has a number, but no text label. display is totally wrong.
      6. Try to drag the comment item and reorder it and save.
      7. see the error page.

      (Testers note)
      I believe after this fix the content item isn't visible in the re-order anymore after 5 because I'm not seeing it

      Show
      Test Plan from Luisa Li Login as an instructor to a site with students enrolled and Lessons added 1. Create a "Student Content" item in a Lessons page 2. Go to the settings of this student content item and pick "add comments to each page comment" and save. 3. Login as a student to "Add Your Own Page" 4. In this student page, add anything (i.e. text content) and the comment section will show up. 5. Go to the "Reorder" button, you will see the "Comment" item has a number, but no text label. display is totally wrong. 6. Try to drag the comment item and reorder it and save. 7. see the error page. (Testers note) I believe after this fix the content item isn't visible in the re-order anymore after 5 because I'm not seeing it

      Description

      LSNBLDR-761 made this change

       -		    if (canEditPage && entry != null && entry.pageId != null && sharedPages.contains(entry.pageId)) {
       -			UIOutput.make(row, "shared");
       +		    
       +		    if (canEditPage && entry != null && entry.pageId != null) {
      

      However I'm getting an NPE now because of what looks like entry.itemId for some case == null. I think it probably needs at least this check still in there. Maybe the old way way keeping it from failing in here?

      22-Apr-2017 18:54:58.982 WARN [http-nio-8080-exec-4] PonderUtilCore.handleLevel1Error Exception rendering view: 
      java.lang.NullPointerException
      	at org.sakaiproject.lessonbuildertool.tool.producers.PagePickerProducer.fillComponents(PagePickerProducer.java:572)
      	at uk.org.ponder.rsf.view.support.ViewCollector.fillComponents(ViewCollector.java:56)
      

      After importing some packages and trying to navigate to anything (like table of contents) nothing works. This does fix that page but I'm not sure what's causing it yet.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jonespm Matthew Jones
                  Reporter:
                  jonespm Matthew Jones
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Git Source Code